From ee199b9e9fefaead3d9f0fc2e6a6ce302436e7c6 Mon Sep 17 00:00:00 2001 From: Brian Yencho Date: Fri, 25 Aug 2023 16:02:26 -0500 Subject: [PATCH] Fix initial detekt issues (#10) --- .../x8bit/bitwarden/ui/components/PlaceholderComposable.kt | 2 +- .../com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt | 6 ++++-- .../x8bit/bitwarden/ui/feature/rootnav/RootNavViewModel.kt | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/components/PlaceholderComposable.kt b/app/src/main/java/com/x8bit/bitwarden/ui/components/PlaceholderComposable.kt index 4e49f0eda0..10da6da6cf 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/components/PlaceholderComposable.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/components/PlaceholderComposable.kt @@ -14,7 +14,7 @@ import androidx.compose.ui.graphics.Color */ @Composable fun PlaceholderComposable( - text: String = "Placeholder Composable" + text: String = "Placeholder Composable", ) { Box( modifier = Modifier diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt index 18026c3218..c9cd4182bb 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt @@ -18,7 +18,7 @@ import com.x8bit.bitwarden.ui.components.PlaceholderComposable */ @Composable fun RootNavScreen( - viewModel: RootNavViewModel = viewModel() + viewModel: RootNavViewModel = viewModel(), ) { val navController = rememberNavController() val state by viewModel.state.collectAsStateWithLifecycle() @@ -49,6 +49,7 @@ fun RootNavScreen( /** * TODO: move to splash package (BIT-147) */ +@Suppress("TopLevelPropertyNaming") private const val SplashRoute = "splash" /** @@ -81,7 +82,8 @@ private fun NavController.navigateToSplashAsRoot() { /** * TODO move to login package(BIT-146) */ -private val LoginRoute = "login" +@Suppress("TopLevelPropertyNaming") +private const val LoginRoute = "login" /** * Add login destinations to the nav graph. diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavViewModel.kt b/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavViewModel.kt index e336d07d3d..6465de5076 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavViewModel.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavViewModel.kt @@ -21,11 +21,11 @@ class RootNavViewModel @Inject constructor() : ViewModel() { init { viewModelScope.launch { + @Suppress("MagicNumber") delay(1000) _state.value = RootNavState.Login } } - } /**