diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 30718f4d0a..51723a320e 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -57,7 +57,7 @@ android:theme="@style/AutofillTotpCopyTheme" /> (Unit) { - override fun handleAction(action: WebAuthCallbackAction) { +) : BaseViewModel(Unit) { + override fun handleAction(action: AuthCallbackAction) { when (action) { - is WebAuthCallbackAction.IntentReceive -> handleIntentReceived(action) + is AuthCallbackAction.IntentReceive -> handleIntentReceived(action) } } - private fun handleIntentReceived(action: WebAuthCallbackAction.IntentReceive) { + private fun handleIntentReceived(action: AuthCallbackAction.IntentReceive) { val yubiKeyResult = action.intent.getYubiKeyResultOrNull() val captchaCallbackTokenResult = action.intent.getCaptchaCallbackTokenResult() val ssoCallbackResult = action.intent.getSsoCallbackResult() @@ -49,11 +49,11 @@ class WebAuthCallbackViewModel @Inject constructor( } /** - * Actions for the [WebAuthCallbackViewModel]. + * Actions for the [AuthCallbackViewModel]. */ -sealed class WebAuthCallbackAction { +sealed class AuthCallbackAction { /** * Receive Intent by the application. */ - data class IntentReceive(val intent: Intent) : WebAuthCallbackAction() + data class IntentReceive(val intent: Intent) : AuthCallbackAction() } diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/nfc/NfcManagerImpl.kt b/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/nfc/NfcManagerImpl.kt index 0aa8bcd54c..fe4ede3c00 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/nfc/NfcManagerImpl.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/nfc/NfcManagerImpl.kt @@ -5,7 +5,7 @@ import android.app.PendingIntent import android.content.Intent import android.content.IntentFilter import android.nfc.NfcAdapter -import com.x8bit.bitwarden.WebAuthCallbackActivity +import com.x8bit.bitwarden.AuthCallbackActivity import com.x8bit.bitwarden.data.autofill.util.toPendingIntentMutabilityFlag import com.x8bit.bitwarden.data.platform.annotation.OmitFromCoverage @@ -27,7 +27,7 @@ class NfcManagerImpl( PendingIntent.getActivity( activity, 1, - Intent(activity, WebAuthCallbackActivity::class.java).addFlags( + Intent(activity, AuthCallbackActivity::class.java).addFlags( Intent.FLAG_ACTIVITY_CLEAR_TOP or Intent.FLAG_ACTIVITY_SINGLE_TOP, ), PendingIntent.FLAG_UPDATE_CURRENT.toPendingIntentMutabilityFlag(), diff --git a/app/src/test/java/com/x8bit/bitwarden/WebAuthCallbackViewModelTest.kt b/app/src/test/java/com/x8bit/bitwarden/AuthCallbackViewModelTest.kt similarity index 89% rename from app/src/test/java/com/x8bit/bitwarden/WebAuthCallbackViewModelTest.kt rename to app/src/test/java/com/x8bit/bitwarden/AuthCallbackViewModelTest.kt index 85e52d355e..5460149338 100644 --- a/app/src/test/java/com/x8bit/bitwarden/WebAuthCallbackViewModelTest.kt +++ b/app/src/test/java/com/x8bit/bitwarden/AuthCallbackViewModelTest.kt @@ -20,7 +20,7 @@ import org.junit.jupiter.api.AfterEach import org.junit.jupiter.api.BeforeEach import org.junit.jupiter.api.Test -class WebAuthCallbackViewModelTest : BaseViewModelTest() { +class AuthCallbackViewModelTest : BaseViewModelTest() { private val authRepository = mockk { every { setCaptchaCallbackTokenResult(any()) } just runs every { setSsoCallbackResult(any()) } just runs @@ -54,7 +54,7 @@ class WebAuthCallbackViewModelTest : BaseViewModelTest() { every { mockIntent.getYubiKeyResultOrNull() } returns null every { mockIntent.getSsoCallbackResult() } returns null - viewModel.trySendAction(WebAuthCallbackAction.IntentReceive(intent = mockIntent)) + viewModel.trySendAction(AuthCallbackAction.IntentReceive(intent = mockIntent)) verify(exactly = 1) { authRepository.setCaptchaCallbackTokenResult(tokenResult = captchaCallbackTokenResult) } @@ -72,7 +72,7 @@ class WebAuthCallbackViewModelTest : BaseViewModelTest() { every { mockIntent.getYubiKeyResultOrNull() } returns null every { mockIntent.getCaptchaCallbackTokenResult() } returns null - viewModel.trySendAction(WebAuthCallbackAction.IntentReceive(intent = mockIntent)) + viewModel.trySendAction(AuthCallbackAction.IntentReceive(intent = mockIntent)) verify(exactly = 1) { authRepository.setSsoCallbackResult(result = sseCallbackResult) } @@ -87,13 +87,13 @@ class WebAuthCallbackViewModelTest : BaseViewModelTest() { every { mockIntent.getCaptchaCallbackTokenResult() } returns null every { mockIntent.getSsoCallbackResult() } returns null - viewModel.trySendAction(WebAuthCallbackAction.IntentReceive(intent = mockIntent)) + viewModel.trySendAction(AuthCallbackAction.IntentReceive(intent = mockIntent)) verify(exactly = 1) { authRepository.setYubiKeyResult(yubiKeyResult) } } - private fun createViewModel() = WebAuthCallbackViewModel( + private fun createViewModel() = AuthCallbackViewModel( authRepository = authRepository, ) }