From df846374f533ae1cd981e36dffbe33fe5b880851 Mon Sep 17 00:00:00 2001
From: Phil Cappelli <150719757+phil-livefront@users.noreply.github.com>
Date: Tue, 3 Dec 2024 11:35:15 -0500
Subject: [PATCH] PM-15147 - `MasterPasswordGuidanceScreen` PR Cleanup (#4411)

---
 .../MasterPasswordGuidanceScreen.kt                | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt
index e6e164dd31..07f106d4d3 100644
--- a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt
+++ b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt
@@ -76,23 +76,25 @@ fun MasterPasswordGuidanceScreen(
         },
     ) {
         MasterPasswordGuidanceContent(
+            onTryPasswordGeneratorAction = remember(viewModel) {
+                {
+                    viewModel.trySendAction(
+                        MasterPasswordGuidanceAction.TryPasswordGeneratorAction,
+                    )
+                }
+            },
             modifier = Modifier
                 .fillMaxSize()
                 .verticalScroll(rememberScrollState())
                 .standardHorizontalMargin(),
-            onTryPasswordGeneratorAction = {
-                viewModel.trySendAction(
-                    MasterPasswordGuidanceAction.TryPasswordGeneratorAction,
-                )
-            },
         )
     }
 }
 
 @Composable
 private fun MasterPasswordGuidanceContent(
-    modifier: Modifier = Modifier,
     onTryPasswordGeneratorAction: () -> Unit,
+    modifier: Modifier = Modifier,
 ) {
     Column(modifier = modifier) {
         Spacer(modifier = Modifier.height(24.dp))