BIT-1351 Sorting Items by name (#823)

This commit is contained in:
Oleg Semenenko
2024-06-20 17:08:07 +01:00
committed by Álison Fernandes
parent 2dde22f762
commit cf7f0ad7fe
7 changed files with 113 additions and 3 deletions
@@ -18,6 +18,7 @@ import com.x8bit.bitwarden.data.vault.datasource.network.model.createMockLogin
import com.x8bit.bitwarden.data.vault.datasource.network.model.createMockPasswordHistory
import com.x8bit.bitwarden.data.vault.datasource.network.model.createMockSecureNote
import com.x8bit.bitwarden.data.vault.datasource.network.model.createMockUri
import com.x8bit.bitwarden.data.vault.datasource.sdk.model.createMockCipherView
import com.x8bit.bitwarden.data.vault.datasource.sdk.model.createMockSdkAttachment
import com.x8bit.bitwarden.data.vault.datasource.sdk.model.createMockSdkCard
import com.x8bit.bitwarden.data.vault.datasource.sdk.model.createMockSdkCipher
@@ -270,4 +271,29 @@ class VaultSdkCipherExtensionsTest {
sdkFieldType,
)
}
@Suppress("MaxLineLength")
@Test
fun `toSortAlphabetically should sort ciphers by name`() {
val list = listOf(
createMockCipherView(1).copy(name = "c"),
createMockCipherView(1).copy(name = "B"),
createMockCipherView(1).copy(name = "z"),
createMockCipherView(1).copy(name = "A"),
createMockCipherView(1).copy(name = "D"),
)
val expected = listOf(
createMockCipherView(1).copy(name = "A"),
createMockCipherView(1).copy(name = "B"),
createMockCipherView(1).copy(name = "c"),
createMockCipherView(1).copy(name = "D"),
createMockCipherView(1).copy(name = "z"),
)
assertEquals(
expected,
list.sortAlphabetically(),
)
}
}
@@ -2,6 +2,7 @@ package com.x8bit.bitwarden.data.vault.repository.util
import com.bitwarden.core.Collection
import com.x8bit.bitwarden.data.vault.datasource.network.model.SyncResponseJson
import com.x8bit.bitwarden.data.vault.datasource.sdk.model.createMockCollectionView
import org.junit.Test
import org.junit.jupiter.api.Assertions.assertEquals
@@ -56,4 +57,29 @@ class VaultSdkCollectionExtensionsTest {
),
)
}
@Suppress("MaxLineLength")
@Test
fun `toSortAlphabetically should sort collections by name`() {
val list = listOf(
createMockCollectionView(1).copy(name = "c"),
createMockCollectionView(1).copy(name = "B"),
createMockCollectionView(1).copy(name = "z"),
createMockCollectionView(1).copy(name = "A"),
createMockCollectionView(1).copy(name = "D"),
)
val expected = listOf(
createMockCollectionView(1).copy(name = "A"),
createMockCollectionView(1).copy(name = "B"),
createMockCollectionView(1).copy(name = "c"),
createMockCollectionView(1).copy(name = "D"),
createMockCollectionView(1).copy(name = "z"),
)
assertEquals(
expected,
list.sortAlphabetically(),
)
}
}
@@ -1,6 +1,7 @@
package com.x8bit.bitwarden.data.vault.repository.util
import com.x8bit.bitwarden.data.vault.datasource.network.model.createMockFolder
import com.x8bit.bitwarden.data.vault.datasource.sdk.model.createMockFolderView
import com.x8bit.bitwarden.data.vault.datasource.sdk.model.createMockSdkFolder
import org.junit.Assert.assertEquals
import org.junit.Test
@@ -32,4 +33,29 @@ class VaultSdkFolderExtensionsTest {
sdkFolder,
)
}
@Suppress("MaxLineLength")
@Test
fun `toSortAlphabetically should sort folders by name`() {
val list = listOf(
createMockFolderView(1).copy(name = "c"),
createMockFolderView(1).copy(name = "D"),
createMockFolderView(1).copy(name = "B"),
createMockFolderView(1).copy(name = "A"),
createMockFolderView(1).copy(name = "z"),
)
val expected = listOf(
createMockFolderView(1).copy(name = "A"),
createMockFolderView(1).copy(name = "B"),
createMockFolderView(1).copy(name = "c"),
createMockFolderView(1).copy(name = "D"),
createMockFolderView(1).copy(name = "z"),
)
assertEquals(
expected,
list.sortAlphabetically(),
)
}
}