github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-29 23:28:08 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

Revert "PM-19131 - moved isVisible logic for hidden custom fields to be managed on view side vs model side"

Browse Source 
This reverts commit bc76e46185.
This commit is contained in:
Philip Cappelli
2025-03-26 14:10:15 -04:00
parent bc76e46185
commit c0707ae08c
6 changed files with 31 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt
+4
View File
@@ -779,6 +779,7 @@ class VaultItemScreenTest : BaseComposeTest() {
name = "hidden",
value = "hidden password",
isCopyable = true,
isVisible = false,
)
EMPTY_VIEW_STATES
@@ -816,6 +817,7 @@ class VaultItemScreenTest : BaseComposeTest() {
name = "hidden",
value = "hidden password",
isCopyable = true,
isVisible = false,
)
EMPTY_VIEW_STATES
@@ -856,6 +858,7 @@ class VaultItemScreenTest : BaseComposeTest() {
name = "hidden",
value = "hidden password",
isCopyable = true,
isVisible = false,
)
EMPTY_VIEW_STATES
@@ -3154,6 +3157,7 @@ private val DEFAULT_COMMON: VaultItemState.ViewState.Content.Common =
name = "hidden",
value = "hidden password",
isCopyable = true,
isVisible = false,
),
VaultItemState.ViewState.Content.Common.Custom.BooleanField(
name = "boolean",
app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt
+4 -1
View File
@@ -1073,6 +1073,7 @@ class VaultItemViewModelTest : BaseViewModelTest() {
name = "hidden",
value = "value",
isCopyable = true,
isVisible = false,
)
every {
mockCipherView.toViewState(
@@ -1137,6 +1138,7 @@ class VaultItemViewModelTest : BaseViewModelTest() {
name = "hidden",
value = "value",
isCopyable = true,
isVisible = false,
)
val loginViewState = VaultItemState.ViewState.Content(
common = createCommonContent(
@@ -1180,7 +1182,7 @@ class VaultItemViewModelTest : BaseViewModelTest() {
viewState = loginViewState.copy(
common = createCommonContent(isEmpty = true, isPremiumUser = true).copy(
requiresReprompt = false,
customFields = listOf(hiddenField),
customFields = listOf(hiddenField.copy(isVisible = true)),
),
),
),
@@ -3708,6 +3710,7 @@ class VaultItemViewModelTest : BaseViewModelTest() {
name = "hidden",
value = "value",
isCopyable = true,
isVisible = false,
),
VaultItemState.ViewState.Content.Common.Custom.BooleanField(
name = "boolean",
app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt
+1
View File
@@ -197,6 +197,7 @@ fun createCommonContent(
name = "hidden",
value = "value",
isCopyable = true,
isVisible = false,
),
VaultItemState.ViewState.Content.Common.Custom.BooleanField(
name = "boolean",