From bdf50fd1a65d65883f57d5636947063de0f42ca5 Mon Sep 17 00:00:00 2001 From: Philip Cappelli Date: Tue, 1 Apr 2025 11:59:03 -0400 Subject: [PATCH] PR comments --- .../ui/vault/feature/item/VaultItemViewModel.kt | 3 +++ .../vault/feature/item/util/VaultItemTestUtil.kt | 15 ++++++++++----- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt index 15a7494e01..380f86164f 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt @@ -1597,6 +1597,9 @@ data class VaultItemState( * Represents a custom field, TextField, HiddenField, BooleanField, or LinkedField. */ sealed class Custom : Parcelable { + /** + * The unique ID of the custom field. + */ abstract val id: String /** diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt b/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt index 0f0c9cc6b0..f9a50a948c 100644 --- a/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt +++ b/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt @@ -192,31 +192,36 @@ fun createCommonContent( value = "value", type = FieldType.TEXT, linkedId = null, - ).toCustomField(null), + ) + .toCustomField(null), FieldView( name = "hidden", value = "value", type = FieldType.HIDDEN, linkedId = null, - ).toCustomField(null), + ) + .toCustomField(null), FieldView( name = "boolean", value = "true", type = FieldType.BOOLEAN, linkedId = null, - ).toCustomField(null), + ) + .toCustomField(null), FieldView( name = "linked username", value = null, type = FieldType.LINKED, linkedId = 100U, - ).toCustomField(null), + ) + .toCustomField(null), FieldView( name = "linked password", value = null, type = FieldType.LINKED, linkedId = 101U, - ).toCustomField(null), + ) + .toCustomField(null), ), requiresReprompt = true, requiresCloneConfirmation = true,