github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-01 18:26:31 -05:00
Code Issues 1.8k Packages Projects Releases 126 Wiki Activity

BIT-994 Use dialogs instead of dropdowns on generator (#188)

Browse Source
This commit is contained in:
Andrew Haisting
2023-10-31 11:27:04 -05:00
committed by GitHub
parent 5e36e6a7d1
commit b9a4a6714e
2 changed files with 36 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt
View File

@@ -3,12 +3,15 @@ package com.x8bit.bitwarden.ui.tools.feature.generator
import androidx.compose.ui.semantics.ProgressBarRangeInfo
import androidx.compose.ui.semantics.SemanticsProperties
import androidx.compose.ui.test.SemanticsMatcher.Companion.expectValue
import androidx.compose.ui.test.assert
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.assertIsOff
import androidx.compose.ui.test.assertIsOn
import androidx.compose.ui.test.filterToOne
import androidx.compose.ui.test.hasAnyAncestor
import androidx.compose.ui.test.hasContentDescription
import androidx.compose.ui.test.hasProgressBarRangeInfo
import androidx.compose.ui.test.isDialog
import androidx.compose.ui.test.onAllNodesWithText
import androidx.compose.ui.test.onChildren
import androidx.compose.ui.test.onLast
@@ -96,6 +99,7 @@ class GeneratorScreenTest : BaseComposeTest() {
.onAllNodesWithText(text = "Password")
.onLast()
.performScrollTo()
.assert(hasAnyAncestor(isDialog()))
.performClick()
verify {
@@ -103,6 +107,11 @@ class GeneratorScreenTest : BaseComposeTest() {
GeneratorAction.MainTypeOptionSelect(GeneratorState.MainTypeOption.PASSWORD),
)
}
// Make sure dialog is hidden:
composeTestRule
.onNode(isDialog())
.assertDoesNotExist()
}
@Test
@@ -120,6 +129,7 @@ class GeneratorScreenTest : BaseComposeTest() {
composeTestRule
.onAllNodesWithText(text = "Passphrase")
.onLast()
.assert(hasAnyAncestor(isDialog()))
.performClick()
verify {
@@ -129,6 +139,11 @@ class GeneratorScreenTest : BaseComposeTest() {
),
)
}
// Make sure dialog is hidden:
composeTestRule
.onNode(isDialog())
.assertDoesNotExist()
}
//region Passcode Password Tests