BIT-1277 BIT-1279: Confirmation dialog (#805)

This commit is contained in:
Shannon Draeker
2024-06-20 17:08:07 +01:00
committed by Álison Fernandes
parent f023650730
commit b991acd0d0
4 changed files with 84 additions and 32 deletions
@@ -1,6 +1,10 @@
package com.x8bit.bitwarden.ui.platform.feature.settings.exportvault
import androidx.compose.ui.test.assert
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.filterToOne
import androidx.compose.ui.test.hasAnyAncestor
import androidx.compose.ui.test.isDialog
import androidx.compose.ui.test.isDisplayed
import androidx.compose.ui.test.onAllNodesWithText
import androidx.compose.ui.test.onFirst
@@ -13,6 +17,7 @@ import com.x8bit.bitwarden.data.platform.repository.util.bufferedMutableSharedFl
import com.x8bit.bitwarden.ui.platform.base.BaseComposeTest
import com.x8bit.bitwarden.ui.platform.base.util.asText
import com.x8bit.bitwarden.ui.platform.feature.settings.exportvault.model.ExportVaultFormat
import com.x8bit.bitwarden.ui.util.assertNoDialogExists
import io.mockk.every
import io.mockk.mockk
import io.mockk.verify
@@ -65,13 +70,48 @@ class ExportVaultScreenTest : BaseComposeTest() {
}
@Test
fun `export vault button click should emit ExportVaultClick action`() {
fun `export vault button click should display confirmation dialog`() {
composeTestRule.onNodeWithText("Confirm vault export").assertDoesNotExist()
// Click the export vault button shows the alert.
composeTestRule
.onAllNodesWithText("Export vault")
.onFirst()
.performClick()
composeTestRule
.onNodeWithText("Confirm vault export")
.assert(hasAnyAncestor(isDialog()))
.assertIsDisplayed()
// Clicking the cancel button dismisses the alert.
composeTestRule
.onNodeWithText("Cancel")
.assert(hasAnyAncestor(isDialog()))
.performClick()
composeTestRule.assertNoDialogExists()
}
@Test
fun `confirm export vault button click should send ConfirmExportClick action`() {
composeTestRule.onNodeWithText("Confirm vault export").assertDoesNotExist()
// Click the export vault button shows the alert.
composeTestRule
.onAllNodesWithText("Export vault")
.onFirst()
.performClick()
composeTestRule
.onNodeWithText("Confirm vault export")
.assert(hasAnyAncestor(isDialog()))
.assertIsDisplayed()
// Clicking the confirm button sends the confirm action.
composeTestRule
.onAllNodesWithText("Export vault")
.filterToOne(hasAnyAncestor(isDialog()))
.performClick()
verify {
viewModel.trySendAction(ExportVaultAction.ExportVaultClick)
viewModel.trySendAction(ExportVaultAction.ConfirmExportVaultClicked)
}
}
@@ -3,7 +3,6 @@ package com.x8bit.bitwarden.ui.platform.feature.settings.exportvault
import androidx.lifecycle.SavedStateHandle
import app.cash.turbine.test
import com.x8bit.bitwarden.ui.platform.base.BaseViewModelTest
import com.x8bit.bitwarden.ui.platform.base.util.asText
import com.x8bit.bitwarden.ui.platform.feature.settings.exportvault.model.ExportVaultFormat
import kotlinx.coroutines.test.runTest
import org.junit.jupiter.api.Assertions.assertEquals
@@ -50,18 +49,6 @@ class ExportVaultViewModelTest : BaseViewModelTest() {
}
}
@Test
fun `ExportVaultClick should emit ShowToast`() = runTest {
val viewModel = createViewModel()
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(ExportVaultAction.ExportVaultClick)
assertEquals(
ExportVaultEvent.ShowToast(message = "Coming soon to an app near you!".asText()),
awaitItem(),
)
}
}
@Test
fun `PasswordInputChanged should update the password input in the state`() = runTest {
val viewModel = createViewModel()