github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-29 07:56:39 -05:00
Code Issues 1.6k Packages Projects Releases 125 Wiki Activity

Persist VaultTimeoutAction as a String (#583)

Browse Source
This commit is contained in:
Brian Yencho
2024-01-11 20:59:57 -06:00
committed by GitHub
parent 4d386e1001
commit b26ee0f269
3 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceTest.kt
View File

@@ -104,9 +104,9 @@ class SettingsDiskSourceTest {
val vaultTimeoutAction = VaultTimeoutAction.LOCK
fakeSharedPreferences
.edit()
.putInt(
.putString(
"${vaultTimeoutActionBaseKey}_$mockUserId",
vaultTimeoutAction.value,
"0",
)
.apply()
val actual = settingsDiskSource.getVaultTimeoutAction(userId = mockUserId)
@@ -149,12 +149,12 @@ class SettingsDiskSourceTest {
userId = mockUserId,
vaultTimeoutAction = vaultTimeoutAction,
)
val actual = fakeSharedPreferences.getInt(
val actual = fakeSharedPreferences.getString(
"${vaultTimeoutActionBaseKey}_$mockUserId",
0,
null,
)
assertEquals(
vaultTimeoutAction.value,
"0",
actual,
)
}
@@ -163,16 +163,14 @@ class SettingsDiskSourceTest {
fun `storeVaultTimeoutAction for null values should clear SharedPreferences`() {
val vaultTimeoutActionBaseKey = "bwPreferencesStorage:vaultTimeoutAction"
val mockUserId = "mockUserId"
val previousValue = VaultTimeoutAction.LOCK
val vaultTimeoutActionKey = "${vaultTimeoutActionBaseKey}_$mockUserId"
fakeSharedPreferences.edit {
putInt(vaultTimeoutActionKey, previousValue.value)
putString(vaultTimeoutActionKey, "0")
}
assertTrue(fakeSharedPreferences.contains(vaultTimeoutActionKey))
settingsDiskSource.storeVaultTimeoutAction(
userId = mockUserId,
vaultTimeoutAction = null,
)
assertFalse(fakeSharedPreferences.contains(vaultTimeoutActionKey))
assertNull(fakeSharedPreferences.getString(vaultTimeoutActionKey, null))
}
}