From b0edb7cf3bda6b45d4dabcd317e8da8186fcf413 Mon Sep 17 00:00:00 2001 From: vphan916 <95309255+vphan916@users.noreply.github.com> Date: Mon, 30 Sep 2024 20:45:27 +0000 Subject: [PATCH] Added locators for the settings page and the Add Code button (#203) --- .../feature/itemlisting/ItemListingScreen.kt | 4 +++- .../feature/settings/SettingsScreen.kt | 18 ++++++++++++++---- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/app/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt b/app/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt index 4bdb2e94d0..dbde557f30 100644 --- a/app/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt +++ b/app/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt @@ -522,7 +522,9 @@ fun EmptyItemListingContent( Spacer(modifier = Modifier.height(16.dp)) BitwardenFilledTonalButton( - modifier = Modifier.fillMaxWidth(), + modifier = Modifier + .semantics { testTag = "AddCodeButton" } + .fillMaxWidth(), label = stringResource(R.string.add_code), onClick = onAddCodeClick, ) diff --git a/app/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt b/app/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt index cdb1f7a560..0b2017eab5 100644 --- a/app/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt +++ b/app/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt @@ -251,7 +251,8 @@ private fun VaultSettings( BitwardenTextRow( text = stringResource(id = R.string.import_vault), onClick = onImportClick, - modifier = modifier, + modifier = modifier + .semantics { testTag = "Import" }, withDivider = true, content = { Icon( @@ -268,7 +269,8 @@ private fun VaultSettings( BitwardenTextRow( text = stringResource(id = R.string.export), onClick = onExportClick, - modifier = modifier, + modifier = modifier + .semantics { testTag = "Export" }, withDivider = true, content = { Icon( @@ -285,6 +287,8 @@ private fun VaultSettings( BitwardenExternalLinkRow( text = stringResource(R.string.backup), onConfirmClick = onBackupClick, + modifier = modifier + .semantics { testTag = "Backup" }, dialogTitle = stringResource(R.string.data_backup_title), dialogMessage = stringResource(R.string.data_backup_message), dialogConfirmButtonText = stringResource(R.string.learn_more), @@ -413,13 +417,16 @@ private fun HelpSettings( BitwardenTextRow( text = stringResource(id = R.string.launch_tutorial), onClick = onTutorialClick, - modifier = modifier, + modifier = modifier + .semantics { testTag = "LaunchTutorial" }, withDivider = true, ) Spacer(modifier = Modifier.height(8.dp)) BitwardenExternalLinkRow( text = stringResource(id = R.string.bitwarden_help_center), onConfirmClick = onHelpCenterClick, + modifier = modifier + .semantics { testTag = "BitwardenHelpCenter" }, dialogTitle = stringResource(id = R.string.continue_to_help_center), dialogMessage = stringResource( id = R.string.learn_more_about_how_to_use_bitwarden_on_the_help_center, @@ -443,13 +450,16 @@ private fun AboutSettings( label = stringResource(id = R.string.about), ) BitwardenWideSwitch( - modifier = modifier, + modifier = modifier + .semantics { testTag = "SubmitCrashLogs" }, label = stringResource(id = R.string.submit_crash_logs), isChecked = state.isSubmitCrashLogsEnabled, onCheckedChange = onSubmitCrashLogsCheckedChange, ) BitwardenExternalLinkRow( text = stringResource(id = R.string.privacy_policy), + modifier = modifier + .semantics { testTag = "PrivacyPolicy" }, onConfirmClick = onPrivacyPolicyClick, dialogTitle = stringResource(id = R.string.continue_to_privacy_policy), dialogMessage = stringResource(