github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-31 17:56:51 -05:00
Code Issues 1.8k Packages Projects Releases 126 Wiki Activity

Disable login button when password is blank (#441)

Browse Source
This commit is contained in:
Caleb Derosier
2023-12-28 10:49:15 -06:00
committed by GitHub
parent 1323a75f22
commit 95c0acdd3f
2 changed files with 50 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModelTest.kt
View File

@@ -343,17 +343,49 @@ class LoginViewModelTest : BaseViewModelTest() {
}
@Test
fun `PasswordInputChanged should update password input`() = runTest {
val input = "input"
val viewModel = createViewModel()
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(LoginAction.PasswordInputChanged(input))
assertEquals(
DEFAULT_STATE.copy(passwordInput = input),
viewModel.stateFlow.value,
)
fun `PasswordInputChanged should update input and enable button if password is not blank`() =
runTest {
val input = "input"
val viewModel = createViewModel()
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(LoginAction.PasswordInputChanged(input))
assertEquals(
DEFAULT_STATE.copy(
passwordInput = input,
isLoginButtonEnabled = true,
),
viewModel.stateFlow.value,
)
}
}
@Test
fun `PasswordInputChanged should update input and disable button if password is blank`() =
runTest {
val input = "input"
val viewModel = createViewModel()
viewModel.eventFlow.test {
// set isLoginButtonEnabled to true
viewModel.actionChannel.trySend(LoginAction.PasswordInputChanged(input))
assertEquals(
DEFAULT_STATE.copy(
passwordInput = input,
isLoginButtonEnabled = true,
),
viewModel.stateFlow.value,
)
// set isLoginButtonEnabled to false
viewModel.actionChannel.trySend(LoginAction.PasswordInputChanged(""))
assertEquals(
DEFAULT_STATE.copy(
passwordInput = "",
isLoginButtonEnabled = false,
),
viewModel.stateFlow.value,
)
}
}
}
@Test
fun `captchaTokenFlow success update should trigger a login`() = runTest {
@@ -383,7 +415,7 @@ class LoginViewModelTest : BaseViewModelTest() {
private val DEFAULT_STATE = LoginState(
emailAddress = "test@gmail.com",
passwordInput = "",
isLoginButtonEnabled = true,
isLoginButtonEnabled = false,
environmentLabel = Environment.Us.label,
loadingDialogState = LoadingDialogState.Hidden,
errorDialogState = BasicDialogState.Hidden,