From 8f3f87a33380a306ed9422169cca81f3d14759f2 Mon Sep 17 00:00:00 2001 From: Caleb Derosier <125901828+caleb-livefront@users.noreply.github.com> Date: Thu, 4 Apr 2024 16:07:49 -0600 Subject: [PATCH] BIT-2207: Remove Rate the App row (#1228) Co-authored-by: David Perez --- .../feature/settings/about/AboutScreen.kt | 6 ------ .../feature/settings/about/AboutScreenTest.kt | 16 ---------------- 2 files changed, 22 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt index 35b3895a39..e63dbabae5 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt @@ -210,12 +210,6 @@ private fun ContentColumn( id = R.string.learn_about_organizations_description_long, ), ) - BitwardenExternalLinkRow( - text = stringResource(id = R.string.rate_the_app), - onConfirmClick = onRateTheAppClick, - dialogTitle = stringResource(id = R.string.continue_to_app_store), - dialogMessage = stringResource(id = R.string.rate_app_description_long), - ) BitwardenExternalLinkRow( text = stringResource(R.string.give_feedback), onConfirmClick = onGiveFeedbackClick, diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreenTest.kt b/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreenTest.kt index 74eaba680b..359e8b252e 100644 --- a/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreenTest.kt +++ b/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreenTest.kt @@ -201,22 +201,6 @@ class AboutScreenTest : BaseComposeTest() { } } - @Suppress("MaxLineLength") - @Test - fun `on rate the app click should display confirmation dialog and confirm click should emit RateAppClick`() { - composeTestRule.onNode(isDialog()).assertDoesNotExist() - composeTestRule.onNodeWithText("Rate the app").performClick() - composeTestRule.onNode(isDialog()).assertExists() - composeTestRule - .onAllNodesWithText("Continue") - .filterToOne(hasAnyAncestor(isDialog())) - .performClick() - composeTestRule.onNode(isDialog()).assertDoesNotExist() - verify { - viewModel.trySendAction(AboutAction.RateAppClick) - } - } - @Test fun `submit crash logs switch should be displayed according to state`() { mutableStateFlow.update { it.copy(shouldShowCrashLogsButton = true) }