BIT-1897-vault-appearing-when-policy-set (#1064)

This commit is contained in:
Ramsey Smith
2024-06-20 17:08:07 +01:00
committed by Álison Fernandes
parent c154da6f46
commit 85faf29c7b
5 changed files with 141 additions and 13 deletions
@@ -122,6 +122,21 @@ class VaultScreenTest : BaseComposeTest() {
composeTestRule.onNodeWithText("Vault: My vault").assertDoesNotExist()
composeTestRule.onNodeWithText("Vault: Test Organization").assertDoesNotExist()
mutableStateFlow.update {
it.copy(
vaultFilterData = VAULT_FILTER_DATA.copy(
vaultFilterTypes = listOf(
VaultFilterType.AllVaults,
ORGANIZATION_VAULT_FILTER,
),
),
)
}
composeTestRule.onNodeWithText("Vault: All").assertDoesNotExist()
composeTestRule.onNodeWithText("Vault: My vault").assertDoesNotExist()
composeTestRule.onNodeWithText("Vault: Test Organization").assertDoesNotExist()
mutableStateFlow.update {
it.copy(
vaultFilterData = VAULT_FILTER_DATA.copy(
@@ -0,0 +1,87 @@
package com.x8bit.bitwarden.ui.vault.feature.vault.util
import com.x8bit.bitwarden.ui.platform.base.util.asText
import com.x8bit.bitwarden.ui.vault.feature.vault.VaultState
import com.x8bit.bitwarden.ui.vault.feature.vault.model.VaultFilterData
import com.x8bit.bitwarden.ui.vault.feature.vault.model.VaultFilterType
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Test
class VaultStateExtensionsTest {
@Test
fun `vaultFilterDataIfRequired with my vault should return correct data`() {
val vaultFilterData = createVaultFilterData(hasMyVault = true)
mapOf(
VaultState.ViewState.NoItems to vaultFilterData,
VaultState.ViewState.Loading to null,
VaultState.ViewState.Error(message = "error".asText()) to null,
createContentState() to vaultFilterData,
)
.forEach { (viewState, expected) ->
assertEquals(
expected,
viewState.vaultFilterDataIfRequired(vaultFilterData = vaultFilterData),
)
}
}
@Test
fun `vaultFilterDataIfRequired without my vault should return correct data`() {
val vaultFilterData = createVaultFilterData(hasMyVault = false)
mapOf<VaultState.ViewState, VaultFilterData?>(
VaultState.ViewState.NoItems to null,
VaultState.ViewState.Loading to null,
VaultState.ViewState.Error(message = "error".asText()) to null,
createContentState() to null,
)
.forEach { (viewState, expected) ->
assertEquals(
expected,
viewState.vaultFilterDataIfRequired(vaultFilterData = vaultFilterData),
)
}
}
private fun createVaultFilterData(hasMyVault: Boolean = false): VaultFilterData =
VaultFilterData(
selectedVaultFilterType = VaultFilterType.AllVaults,
vaultFilterTypes = listOfNotNull(
VaultFilterType.AllVaults,
if (hasMyVault) {
VaultFilterType.MyVault
} else {
null
},
VaultFilterType.OrganizationVault(
organizationId = "organizationId-A",
organizationName = "Organization A",
),
),
)
private fun createContentState(): VaultState.ViewState.Content =
VaultState.ViewState.Content(
loginItemsCount = 1,
cardItemsCount = 0,
identityItemsCount = 0,
secureNoteItemsCount = 0,
favoriteItems = listOf(),
folderItems = listOf(
VaultState.ViewState.FolderItem(
id = "mockId-1",
name = "mockName-1".asText(),
itemCount = 1,
),
),
collectionItems = listOf(
VaultState.ViewState.CollectionItem(
id = "mockId-1",
name = "mockName-1",
itemCount = 1,
),
),
noFolderItems = listOf(),
trashItemsCount = 0,
totpItemsCount = 1,
)
}