diff --git a/app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTimePickerDialog.kt b/app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTimePickerDialog.kt index ab642c8a2a..c8207d0b96 100644 --- a/app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTimePickerDialog.kt +++ b/app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTimePickerDialog.kt @@ -81,10 +81,7 @@ fun BitwardenTimePickerDialog( inputToggleButton = { BitwardenStandardIconButton( vectorIconRes = R.drawable.ic_keyboard, - contentDescription = stringResource( - // TODO: Get our own string for this (BIT-1405) - id = androidx.compose.material3.R.string.m3c_date_picker_switch_to_input_mode, - ), + contentDescription = stringResource(id = R.string.switch_input_mode), onClick = { showTimeInput = !showTimeInput }, ) }, @@ -161,8 +158,7 @@ private fun TimePickerDialog( .testTag("AlertTitleText") .fillMaxWidth() .padding(bottom = 20.dp), - // TODO: This should be "Select time" but we don't have that string (BIT-1405) - text = stringResource(id = R.string.time), + text = stringResource(id = R.string.select_time), color = BitwardenTheme.colorScheme.text.secondary, style = BitwardenTheme.typography.labelMedium, ) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 7f7bbe47a6..dc416abb5b 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -547,6 +547,8 @@ select Add TOTP to store the key safely Device type IP address Time + Select time + Switch input mode Confirm login Deny login Login denied diff --git a/app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt b/app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt index 9b15ed350c..746bdcd144 100644 --- a/app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt +++ b/app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt @@ -927,7 +927,7 @@ class AccountSecurityScreenTest : BitwardenComposeTest() { .performClick() composeTestRule - .onAllNodesWithText("Time") + .onAllNodesWithText(text = "Select time") .filterToOne(hasAnyAncestor(isDialog())) .assertIsDisplayed() composeTestRule