BIT-1078: Save login items (Networking) (#272)

app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/serializer/LocalDateTimeSerializerTest.kt

@@ -69,7 +69,7 @@ class LocalDateTimeSerializerTest {
             json.parseToJsonElement(
                 """
                 {
-                  "dataAsLocalDateTime": "2023-10-06T17:22:28.4400000Z"
+                  "dataAsLocalDateTime": "2023-10-06T17:22:28.440Z"
                 }
                 """,
             ),

app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/network/model/CipherJsonRequestUtil.kt

@@ -0,0 +1,25 @@
+package com.x8bit.bitwarden.data.vault.datasource.network.model
+
+import CipherJsonRequest
+import java.time.LocalDateTime
+
+/**
+ * Create a mock [CipherJsonRequest] with a given [number].
+ */
+fun createMockCipherJsonRequest(number: Int): CipherJsonRequest =
+    CipherJsonRequest(
+        organizationId = "mockOrganizationId-$number",
+        folderId = "mockFolderId-$number",
+        name = "mockName-$number",
+        notes = "mockNotes-$number",
+        type = CipherTypeJson.LOGIN,
+        login = createMockLogin(number = number),
+        card = createMockCard(number = number),
+        fields = listOf(createMockField(number = number)),
+        identity = createMockIdentity(number = number),
+        isFavorite = false,
+        passwordHistory = listOf(createMockPasswordHistory(number = number)),
+        reprompt = CipherRepromptTypeJson.NONE,
+        secureNote = createMockSecureNote(),
+        lastKnownRevisionDate = LocalDateTime.parse("2023-10-27T12:00:00"),
+    )

app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/network/service/CiphersServiceTest.kt

@@ -0,0 +1,123 @@
+package com.x8bit.bitwarden.data.vault.datasource.network.service
+
+import com.x8bit.bitwarden.data.platform.base.BaseServiceTest
+import com.x8bit.bitwarden.data.vault.datasource.network.api.CiphersApi
+import com.x8bit.bitwarden.data.vault.datasource.network.model.createMockCipher
+import com.x8bit.bitwarden.data.vault.datasource.network.model.createMockCipherJsonRequest
+import kotlinx.coroutines.test.runTest
+import okhttp3.mockwebserver.MockResponse
+import org.junit.Test
+import org.junit.jupiter.api.Assertions.assertEquals
+import retrofit2.create
+
+class CiphersServiceTest : BaseServiceTest() {
+    private val ciphersApi: CiphersApi = retrofit.create()
+
+    private val ciphersService: CiphersService = CiphersServiceImpl(
+        ciphersApi = ciphersApi,
+    )
+
+    @Test
+    fun `createCipher should return the correct response`() = runTest {
+        server.enqueue(MockResponse().setBody(CREATE_CIPHER_SUCCESS_JSON))
+        val result = ciphersService.createCipher(
+            body = createMockCipherJsonRequest(number = 1),
+        )
+        assertEquals(
+            createMockCipher(number = 1),
+            result.getOrThrow(),
+        )
+    }
+}
+
+private const val CREATE_CIPHER_SUCCESS_JSON = """
+{
+  "notes": "mockNotes-1",
+  "attachments": [
+    {
+      "fileName": "mockFileName-1",
+      "size": 1,
+      "sizeName": "mockSizeName-1",
+      "id": "mockId-1",
+      "url": "mockUrl-1",
+      "key": "mockKey-1"
+    }
+  ],
+  "organizationUseTotp": false,
+  "reprompt": 0,
+  "edit": false,
+  "passwordHistory": [
+    {
+      "password": "mockPassword-1",
+      "lastUsedDate": "2023-10-27T12:00:00.00Z"
+    }
+  ],
+  "revisionDate": "2023-10-27T12:00:00.00Z",
+  "type": 1,
+  "login": {
+    "uris": [
+      {
+        "match": 1,
+        "uri": "mockUri-1"
+      }
+    ],
+    "totp": "mockTotp-1",
+    "password": "mockPassword-1",
+    "passwordRevisionDate": "2023-10-27T12:00:00.00Z",
+    "autofillOnPageLoad": false,
+    "uri": "mockUri-1",
+    "username": "mockUsername-1"
+  },
+  "creationDate": "2023-10-27T12:00:00.00Z",
+  "secureNote": {
+    "type": 0
+  },
+  "folderId": "mockFolderId-1",
+  "organizationId": "mockOrganizationId-1",
+  "deletedDate": "2023-10-27T12:00:00.00Z",
+  "identity": {
+    "passportNumber": "mockPassportNumber-1",
+    "lastName": "mockLastName-1",
+    "address3": "mockAddress3-1",
+    "address2": "mockAddress2-1",
+    "city": "mockCity-1",
+    "country": "mockCountry-1",
+    "address1": "mockAddress1-1",
+    "postalCode": "mockPostalCode-1",
+    "title": "mockTitle-1",
+    "ssn": "mockSsn-1",
+    "firstName": "mockFirstName-1",
+    "phone": "mockPhone-1",
+    "middleName": "mockMiddleName-1",
+    "company": "mockCompany-1",
+    "licenseNumber": "mockLicenseNumber-1",
+    "state": "mockState-1",
+    "email": "mockEmail-1",
+    "username": "mockUsername-1"
+  },
+  "collectionIds": [
+    "mockCollectionId-1"
+  ],
+  "name": "mockName-1",
+  "id": "mockId-1"
+  "fields": [
+    {
+      "linkedId": 100,
+      "name": "mockName-1",
+      "type": 1,
+      "value": "mockValue-1"
+    }
+  ],
+  "viewPassword": false,
+  "favorite": false,
+  "card": {
+    "number": "mockNumber-1",
+    "expMonth": "mockExpMonth-1",
+    "code": "mockCode-1",
+    "expYear": "mockExpirationYear-1",
+    "cardholderName": "mockCardholderName-1",
+    "brand": "mockBrand-1"
+  },
+  "key": "mockKey-1"
+}
+"""

app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt

@@ -54,4 +54,34 @@ class VaultDataExtensionsTest {
             actual,
         )
     }
+
+    @Test
+    fun `toViewState should not transform ciphers with no ID into ViewState items`() {
+        val vaultData = VaultData(
+            cipherViewList = listOf(createMockCipherView(number = 1).copy(id = null)),
+            folderViewList = listOf(createMockFolderView(number = 1)),
+        )
+
+        val actual = vaultData.toViewState()
+
+        assertEquals(
+            VaultState.ViewState.Content(
+                loginItemsCount = 0,
+                cardItemsCount = 0,
+                identityItemsCount = 0,
+                secureNoteItemsCount = 0,
+                favoriteItems = emptyList(),
+                folderItems = listOf(
+                    VaultState.ViewState.FolderItem(
+                        id = "mockId-1",
+                        name = "mockName-1".asText(),
+                        itemCount = 0,
+                    ),
+                ),
+                noFolderItems = emptyList(),
+                trashItemsCount = 0,
+            ),
+            actual,
+        )
+    }
 }