From 727b0c0efc8da3c8aaac69ba54254be10f8a8f89 Mon Sep 17 00:00:00 2001
From: Ramsey Smith <142836716+ramsey-livefront@users.noreply.github.com>
Date: Wed, 13 Dec 2023 09:47:54 -0700
Subject: [PATCH] Rename unit tests for VaultScreenTest and VaultViewModelTest
 (#385)

---
 .../ui/vault/feature/vault/VaultScreenTest.kt | 18 +++--
 .../vault/feature/vault/VaultViewModelTest.kt | 72 ++++++++++---------
 2 files changed, 50 insertions(+), 40 deletions(-)

diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt b/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt
index cbbc6ea338..f6843d790c 100644
--- a/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt
+++ b/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt
@@ -215,37 +215,43 @@ class VaultScreenTest : BaseComposeTest() {
     }
 
     @Test
-    fun `NavigateNavigateToCardGroup event should call onNavigateToVaultItemListingType`() {
+    @Suppress("MaxLineLength")
+    fun `NavigateToItemListing event for Card type should call onNavigateToVaultItemListingType with Card type`() {
         mutableEventFlow.tryEmit(VaultEvent.NavigateToItemListing(VaultItemListingType.Card))
         assertEquals(VaultItemListingType.Card, onNavigateToVaultItemListingType)
     }
 
     @Test
-    fun `NavigateToIdentityGroup event should call onNavigateToVaultItemListingType`() {
+    @Suppress("MaxLineLength")
+    fun `NavigateToItemListing event for Identity type should call onNavigateToVaultItemListingType with Identity type`() {
         mutableEventFlow.tryEmit(VaultEvent.NavigateToItemListing(VaultItemListingType.Identity))
         assertEquals(VaultItemListingType.Identity, onNavigateToVaultItemListingType)
     }
 
     @Test
-    fun `NavigateToLoginGroup event should call onNavigateToVaultItemListingType`() {
+    @Suppress("MaxLineLength")
+    fun `NavigateToItemListing event for Login type should call onNavigateToVaultItemListingType with Login type`() {
         mutableEventFlow.tryEmit(VaultEvent.NavigateToItemListing(VaultItemListingType.Login))
         assertEquals(VaultItemListingType.Login, onNavigateToVaultItemListingType)
     }
 
     @Test
-    fun `NavigateToSecureNotesGroup event should call onNavigateToVaultItemListingType`() {
+    @Suppress("MaxLineLength")
+    fun `NavigateToItemListing event for SecureNote type should call onNavigateToVaultItemListingType with SecureNote type`() {
         mutableEventFlow.tryEmit(VaultEvent.NavigateToItemListing(VaultItemListingType.SecureNote))
         assertEquals(VaultItemListingType.SecureNote, onNavigateToVaultItemListingType)
     }
 
     @Test
-    fun `NavigateToTrash event should call onNavigateToVaultItemListingType`() {
+    @Suppress("MaxLineLength")
+    fun `NavigateToItemListing event for Trash type should call onNavigateToVaultItemListingType with Trash type`() {
         mutableEventFlow.tryEmit(VaultEvent.NavigateToItemListing(VaultItemListingType.Trash))
         assertEquals(VaultItemListingType.Trash, onNavigateToVaultItemListingType)
     }
 
     @Test
-    fun `NavigateToFolder event should call onNavigateToVaultItemListingType`() {
+    @Suppress("MaxLineLength")
+    fun `NavigateToItemListing event for Folder type should call onNavigateToVaultItemListingType with Folder type`() {
         val mockFolderId = "mockFolderId"
         mutableEventFlow.tryEmit(
             VaultEvent.NavigateToItemListing(VaultItemListingType.Folder(mockFolderId)),
diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt b/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt
index 2c9928ee4d..51bb44e64d 100644
--- a/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt
+++ b/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt
@@ -408,7 +408,7 @@ class VaultViewModelTest : BaseViewModelTest() {
     }
 
     @Test
-    fun `CardGroupClick should emit NavigateToCardGroup`() = runTest {
+    fun `CardGroupClick should emit NavigateToItemListing event with Card type`() = runTest {
         val viewModel = createViewModel()
         viewModel.eventFlow.test {
             viewModel.trySendAction(VaultAction.CardGroupClick)
@@ -420,35 +420,38 @@ class VaultViewModelTest : BaseViewModelTest() {
     }
 
     @Test
-    fun `FolderClick should emit NavigateToFolder with correct folder ID`() = runTest {
-        val viewModel = createViewModel()
-        val folderId = "12345"
-        val folder = mockk<VaultState.ViewState.FolderItem> {
-            every { id } returns folderId
+    @Suppress("MaxLineLength")
+    fun `FolderClick should emit NavigateToItemListing event for Folder type with correct folder ID`() =
+        runTest {
+            val viewModel = createViewModel()
+            val folderId = "12345"
+            val folder = mockk<VaultState.ViewState.FolderItem> {
+                every { id } returns folderId
+            }
+            viewModel.eventFlow.test {
+                viewModel.trySendAction(VaultAction.FolderClick(folder))
+                assertEquals(
+                    VaultEvent.NavigateToItemListing(VaultItemListingType.Folder(folderId)),
+                    awaitItem(),
+                )
+            }
         }
-        viewModel.eventFlow.test {
-            viewModel.trySendAction(VaultAction.FolderClick(folder))
-            assertEquals(
-                VaultEvent.NavigateToItemListing(VaultItemListingType.Folder(folderId)),
-                awaitItem(),
-            )
-        }
-    }
 
     @Test
-    fun `IdentityGroupClick should emit NavigateToIdentityGroup`() = runTest {
-        val viewModel = createViewModel()
-        viewModel.eventFlow.test {
-            viewModel.trySendAction(VaultAction.IdentityGroupClick)
-            assertEquals(
-                VaultEvent.NavigateToItemListing(VaultItemListingType.Identity),
-                awaitItem(),
-            )
+    fun `IdentityGroupClick should emit NavigateToItemListing event with Identity type`() =
+        runTest {
+            val viewModel = createViewModel()
+            viewModel.eventFlow.test {
+                viewModel.trySendAction(VaultAction.IdentityGroupClick)
+                assertEquals(
+                    VaultEvent.NavigateToItemListing(VaultItemListingType.Identity),
+                    awaitItem(),
+                )
+            }
         }
-    }
 
     @Test
-    fun `LoginGroupClick should emit NavigateToLoginGroup`() = runTest {
+    fun `LoginGroupClick should emit NavigateToItemListing event with Login type`() = runTest {
         val viewModel = createViewModel()
         viewModel.eventFlow.test {
             viewModel.trySendAction(VaultAction.LoginGroupClick)
@@ -469,19 +472,20 @@ class VaultViewModelTest : BaseViewModelTest() {
     }
 
     @Test
-    fun `SecureNoteGroupClick should emit NavigateToSecureNotesGroup`() = runTest {
-        val viewModel = createViewModel()
-        viewModel.eventFlow.test {
-            viewModel.trySendAction(VaultAction.SecureNoteGroupClick)
-            assertEquals(
-                VaultEvent.NavigateToItemListing(VaultItemListingType.SecureNote),
-                awaitItem(),
-            )
+    fun `SecureNoteGroupClick should emit NavigateToItemListing event with SecureNote type`() =
+        runTest {
+            val viewModel = createViewModel()
+            viewModel.eventFlow.test {
+                viewModel.trySendAction(VaultAction.SecureNoteGroupClick)
+                assertEquals(
+                    VaultEvent.NavigateToItemListing(VaultItemListingType.SecureNote),
+                    awaitItem(),
+                )
+            }
         }
-    }
 
     @Test
-    fun `TrashClick should emit NavigateToTrash`() = runTest {
+    fun `TrashClick should emit NavigateToItemListing event with Trash type`() = runTest {
         val viewModel = createViewModel()
         viewModel.eventFlow.test {
             viewModel.trySendAction(VaultAction.TrashClick)