From 5a4b8d64abcd928c392930f2cd706c0c0b26db76 Mon Sep 17 00:00:00 2001 From: Dave Severns <149429124+dseverns-livefront@users.noreply.github.com> Date: Mon, 4 Nov 2024 20:23:36 -0500 Subject: [PATCH] PM-14433 update flow type to nullable so we can handle gracefully and avoid crash. (#4231) --- .../bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt | 2 ++ .../bitwarden/data/vault/datasource/disk/dao/DomainsDao.kt | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt b/app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt index 60c42afbd4..544ac6b3e8 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt @@ -17,6 +17,7 @@ import kotlinx.coroutines.async import kotlinx.coroutines.awaitAll import kotlinx.coroutines.coroutineScope import kotlinx.coroutines.flow.Flow +import kotlinx.coroutines.flow.filterNotNull import kotlinx.coroutines.flow.first import kotlinx.coroutines.flow.map import kotlinx.coroutines.flow.merge @@ -122,6 +123,7 @@ class VaultDiskSourceImpl( override fun getDomains(userId: String): Flow = domainsDao .getDomains(userId) + .filterNotNull() .map { entity -> withContext(dispatcherManager.default) { json.decodeFromString(entity.domainsJson) diff --git a/app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/dao/DomainsDao.kt b/app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/dao/DomainsDao.kt index a5977cb26b..bec92cd0dd 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/dao/DomainsDao.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/dao/DomainsDao.kt @@ -25,7 +25,7 @@ interface DomainsDao { @Query("SELECT * FROM domains WHERE user_id = :userId") fun getDomains( userId: String, - ): Flow + ): Flow /** * Inserts domains into the database.