From 472e41f6bc138e1b95bc862ca2cac60b714e1c3f Mon Sep 17 00:00:00 2001 From: David Perez Date: Thu, 8 May 2025 13:52:24 -0500 Subject: [PATCH] PM-21351: Hide new send button from accessibility when on the empty sends screen (#5160) --- .../com/x8bit/bitwarden/ui/tools/feature/send/SendEmpty.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendEmpty.kt b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendEmpty.kt index 6a7d210c11..34a6aaf888 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendEmpty.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendEmpty.kt @@ -17,6 +17,8 @@ import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.platform.testTag import androidx.compose.ui.res.stringResource +import androidx.compose.ui.semantics.hideFromAccessibility +import androidx.compose.ui.semantics.semantics import androidx.compose.ui.text.style.TextAlign import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.unit.dp @@ -84,11 +86,14 @@ fun SendEmpty( Spacer(modifier = Modifier.height(24.dp)) + // This button is hidden from accessibility to avoid duplicate voice over with the FAB BitwardenFilledButton( onClick = onAddItemClick, label = stringResource(id = R.string.add_a_send), - modifier = Modifier.standardHorizontalMargin(), icon = rememberVectorPainter(R.drawable.ic_plus_small), + modifier = Modifier + .semantics { hideFromAccessibility() } + .standardHorizontalMargin(), ) Spacer(modifier = Modifier.weight(1F)) Spacer(modifier = Modifier.navigationBarsPadding())