github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-10 11:51:05 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

Remove various unnecessary TODOs (#956)

Browse Source
This commit is contained in:
Brian Yencho
2024-02-05 16:06:54 -06:00
committed by Álison Fernandes
parent 61212c3628
commit 300190a520
5 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/GetTokenResponseExtensions.kt
View File

@@ -23,7 +23,6 @@ fun GetTokenResponseJson.Success.toUserState(
val jwtTokenData = parseJwtTokenDataOrNull(jwtToken = accessToken)!! val jwtTokenData = parseJwtTokenDataOrNull(jwtToken = accessToken)!!
val userId = jwtTokenData.userId val userId = jwtTokenData.userId
// TODO: Update null properties below via sync request (BIT-916)
val account = AccountJson( val account = AccountJson(
profile = AccountJson.Profile( profile = AccountJson.Profile(
userId = userId, userId = userId,

1
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensions.kt
View File

@@ -23,7 +23,6 @@ fun UserStateJson.toUpdatedUserStateJson(
val userId = syncProfile.id val userId = syncProfile.id
val account = this.accounts[userId] ?: return this val account = this.accounts[userId] ?: return this
val profile = account.profile val profile = account.profile
// TODO: Update additional missing UserStateJson properties (BIT-916)
val updatedProfile = profile val updatedProfile = profile
.copy( .copy(
avatarColorHex = syncProfile.avatarColor, avatarColorHex = syncProfile.avatarColor,

2
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt
View File

@@ -129,7 +129,7 @@ class CreateAccountViewModel @Inject constructor(
} }
PasswordStrengthResult.Error -> { PasswordStrengthResult.Error -> {
// TODO: Assess possible error conditions (BIT-964) // Leave UI the same
} }
} }
} }

3
app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModel.kt
View File

@@ -122,9 +122,6 @@ class AddSendViewModel @Inject constructor(
) { ) {
init { init {
// TODO: Check the special circumstance to place in custom mode when a new send request is
// initiated externally (BIT-1518).
when (val addSendType = state.addSendType) { when (val addSendType = state.addSendType) {
AddSendType.AddItem -> Unit AddSendType.AddItem -> Unit
is AddSendType.EditItem -> { is AddSendType.EditItem -> {

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt
View File

@@ -536,7 +536,6 @@ class VaultViewModel @Inject constructor(
} }
private fun vaultPendingReceive(vaultData: DataState.Pending<VaultData>) { private fun vaultPendingReceive(vaultData: DataState.Pending<VaultData>) {
// TODO update state to refresh state BIT-505
mutableStateFlow.update { mutableStateFlow.update {
it.copy( it.copy(
viewState = vaultData.data.toViewState( viewState = vaultData.data.toViewState(