From 2eaeeb4d4e2aef295be72399ef1e6fd572598a80 Mon Sep 17 00:00:00 2001 From: Oleg Semenenko <146032743+oleg-livefront@users.noreply.github.com> Date: Wed, 7 Feb 2024 16:17:13 -0600 Subject: [PATCH] BIT-1577 Add the options element ID (#980) --- .../ui/platform/components/BitwardenOverflowActionItem.kt | 2 ++ .../bitwarden/ui/tools/feature/generator/GeneratorScreen.kt | 1 - .../feature/generator/passwordhistory/PasswordHistoryScreen.kt | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/platform/components/BitwardenOverflowActionItem.kt b/app/src/main/java/com/x8bit/bitwarden/ui/platform/components/BitwardenOverflowActionItem.kt index 9fb2cd54de..fe438977b7 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/platform/components/BitwardenOverflowActionItem.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/platform/components/BitwardenOverflowActionItem.kt @@ -40,12 +40,14 @@ import kotlinx.collections.immutable.persistentListOf */ @Composable fun BitwardenOverflowActionItem( + modifier: Modifier = Modifier, menuItemDataList: ImmutableList = persistentListOf(), ) { if (menuItemDataList.isEmpty()) return var isOverflowMenuVisible by remember { mutableStateOf(false) } Box( contentAlignment = Alignment.Center, + modifier = modifier, ) { IconButton(onClick = { isOverflowMenuVisible = !isOverflowMenuVisible }) { Icon( diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt index d1e86f4418..c753b4add2 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt @@ -255,7 +255,6 @@ private fun DefaultAppBar( OverflowMenuItemData( text = stringResource(id = R.string.password_history), onClick = onPasswordHistoryClick, - testTag = "Options", ), ), ) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryScreen.kt index a9cc914448..0a91b9675e 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryScreen.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryScreen.kt @@ -94,6 +94,7 @@ fun PasswordHistoryScreen( }, ), ), + modifier = Modifier.semantics { testTag = "Options" }, ) } },