BIT-2403: Update process for moving item to organization (#1421)

This commit is contained in:
David Perez
2024-06-20 17:08:07 +01:00
committed by Álison Fernandes
parent 51d65f602d
commit 1dcfad4451
8 changed files with 71 additions and 7 deletions
@@ -24,6 +24,7 @@ import com.bitwarden.crypto.TrustDeviceResponse
import com.bitwarden.sdk.BitwardenException
import com.bitwarden.sdk.Client
import com.bitwarden.sdk.ClientAuth
import com.bitwarden.sdk.ClientCiphers
import com.bitwarden.sdk.ClientCrypto
import com.bitwarden.sdk.ClientExporters
import com.bitwarden.sdk.ClientPasswordHistory
@@ -849,6 +850,29 @@ class VaultSdkSourceTest {
coVerify { sdkClientManager.getOrCreateClient(userId = userId) }
}
@Test
fun `moveToOrganization should call SDK and a Result with correct data`() = runTest {
val userId = "userId"
val organizationId = "organizationId"
val mockCipher = mockk<CipherView>()
val expectedResult = mockk<Cipher>()
val clientCipher = mockk<ClientCiphers> {
coEvery {
moveToOrganization(cipher = mockCipher, organizationId = organizationId)
} returns mockCipher
coEvery { encrypt(cipherView = mockCipher) } returns expectedResult
}
every { clientVault.ciphers() } returns clientCipher
val result = vaultSdkSource.moveToOrganization(
userId = userId,
organizationId = organizationId,
cipherView = mockCipher,
)
assertEquals(expectedResult.asSuccess(), result)
}
@Test
fun `validatePassword should call SDK and a Result with correct data`() = runTest {
val userId = "userId"
@@ -3094,6 +3094,7 @@ class VaultRepositoryTest {
val result = vaultRepository.shareCipher(
cipherId = "cipherId",
organizationId = "organizationId",
cipherView = mockk(),
collectionIds = emptyList(),
)
@@ -3110,9 +3111,11 @@ class VaultRepositoryTest {
runTest {
fakeAuthDiskSource.userState = MOCK_USER_STATE
val userId = "mockId-1"
val organizationId = "organizationId"
coEvery {
vaultSdkSource.encryptCipher(
vaultSdkSource.moveToOrganization(
userId = userId,
organizationId = organizationId,
cipherView = createMockCipherView(number = 1),
)
} returns createMockSdkCipher(number = 1, clock = clock).asSuccess()
@@ -3135,6 +3138,7 @@ class VaultRepositoryTest {
val result = vaultRepository.shareCipher(
cipherId = "mockId-1",
organizationId = organizationId,
cipherView = createMockCipherView(number = 1),
collectionIds = listOf("mockId-1"),
)
@@ -3151,9 +3155,11 @@ class VaultRepositoryTest {
runTest {
fakeAuthDiskSource.userState = MOCK_USER_STATE
val userId = "mockId-1"
val organizationId = "organizationId"
coEvery {
vaultSdkSource.encryptCipher(
vaultSdkSource.moveToOrganization(
userId = userId,
organizationId = organizationId,
cipherView = createMockCipherView(number = 1),
)
} returns createMockSdkCipher(number = 1, clock = clock).asSuccess()
@@ -3170,6 +3176,7 @@ class VaultRepositoryTest {
val result = vaultRepository.shareCipher(
cipherId = "mockId-1",
organizationId = organizationId,
cipherView = createMockCipherView(number = 1),
collectionIds = listOf("mockId-1"),
)
@@ -3186,9 +3193,11 @@ class VaultRepositoryTest {
runTest {
fakeAuthDiskSource.userState = MOCK_USER_STATE
val userId = "mockId-1"
val organizationId = "organizationId"
coEvery {
vaultSdkSource.encryptCipher(
vaultSdkSource.moveToOrganization(
userId = userId,
organizationId = organizationId,
cipherView = createMockCipherView(number = 1),
)
} returns Throwable("Fail").asFailure()
@@ -3205,6 +3214,7 @@ class VaultRepositoryTest {
val result = vaultRepository.shareCipher(
cipherId = "mockId-1",
organizationId = organizationId,
cipherView = createMockCipherView(number = 1),
collectionIds = listOf("mockId-1"),
)
@@ -240,6 +240,7 @@ class VaultMoveToOrganizationViewModelTest : BaseViewModelTest() {
coEvery {
vaultRepository.shareCipher(
cipherId = "mockCipherId",
organizationId = "mockOrganizationId-1",
cipherView = createMockCipherView(number = 1),
collectionIds = listOf("mockId-1"),
)
@@ -284,6 +285,7 @@ class VaultMoveToOrganizationViewModelTest : BaseViewModelTest() {
coVerify {
vaultRepository.shareCipher(
cipherId = "mockCipherId",
organizationId = "mockOrganizationId-1",
cipherView = createMockCipherView(number = 1),
collectionIds = listOf("mockId-1"),
)
@@ -298,6 +300,7 @@ class VaultMoveToOrganizationViewModelTest : BaseViewModelTest() {
coEvery {
vaultRepository.shareCipher(
cipherId = "mockCipherId",
organizationId = "mockOrganizationId-1",
cipherView = createMockCipherView(number = 1),
collectionIds = listOf("mockId-1"),
)
@@ -344,6 +347,7 @@ class VaultMoveToOrganizationViewModelTest : BaseViewModelTest() {
coVerify {
vaultRepository.shareCipher(
cipherId = "mockCipherId",
organizationId = "mockOrganizationId-1",
cipherView = createMockCipherView(number = 1),
collectionIds = listOf("mockId-1"),
)
@@ -358,6 +362,7 @@ class VaultMoveToOrganizationViewModelTest : BaseViewModelTest() {
coEvery {
vaultRepository.shareCipher(
cipherId = "mockCipherId",
organizationId = "mockOrganizationId-1",
cipherView = createMockCipherView(number = 1),
collectionIds = listOf("mockId-1"),
)
@@ -381,6 +386,7 @@ class VaultMoveToOrganizationViewModelTest : BaseViewModelTest() {
coVerify {
vaultRepository.shareCipher(
cipherId = "mockCipherId",
organizationId = "mockOrganizationId-1",
cipherView = createMockCipherView(number = 1),
collectionIds = listOf("mockId-1"),
)