github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-31 01:22:39 -05:00
Code Issues 1.8k Packages Projects Releases 126 Wiki Activity

BIT-511: Save identity items (#436)

Browse Source
This commit is contained in:
Ramsey Smith
2023-12-27 14:37:36 -07:00
committed by GitHub
parent f0b0c8a0b4
commit 1ae0b57574
7 changed files with 329 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/additem/VaultAddItemScreenTest.kt
View File

@@ -952,6 +952,39 @@ class VaultAddItemScreenTest : BaseComposeTest() {
}
}
@Test
fun `in ItemType_Identity changing state text field should trigger CityTextChange`() {
mutableStateFlow.value = DEFAULT_STATE_IDENTITY
composeTestRule
.onNodeWithTextAfterScroll(text = "State / Province")
.performTextInput(text = "TestState")
verify {
viewModel.trySendAction(
VaultAddItemAction.ItemType.IdentityType.StateTextChange(
state = "TestState",
),
)
}
}
@Suppress("MaxLineLength")
@Test
fun `in ItemType_Identity the state province text field should display the text provided by the state`() {
mutableStateFlow.value = DEFAULT_STATE_IDENTITY
composeTestRule
.onNodeWithTextAfterScroll(text = "State / Province")
.assertTextContains("")
mutableStateFlow.update { currentState ->
updateIdentityType(currentState) { copy(state = "NewState") }
}
composeTestRule
.onNodeWithTextAfterScroll(text = "State / Province")
.assertTextContains("NewState")
}
@Suppress("MaxLineLength")
@Test
fun `in ItemType_Identity the country text field should display the text provided by the state`() {

15
app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/additem/VaultAddItemViewModelTest.kt
View File

@@ -765,6 +765,21 @@ class VaultAddItemViewModelTest : BaseViewModelTest() {
assertEquals(expectedState, viewModel.stateFlow.value)
}
@Test
fun `StateTextChange should update state text`() = runTest {
val action = VaultAddItemAction.ItemType.IdentityType.StateTextChange(
state = "newState",
)
val expectedState = createVaultAddItemState(
typeContentViewState = VaultAddItemState.ViewState.Content.ItemType.Identity(
state = "newState",
),
)
viewModel.actionChannel.trySend(action)
assertEquals(expectedState, viewModel.stateFlow.value)
}
@Test
fun `ZipTextChange should update zip`() = runTest {
val action = VaultAddItemAction.ItemType.IdentityType.ZipTextChange(

224
app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt
View File

@@ -5,6 +5,7 @@ import com.bitwarden.core.CipherType
import com.bitwarden.core.CipherView
import com.bitwarden.core.FieldType
import com.bitwarden.core.FieldView
import com.bitwarden.core.IdentityView
import com.bitwarden.core.LoginUriView
import com.bitwarden.core.LoginView
import com.bitwarden.core.PasswordHistoryView
@@ -386,6 +387,205 @@ class VaultDataExtensionsTest {
result,
)
}
@Test
fun `toCipherView should transform Identity ItemType to CipherView`() {
mockkStatic(Instant::class)
every { Instant.now() } returns Instant.MIN
val viewState = VaultAddItemState.ViewState.Content(
common = VaultAddItemState.ViewState.Content.Common(
name = "mockName-1",
folderName = "mockFolder-1".asText(),
favorite = false,
masterPasswordReprompt = false,
notes = "mockNotes-1",
ownership = "mockOwnership-1",
),
type = VaultAddItemState.ViewState.Content.ItemType.Identity(
selectedTitle = VaultAddItemState.ViewState.Content.ItemType.Identity.Title.MR,
firstName = "mockFirstName",
lastName = "mockLastName",
middleName = "mockMiddleName",
address1 = "mockAddress1",
address2 = "mockAddress2",
address3 = "mockAddress3",
city = "mockCity",
state = "mockState",
zip = "mockPostalCode",
country = "mockCountry",
company = "mockCompany",
email = "mockEmail",
phone = "mockPhone",
ssn = "mockSsn",
username = "MockUsername",
passportNumber = "mockPassportNumber",
licenseNumber = "mockLicenseNumber",
),
)
val result = viewState.toCipherView()
assertEquals(
CipherView(
id = null,
organizationId = null,
folderId = null,
collectionIds = emptyList(),
key = null,
name = "mockName-1",
notes = "mockNotes-1",
type = CipherType.IDENTITY,
login = null,
identity = IdentityView(
title = "MR",
firstName = "mockFirstName",
lastName = "mockLastName",
middleName = "mockMiddleName",
address1 = "mockAddress1",
address2 = "mockAddress2",
address3 = "mockAddress3",
city = "mockCity",
state = "mockState",
postalCode = "mockPostalCode",
country = "mockCountry",
company = "mockCompany",
email = "mockEmail",
phone = "mockPhone",
ssn = "mockSsn",
username = "MockUsername",
passportNumber = "mockPassportNumber",
licenseNumber = "mockLicenseNumber",
),
card = null,
secureNote = null,
favorite = false,
reprompt = CipherRepromptType.NONE,
organizationUseTotp = false,
edit = true,
viewPassword = true,
localData = null,
attachments = null,
fields = emptyList(),
passwordHistory = null,
creationDate = Instant.MIN,
deletedDate = null,
revisionDate = Instant.MIN,
),
result,
)
}
@Test
fun `toCipherView should transform Identity ItemType to CipherView with original cipher`() {
val cipherView = DEFAULT_IDENTITY_CIPHER_VIEW
val viewState = VaultAddItemState.ViewState.Content(
common = VaultAddItemState.ViewState.Content.Common(
originalCipher = cipherView,
name = "mockName-1",
folderName = "mockFolder-1".asText(),
favorite = true,
masterPasswordReprompt = false,
customFieldData = listOf(
VaultAddItemState.Custom.BooleanField("testId", "TestBoolean", false),
VaultAddItemState.Custom.TextField("testId", "TestText", "TestText"),
VaultAddItemState.Custom.HiddenField("testId", "TestHidden", "TestHidden"),
VaultAddItemState.Custom.LinkedField(
"testId",
"TestLinked",
VaultLinkedFieldType.USERNAME,
),
),
notes = "mockNotes-1",
ownership = "mockOwnership-1",
),
type = VaultAddItemState.ViewState.Content.ItemType.Identity(
selectedTitle = VaultAddItemState.ViewState.Content.ItemType.Identity.Title.MR,
firstName = "mockFirstName",
lastName = "mockLastName",
middleName = "mockMiddleName",
address1 = "mockAddress1",
address2 = "mockAddress2",
address3 = "mockAddress3",
city = "mockCity",
state = "mockState",
zip = "mockPostalCode",
country = "mockCountry",
company = "mockCompany",
email = "mockEmail",
phone = "mockPhone",
ssn = "mockSsn",
username = "MockUsername",
passportNumber = "mockPassportNumber",
licenseNumber = "mockLicenseNumber",
),
)
val result = viewState.toCipherView()
assertEquals(
@Suppress("MaxLineLength")
cipherView.copy(
name = "mockName-1",
notes = "mockNotes-1",
type = CipherType.IDENTITY,
identity = IdentityView(
title = "MR",
firstName = "mockFirstName",
lastName = "mockLastName",
middleName = "mockMiddleName",
address1 = "mockAddress1",
address2 = "mockAddress2",
address3 = "mockAddress3",
city = "mockCity",
state = "mockState",
postalCode = "mockPostalCode",
country = "mockCountry",
company = "mockCompany",
email = "mockEmail",
phone = "mockPhone",
ssn = "mockSsn",
username = "MockUsername",
passportNumber = "mockPassportNumber",
licenseNumber = "mockLicenseNumber",
),
favorite = true,
reprompt = CipherRepromptType.NONE,
fields = listOf(
FieldView(
name = "TestBoolean",
value = "false",
type = FieldType.BOOLEAN,
linkedId = null,
),
FieldView(
name = "TestText",
value = "TestText",
type = FieldType.TEXT,
linkedId = null,
),
FieldView(
name = "TestHidden",
value = "TestHidden",
type = FieldType.HIDDEN,
linkedId = null,
),
FieldView(
name = "TestLinked",
value = null,
type = FieldType.LINKED,
linkedId = VaultLinkedFieldType.USERNAME.id,
),
),
passwordHistory = listOf(
PasswordHistoryView(
password = "old_password",
lastUsedDate = Instant.ofEpochSecond(1_000L),
),
),
),
result,
)
}
}
private val DEFAULT_BASE_CIPHER_VIEW: CipherView = CipherView(
@@ -492,3 +692,27 @@ private val DEFAULT_SECURE_NOTES_CIPHER_VIEW: CipherView = DEFAULT_BASE_CIPHER_V
),
secureNote = SecureNoteView(type = SecureNoteType.GENERIC),
)
private val DEFAULT_IDENTITY_CIPHER_VIEW: CipherView = DEFAULT_BASE_CIPHER_VIEW.copy(
type = CipherType.IDENTITY,
identity = IdentityView(
title = "MR",
firstName = "mockFirstName",
lastName = "mockLastName",
middleName = "mockMiddleName",
address1 = "mockAddress1",
address2 = "mockAddress2",
address3 = "mockAddress3",
city = "mockCity",
state = "mockState",
postalCode = "mockPostalCode",
country = "mockCountry",
company = "mockCompany",
email = "mockEmail",
phone = "mockPhone",
ssn = "mockSsn",
username = "MockUsername",
passportNumber = "mockPassportNumber",
licenseNumber = "mockLicenseNumber",
),
)