mirror of
https://github.com/bitwarden/android.git
synced 2026-11-19 17:40:12 -06:00
BIT-133 Implement happy path login (#52)
This commit is contained in:
committed by
Álison Fernandes
parent
36942ab296
commit
14d01877fe
@@ -2,7 +2,12 @@ package com.x8bit.bitwarden.ui.auth.feature.login
|
||||
|
||||
import androidx.lifecycle.SavedStateHandle
|
||||
import app.cash.turbine.test
|
||||
import com.x8bit.bitwarden.data.auth.datasource.network.model.LoginResult
|
||||
import com.x8bit.bitwarden.data.auth.repository.AuthRepository
|
||||
import com.x8bit.bitwarden.ui.platform.base.BaseViewModelTest
|
||||
import io.mockk.coEvery
|
||||
import io.mockk.coVerify
|
||||
import io.mockk.mockk
|
||||
import kotlinx.coroutines.test.runTest
|
||||
import org.junit.jupiter.api.Assertions.assertEquals
|
||||
import org.junit.jupiter.api.Test
|
||||
@@ -15,7 +20,10 @@ class LoginViewModelTest : BaseViewModelTest() {
|
||||
|
||||
@Test
|
||||
fun `initial state should be correct`() = runTest {
|
||||
val viewModel = LoginViewModel(savedStateHandle)
|
||||
val viewModel = LoginViewModel(
|
||||
authRepository = mockk(),
|
||||
savedStateHandle = savedStateHandle,
|
||||
)
|
||||
viewModel.stateFlow.test {
|
||||
assertEquals(DEFAULT_STATE, awaitItem())
|
||||
}
|
||||
@@ -33,26 +41,56 @@ class LoginViewModelTest : BaseViewModelTest() {
|
||||
"state" to expectedState,
|
||||
),
|
||||
)
|
||||
val viewModel = LoginViewModel(handle)
|
||||
val viewModel = LoginViewModel(
|
||||
authRepository = mockk(),
|
||||
savedStateHandle = handle,
|
||||
)
|
||||
viewModel.stateFlow.test {
|
||||
assertEquals(expectedState, awaitItem())
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `LoginButtonClick should do nothing`() = runTest {
|
||||
fun `LoginButtonClick login returns error should do nothing`() = runTest {
|
||||
// TODO: handle and display errors (BIT-320)
|
||||
val authRepository = mockk<AuthRepository> {
|
||||
coEvery { login(email = "test@gmail.com", password = "") } returns LoginResult.Error
|
||||
}
|
||||
val viewModel = LoginViewModel(
|
||||
authRepository = authRepository,
|
||||
savedStateHandle = savedStateHandle,
|
||||
)
|
||||
viewModel.eventFlow.test {
|
||||
viewModel.actionChannel.trySend(LoginAction.LoginButtonClick)
|
||||
assertEquals(DEFAULT_STATE, viewModel.stateFlow.value)
|
||||
}
|
||||
coVerify {
|
||||
authRepository.login(email = "test@gmail.com", password = "")
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `LoginButtonClick login returns success should do nothing`() = runTest {
|
||||
val authRepository = mockk<AuthRepository> {
|
||||
coEvery { login("test@gmail.com", "") } returns LoginResult.Success
|
||||
}
|
||||
val viewModel = LoginViewModel(
|
||||
authRepository = authRepository,
|
||||
savedStateHandle = savedStateHandle,
|
||||
)
|
||||
viewModel.eventFlow.test {
|
||||
viewModel.actionChannel.trySend(LoginAction.LoginButtonClick)
|
||||
assertEquals(DEFAULT_STATE, viewModel.stateFlow.value)
|
||||
}
|
||||
coVerify {
|
||||
authRepository.login(email = "test@gmail.com", password = "")
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `SingleSignOnClick should do nothing`() = runTest {
|
||||
val viewModel = LoginViewModel(
|
||||
authRepository = mockk(),
|
||||
savedStateHandle = savedStateHandle,
|
||||
)
|
||||
viewModel.eventFlow.test {
|
||||
@@ -64,6 +102,7 @@ class LoginViewModelTest : BaseViewModelTest() {
|
||||
@Test
|
||||
fun `NotYouButtonClick should emit NavigateToLanding`() = runTest {
|
||||
val viewModel = LoginViewModel(
|
||||
authRepository = mockk(),
|
||||
savedStateHandle = savedStateHandle,
|
||||
)
|
||||
viewModel.eventFlow.test {
|
||||
@@ -79,6 +118,7 @@ class LoginViewModelTest : BaseViewModelTest() {
|
||||
fun `PasswordInputChanged should update password input`() = runTest {
|
||||
val input = "input"
|
||||
val viewModel = LoginViewModel(
|
||||
authRepository = mockk(),
|
||||
savedStateHandle = savedStateHandle,
|
||||
)
|
||||
viewModel.eventFlow.test {
|
||||
@@ -94,7 +134,7 @@ class LoginViewModelTest : BaseViewModelTest() {
|
||||
private val DEFAULT_STATE = LoginState(
|
||||
emailAddress = "test@gmail.com",
|
||||
passwordInput = "",
|
||||
isLoginButtonEnabled = false,
|
||||
isLoginButtonEnabled = true,
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
+45
-14
@@ -1,33 +1,64 @@
|
||||
package com.x8bit.bitwarden.ui.platform.feature.rootnav
|
||||
|
||||
import androidx.lifecycle.SavedStateHandle
|
||||
import app.cash.turbine.test
|
||||
import com.x8bit.bitwarden.data.auth.datasource.network.model.AuthState
|
||||
import com.x8bit.bitwarden.data.auth.datasource.network.model.AuthState.Authenticated
|
||||
import com.x8bit.bitwarden.data.auth.datasource.network.model.AuthState.Unauthenticated
|
||||
import com.x8bit.bitwarden.data.auth.repository.AuthRepository
|
||||
import com.x8bit.bitwarden.ui.platform.base.BaseViewModelTest
|
||||
import io.mockk.every
|
||||
import io.mockk.mockk
|
||||
import kotlinx.coroutines.flow.MutableStateFlow
|
||||
import kotlinx.coroutines.test.runTest
|
||||
import org.junit.jupiter.api.Assertions.assertEquals
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
class RootNavViewModelTest : BaseViewModelTest() {
|
||||
|
||||
@Test
|
||||
fun `initial state should be splash`() {
|
||||
val viewModel = RootNavViewModel(SavedStateHandle())
|
||||
assertEquals(viewModel.stateFlow.value, RootNavState.Splash)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `initial state should be the state in savedStateHandle`() {
|
||||
val authRepository = mockk<AuthRepository> {
|
||||
every { this@mockk.authStateFlow } returns MutableStateFlow(mockk<Authenticated>())
|
||||
}
|
||||
val handle = SavedStateHandle(mapOf(("nav_state" to RootNavState.VaultUnlocked)))
|
||||
val viewModel = RootNavViewModel(handle)
|
||||
assertEquals(viewModel.stateFlow.value, RootNavState.VaultUnlocked)
|
||||
val viewModel = RootNavViewModel(
|
||||
authRepository = authRepository,
|
||||
savedStateHandle = handle,
|
||||
)
|
||||
assertEquals(RootNavState.VaultUnlocked, viewModel.stateFlow.value)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `state should move from splash to auth`() = runTest {
|
||||
val viewModel = RootNavViewModel(SavedStateHandle())
|
||||
viewModel.stateFlow.test {
|
||||
assertEquals(awaitItem(), RootNavState.Splash)
|
||||
assertEquals(awaitItem(), RootNavState.Auth)
|
||||
fun `when auth state is Uninitialized nav state should be Splash`() {
|
||||
val viewModel = RootNavViewModel(
|
||||
authRepository = mockk {
|
||||
every { this@mockk.authStateFlow } returns MutableStateFlow(AuthState.Uninitialized)
|
||||
},
|
||||
savedStateHandle = SavedStateHandle(),
|
||||
)
|
||||
assertEquals(RootNavState.Splash, viewModel.stateFlow.value)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `when auth state is Authenticated nav state should be VaultUnlocked`() {
|
||||
val authRepository = mockk<AuthRepository> {
|
||||
every { this@mockk.authStateFlow } returns MutableStateFlow(mockk<Authenticated>())
|
||||
}
|
||||
val viewModel = RootNavViewModel(
|
||||
authRepository = authRepository,
|
||||
savedStateHandle = SavedStateHandle(),
|
||||
)
|
||||
assertEquals(RootNavState.VaultUnlocked, viewModel.stateFlow.value)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `when auth state is Unauthenticated nav state should be Auth`() = runTest {
|
||||
val viewModel = RootNavViewModel(
|
||||
authRepository = mockk {
|
||||
every { this@mockk.authStateFlow } returns MutableStateFlow(Unauthenticated)
|
||||
},
|
||||
savedStateHandle = SavedStateHandle(),
|
||||
)
|
||||
assertEquals(RootNavState.Auth, viewModel.stateFlow.value)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user