From 1198de2a74a8f2aa53ea5290adad1be2a266a026 Mon Sep 17 00:00:00 2001
From: Dave Severns <149429124+dseverns-livefront@users.noreply.github.com>
Date: Thu, 13 Feb 2025 16:07:01 -0500
Subject: [PATCH] PM-17766 add new strings for ssh keys empty item (#4722)
---
.../itemlisting/util/VaultItemListingDataExtensions.kt | 8 +++++++-
app/src/main/res/values/strings.xml | 2 ++
.../util/VaultItemListingDataExtensionsTest.kt | 4 ++--
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt
index 536d20603b..af126b80d0 100644
--- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt
+++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt
@@ -209,7 +209,9 @@ fun VaultData.toViewState(
R.string.no_notes
}
- else -> R.string.no_items
+ VaultItemListingState.ItemListingType.Vault.SshKey -> {
+ R.string.no_ssh_keys
+ }
}
.asText()
}
@@ -245,6 +247,10 @@ fun VaultData.toViewState(
R.string.new_note
}
+ VaultItemListingState.ItemListingType.Vault.SshKey -> {
+ R.string.new_ssh_key
+ }
+
else -> R.string.new_item
}
.asText()
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index dab30c8723..b2577eab26 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -164,8 +164,10 @@
There are no notes in your vault.
New note
New item
+ New SSH key
There are no text Sends in your vault.
There are no file Sends in your vault.
+ There are no SSH keys in your vault.
New text Send
New file Send
No Username
diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt b/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt
index 53e59211f8..33444b617d 100644
--- a/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt
+++ b/app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt
@@ -731,9 +731,9 @@ class VaultItemListingDataExtensionsTest {
// SSH keys
assertEquals(
VaultItemListingState.ViewState.NoItems(
- message = R.string.no_items.asText(),
+ message = R.string.no_ssh_keys.asText(),
shouldShowAddButton = false,
- buttonText = R.string.new_item.asText(),
+ buttonText = R.string.new_ssh_key.asText(),
),
vaultData.toViewState(
itemListingType = VaultItemListingState.ItemListingType.Vault.SshKey,