Update the current user's last active time when navigating (#606)

This commit is contained in:
Brian Yencho
2024-06-20 17:08:07 +01:00
committed by Álison Fernandes
parent 3def25366b
commit 056b6eb30c
9 changed files with 119 additions and 7 deletions
@@ -125,6 +125,8 @@ class AuthRepositoryTest {
every { logout(any()) } just runs
}
private var elapsedRealtimeMillis = 123456789L
private val repository = AuthRepositoryImpl(
accountsService = accountsService,
identityService = identityService,
@@ -136,6 +138,7 @@ class AuthRepositoryTest {
vaultRepository = vaultRepository,
userLogoutManager = userLogoutManager,
dispatcherManager = dispatcherManager,
elapsedRealtimeMillisProvider = { elapsedRealtimeMillis },
)
@BeforeEach
@@ -1220,6 +1223,21 @@ class AuthRepositoryTest {
verify { vaultRepository.clearUnlockedData() }
}
@Test
fun `updateLastActiveTime should update the last active time for the current user`() {
val userId = USER_ID_1
fakeAuthDiskSource.userState = SINGLE_USER_STATE_1
assertNull(fakeAuthDiskSource.getLastActiveTimeMillis(userId = userId))
repository.updateLastActiveTime()
assertEquals(
elapsedRealtimeMillis,
fakeAuthDiskSource.getLastActiveTimeMillis(userId = userId),
)
}
@Test
fun `getPasswordBreachCount should return failure when service returns failure`() = runTest {
val password = "password"
@@ -5,7 +5,10 @@ import com.x8bit.bitwarden.data.auth.repository.model.UserState
import com.x8bit.bitwarden.data.platform.repository.model.Environment
import com.x8bit.bitwarden.ui.platform.base.BaseViewModelTest
import io.mockk.every
import io.mockk.just
import io.mockk.mockk
import io.mockk.runs
import io.mockk.verify
import kotlinx.coroutines.flow.MutableStateFlow
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Test
@@ -14,6 +17,7 @@ class RootNavViewModelTest : BaseViewModelTest() {
private val mutableUserStateFlow = MutableStateFlow<UserState?>(null)
private val authRepository = mockk<AuthRepository>() {
every { userStateFlow } returns mutableUserStateFlow
every { updateLastActiveTime() } just runs
}
@Test
@@ -74,6 +78,13 @@ class RootNavViewModelTest : BaseViewModelTest() {
assertEquals(RootNavState.VaultLocked, viewModel.stateFlow.value)
}
@Test
fun `BackStackUpdate should call updateLastActiveTime`() {
val viewModel = createViewModel()
viewModel.trySendAction(RootNavAction.BackStackUpdate)
verify { authRepository.updateLastActiveTime() }
}
private fun createViewModel(): RootNavViewModel =
RootNavViewModel(
authRepository = authRepository,
@@ -1,15 +1,25 @@
package com.x8bit.bitwarden.ui.platform.feature.vaultunlockednavbar
import app.cash.turbine.test
import com.x8bit.bitwarden.data.auth.repository.AuthRepository
import com.x8bit.bitwarden.ui.platform.base.BaseViewModelTest
import io.mockk.every
import io.mockk.just
import io.mockk.mockk
import io.mockk.runs
import io.mockk.verify
import kotlinx.coroutines.test.runTest
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Test
class VaultUnlockedNavBarViewModelTest : BaseViewModelTest() {
private val authRepository: AuthRepository = mockk {
every { updateLastActiveTime() } just runs
}
@Test
fun `VaultTabClick should navigate to the vault screen`() = runTest {
val viewModel = VaultUnlockedNavBarViewModel()
val viewModel = createViewModel()
viewModel.eventFlow.test {
viewModel.trySendAction(VaultUnlockedNavBarAction.VaultTabClick)
assertEquals(VaultUnlockedNavBarEvent.NavigateToVaultScreen, awaitItem())
@@ -18,7 +28,7 @@ class VaultUnlockedNavBarViewModelTest : BaseViewModelTest() {
@Test
fun `SendTabClick should navigate to the send screen`() = runTest {
val viewModel = VaultUnlockedNavBarViewModel()
val viewModel = createViewModel()
viewModel.eventFlow.test {
viewModel.trySendAction(VaultUnlockedNavBarAction.SendTabClick)
assertEquals(VaultUnlockedNavBarEvent.NavigateToSendScreen, awaitItem())
@@ -27,7 +37,7 @@ class VaultUnlockedNavBarViewModelTest : BaseViewModelTest() {
@Test
fun `GeneratorTabClick should navigate to the generator screen`() = runTest {
val viewModel = VaultUnlockedNavBarViewModel()
val viewModel = createViewModel()
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(VaultUnlockedNavBarAction.GeneratorTabClick)
assertEquals(VaultUnlockedNavBarEvent.NavigateToGeneratorScreen, awaitItem())
@@ -36,10 +46,22 @@ class VaultUnlockedNavBarViewModelTest : BaseViewModelTest() {
@Test
fun `SettingsTabClick should navigate to the settings screen`() = runTest {
val viewModel = VaultUnlockedNavBarViewModel()
val viewModel = createViewModel()
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(VaultUnlockedNavBarAction.SettingsTabClick)
assertEquals(VaultUnlockedNavBarEvent.NavigateToSettingsScreen, awaitItem())
}
}
@Test
fun `BackStackUpdate should call updateLastActiveTime`() {
val viewModel = createViewModel()
viewModel.trySendAction(VaultUnlockedNavBarAction.BackStackUpdate)
verify { authRepository.updateLastActiveTime() }
}
private fun createViewModel() =
VaultUnlockedNavBarViewModel(
authRepository = authRepository,
)
}