From 016f597d8ce44ec6f804251691cd72ae47f838e2 Mon Sep 17 00:00:00 2001 From: Andrew Haisting <142518658+ahaisting-livefront@users.noreply.github.com> Date: Thu, 21 Sep 2023 11:50:55 -0500 Subject: [PATCH] BIT-588 Relax documentation requirements deep within the network layer (#58) --- .../data/auth/datasource/network/api/AccountsApi.kt | 3 --- .../data/auth/datasource/network/api/IdentityApi.kt | 3 --- .../data/platform/datasource/network/api/ConfigApi.kt | 6 +----- detekt-config.yml | 4 ++-- 4 files changed, 3 insertions(+), 13 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/AccountsApi.kt b/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/AccountsApi.kt index c7fbc8b4cc..53ae0fc302 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/AccountsApi.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/AccountsApi.kt @@ -10,9 +10,6 @@ import retrofit2.http.POST */ interface AccountsApi { - /** - * Make pre login request to get KDF params. - */ @POST("/accounts/prelogin") suspend fun preLogin(@Body body: PreLoginRequestJson): Result } diff --git a/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/IdentityApi.kt b/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/IdentityApi.kt index 26f0bac57a..31684a7549 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/IdentityApi.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/IdentityApi.kt @@ -14,9 +14,6 @@ import java.util.UUID */ interface IdentityApi { - /** - * Make request to get an access token. - */ @POST @Suppress("LongParameterList") @FormUrlEncoded diff --git a/app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/api/ConfigApi.kt b/app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/api/ConfigApi.kt index 48930440fb..7b26a56dff 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/api/ConfigApi.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/api/ConfigApi.kt @@ -7,11 +7,7 @@ import retrofit2.http.GET * This interface defines the API service for fetching configuration data. */ interface ConfigApi { - /** - * Retrieves the configuration data from the server. - * - * @return A [ConfigResponseJson] containing the configuration response model. - */ + @GET("config") suspend fun getConfig(): Result } diff --git a/detekt-config.yml b/detekt-config.yml index 2f553bdfd8..24fd55a769 100644 --- a/detekt-config.yml +++ b/detekt-config.yml @@ -27,7 +27,7 @@ output-reports: comments: active: true - excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/jsTest/**', '**/iosTest/**' ] + excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/jsTest/**', '**/iosTest/**', '**ServiceImpl.kt' ] AbsentOrWrongFileLicense: active: false licenseTemplateFile: 'license.template' @@ -46,7 +46,7 @@ comments: searchInInnerInterface: true UndocumentedPublicFunction: active: true - ignoreAnnotated: [ 'Module' ] + ignoreAnnotated: [ 'Module', 'POST', 'PUT', 'DELETE', 'GET', 'PATCH' ] UndocumentedPublicProperty: active: false