mirror of
https://github.com/actualbudget/actual.git
synced 2026-04-29 11:04:12 -05:00
180431f9ed
My Monzo bank appears to return 'name' through the GoCardless getDetails and getMetadata calls, but the value in the getMetadata response is an empty string! Merging metadata values over detail values therefore risks losing values, that are useful to have & to present to the user. To solve this, we can make getDetailedAccount smarter about merging the two objects. We could swap the object splattening around so details has priority over metadata, but I'm not at all confident there won't be other banks doing strange things with additional properties that might suffer similar bugs in the reverse scenario. Instead, we loop through all keys in both objects and construct a new merged object, continuing to prioritise metadata over details but changing it to a truthy-based comparison (with the `||` operator). Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
117 B
117 B
category, authors
| category | authors | |
|---|---|---|
| Bugfix |
|
Fix account properties being overriden with empty values from metadata