mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-21 15:36:50 -05:00
7318015a1f
The job intermittently failed with "==> (not found) Artifact: build-stats" due to a race condition: action-wait-for-check waited by commit SHA while action-download-artifact searched by PR number, picking a newer still-running workflow run whose artifacts hadn't been uploaded yet. Fixes: - Use commit SHA instead of PR number for PR artifact downloads to match the exact workflow run that was waited on - Add if_no_artifact_found: warn to all download steps (defense in depth) - Upgrade CLI download steps from v11 to v18 to support this parameter - Add timeoutSeconds/intervalSeconds to all wait-for-check steps - Expand failure detection to cover base branch builds and add warning step for incomplete builds - Make bundle-stats-comment.mjs gracefully skip missing stats files instead of throwing - Add if: !cancelled() to generate/post steps so they run after warnings https://claude.ai/code/session_015TDkitgqM2TsgFSCuGaFuF
225 lines
10 KiB
YAML
225 lines
10 KiB
YAML
name: Compare Sizes
|
|
|
|
##########################################################################################
|
|
# WARNING! This workflow uses the 'pull_request_target' event. That mans that it will #
|
|
# always run in the context of the main actualbudget/actual repo, even if the PR is from #
|
|
# a fork. This is necessary to get access to a GitHub token that can post a comment on #
|
|
# the PR. Be VERY CAREFUL about adding things to this workflow, since forks can inject #
|
|
# arbitrary code into their branch, and can pollute the artifacts we download. Arbitrary #
|
|
# code execution in this workflow could lead to a compromise of the main repo. #
|
|
##########################################################################################
|
|
# See: https://securitylab.github.com/research/github-actions-preventing-pwn-requests #
|
|
##########################################################################################
|
|
|
|
on:
|
|
pull_request_target:
|
|
paths:
|
|
- 'packages/**'
|
|
- 'package.json'
|
|
- 'yarn.lock'
|
|
- '.github/workflows/size-compare.yml'
|
|
- '!packages/sync-server/**' # Sync server changes don't affect the size of the web/api
|
|
- '!packages/ci-actions/**' # CI actions changes don't affect the size of the web/api
|
|
- '!packages/docs/**' # Docs changes don't affect the size of the web/api
|
|
- '!packages/eslint-plugin-actual/**' # Eslint plugin changes don't affect the size of the web/api
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
compare:
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
pull-requests: write
|
|
contents: read
|
|
steps:
|
|
- name: Checkout base branch
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
with:
|
|
ref: ${{ github.base_ref }}
|
|
- name: Set up environment
|
|
uses: ./.github/actions/setup
|
|
with:
|
|
download-translations: 'false'
|
|
|
|
- name: Wait for ${{github.base_ref}} web build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: master-web-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: web
|
|
ref: ${{github.base_ref}}
|
|
timeoutSeconds: 1200
|
|
intervalSeconds: 30
|
|
- name: Wait for ${{github.base_ref}} API build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: master-api-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: api
|
|
ref: ${{github.base_ref}}
|
|
timeoutSeconds: 1200
|
|
intervalSeconds: 30
|
|
- name: Wait for ${{github.base_ref}} CLI build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: master-cli-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: cli
|
|
ref: ${{github.base_ref}}
|
|
timeoutSeconds: 1200
|
|
intervalSeconds: 30
|
|
|
|
- name: Wait for PR build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: wait-for-web-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: web
|
|
ref: ${{github.event.pull_request.head.sha}}
|
|
timeoutSeconds: 1200
|
|
intervalSeconds: 30
|
|
- name: Wait for API PR build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: wait-for-api-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: api
|
|
ref: ${{github.event.pull_request.head.sha}}
|
|
timeoutSeconds: 1200
|
|
intervalSeconds: 30
|
|
- name: Wait for CLI PR build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: wait-for-cli-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: cli
|
|
ref: ${{github.event.pull_request.head.sha}}
|
|
timeoutSeconds: 1200
|
|
intervalSeconds: 30
|
|
|
|
- name: Report build failure
|
|
if: |
|
|
steps.wait-for-web-build.outputs.conclusion == 'failure' ||
|
|
steps.wait-for-api-build.outputs.conclusion == 'failure' ||
|
|
steps.wait-for-cli-build.outputs.conclusion == 'failure' ||
|
|
steps.master-web-build.outputs.conclusion == 'failure' ||
|
|
steps.master-api-build.outputs.conclusion == 'failure' ||
|
|
steps.master-cli-build.outputs.conclusion == 'failure'
|
|
run: |
|
|
echo "Build failed on PR branch or ${{github.base_ref}}"
|
|
exit 1
|
|
- name: Warn on incomplete builds
|
|
if: |
|
|
steps.wait-for-web-build.outputs.conclusion != 'success' ||
|
|
steps.wait-for-api-build.outputs.conclusion != 'success' ||
|
|
steps.wait-for-cli-build.outputs.conclusion != 'success' ||
|
|
steps.master-web-build.outputs.conclusion != 'success' ||
|
|
steps.master-api-build.outputs.conclusion != 'success' ||
|
|
steps.master-cli-build.outputs.conclusion != 'success'
|
|
run: |
|
|
echo "::warning::Some builds did not complete successfully. Bundle stats may be incomplete."
|
|
echo "Base branch - web: ${{ steps.master-web-build.outputs.conclusion }}, api: ${{ steps.master-api-build.outputs.conclusion }}, cli: ${{ steps.master-cli-build.outputs.conclusion }}"
|
|
echo "PR - web: ${{ steps.wait-for-web-build.outputs.conclusion }}, api: ${{ steps.wait-for-api-build.outputs.conclusion }}, cli: ${{ steps.wait-for-cli-build.outputs.conclusion }}"
|
|
|
|
- name: Download web build artifact from ${{github.base_ref}}
|
|
uses: dawidd6/action-download-artifact@1f8785ff7a5130826f848e7f72725c85d241860f # v18
|
|
id: pr-web-build
|
|
with:
|
|
branch: ${{github.base_ref}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: build-stats
|
|
path: base
|
|
if_no_artifact_found: warn
|
|
- name: Download API build artifact from ${{github.base_ref}}
|
|
uses: dawidd6/action-download-artifact@1f8785ff7a5130826f848e7f72725c85d241860f # v18
|
|
id: pr-api-build
|
|
with:
|
|
branch: ${{github.base_ref}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: api-build-stats
|
|
path: base
|
|
if_no_artifact_found: warn
|
|
- name: Download build stats from PR
|
|
uses: dawidd6/action-download-artifact@1f8785ff7a5130826f848e7f72725c85d241860f # v18
|
|
with:
|
|
commit: ${{github.event.pull_request.head.sha}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: build-stats
|
|
path: head
|
|
allow_forks: true
|
|
if_no_artifact_found: warn
|
|
- name: Download API stats from PR
|
|
uses: dawidd6/action-download-artifact@1f8785ff7a5130826f848e7f72725c85d241860f # v18
|
|
with:
|
|
commit: ${{github.event.pull_request.head.sha}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: api-build-stats
|
|
path: head
|
|
allow_forks: true
|
|
if_no_artifact_found: warn
|
|
- name: Download CLI build artifact from ${{github.base_ref}}
|
|
uses: dawidd6/action-download-artifact@1f8785ff7a5130826f848e7f72725c85d241860f # v18
|
|
with:
|
|
branch: ${{github.base_ref}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: cli-build-stats
|
|
path: base
|
|
if_no_artifact_found: warn
|
|
- name: Download CLI stats from PR
|
|
uses: dawidd6/action-download-artifact@1f8785ff7a5130826f848e7f72725c85d241860f # v18
|
|
with:
|
|
commit: ${{github.event.pull_request.head.sha}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: cli-build-stats
|
|
path: head
|
|
allow_forks: true
|
|
if_no_artifact_found: warn
|
|
- name: Strip content hashes from stats files
|
|
run: |
|
|
if [ -f ./head/web-stats.json ]; then
|
|
sed -i -E 's/index\.[0-9a-zA-Z_-]{8,}\./index./g' ./head/web-stats.json
|
|
sed -i -E 's/\.[0-9a-zA-Z_-]{8,}\.chunk\././g' ./head/web-stats.json
|
|
fi
|
|
if [ -f ./base/web-stats.json ]; then
|
|
sed -i -E 's/index\.[0-9a-zA-Z_-]{8,}\./index./g' ./base/web-stats.json
|
|
sed -i -E 's/\.[0-9a-zA-Z_-]{8,}\.chunk\././g' ./base/web-stats.json
|
|
fi
|
|
for file in ./head/*.json ./base/*.json; do
|
|
if [ -f "$file" ]; then
|
|
sed -i -E 's/\.[0-9a-f]{8,}\././g' "$file"
|
|
fi
|
|
done
|
|
- name: Generate combined bundle stats comment
|
|
if: ${{ !cancelled() }}
|
|
run: |
|
|
node packages/ci-actions/bin/bundle-stats-comment.mjs \
|
|
--base desktop-client=./base/web-stats.json \
|
|
--base loot-core=./base/loot-core-stats.json \
|
|
--base api=./base/api-stats.json \
|
|
--base cli=./base/cli-stats.json \
|
|
--head desktop-client=./head/web-stats.json \
|
|
--head loot-core=./head/loot-core-stats.json \
|
|
--head api=./head/api-stats.json \
|
|
--head cli=./head/cli-stats.json \
|
|
--identifier combined \
|
|
--format pr-body > bundle-stats-comment.md
|
|
- name: Post combined bundle stats comment
|
|
if: ${{ !cancelled() }}
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
GITHUB_REPOSITORY: ${{ github.repository }}
|
|
PR_NUMBER: ${{ github.event.pull_request.number }}
|
|
run: |
|
|
node packages/ci-actions/bin/update-bundle-stats-comment.mjs \
|
|
--comment-file bundle-stats-comment.md \
|
|
--identifier combined \
|
|
--target pr-body
|