mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-11 20:44:32 -05:00
* [AI] Desktop client, E2E, loot-core, sync-server and tooling updates Co-authored-by: Cursor <cursoragent@cursor.com> * Refactor database handling in various modules to use async/await for improved readability and error handling. This includes updates to database opening and closing methods across multiple files, ensuring consistent asynchronous behavior. Additionally, minor adjustments were made to encryption functions to support async operations. * Refactor sync migration tests to utilize async/await for improved readability. Updated transaction handling to streamline event expectations and cleanup process. * Refactor various functions to utilize async/await for improved readability and error handling. Updated service stopping, encryption, and file upload/download methods to ensure consistent asynchronous behavior across the application. * Refactor BudgetFileSelection component to use async/await for onSelect method, enhancing error handling and readability. Update merge tests to utilize async/await for improved clarity in transaction merging expectations. * Refactor filesystem module to use async/await for init function and related database operations, enhancing error handling and consistency across file interactions. Updated tests to reflect asynchronous behavior in database operations and file writing. * Fix typo in init function declaration to ensure it returns a Promise<void> instead of Proise<void>. * Update VRT screenshots Auto-generated by VRT workflow PR: #6987 * Update tests to use async/await for init function in web filesystem, ensuring consistent asynchronous behavior in database operations. * Update VRT screenshot for payees filter test to reflect recent changes * [AI] Fix no-floating-promises lint error in desktop-electron Wrapped queuedClientWinLogs.map() with Promise.all and void operator to properly handle the array of promises for executing queued logs. Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com> * Refactor promise handling in global and sync event handlers * Update VRT screenshots Auto-generated by VRT workflow PR: #6987 --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com>
509 lines
15 KiB
JavaScript
509 lines
15 KiB
JavaScript
import { Octokit } from '@octokit/rest';
|
|
import { minimatch } from 'minimatch';
|
|
import pLimit from 'p-limit';
|
|
|
|
const limit = pLimit(50);
|
|
|
|
const CONFIG = {
|
|
POINTS_PER_ISSUE_TRIAGE_ACTION: 1,
|
|
POINTS_PER_ISSUE_CLOSING_ACTION: 1,
|
|
POINTS_PER_RELEASE_PR: 4, // Awarded to whoever merges the release PR
|
|
PR_CONTRIBUTION_POINTS: {
|
|
Features: 2,
|
|
Enhancements: 2,
|
|
Bugfix: 3,
|
|
Maintenance: 2,
|
|
Unknown: 2,
|
|
},
|
|
// Point tiers for code changes (non-docs)
|
|
CODE_PR_REVIEW_POINT_TIERS: [
|
|
{ minChanges: 500, points: 8 },
|
|
{ minChanges: 100, points: 6 },
|
|
{ minChanges: 10, points: 2 },
|
|
{ minChanges: 0, points: 1 },
|
|
],
|
|
// Point tiers for docs changes (packages/docs/**)
|
|
DOCS_PR_REVIEW_POINT_TIERS: [
|
|
{ minChanges: 2000, points: 6 },
|
|
{ minChanges: 200, points: 4 },
|
|
{ minChanges: 0, points: 2 },
|
|
],
|
|
EXCLUDED_FILES: [
|
|
'yarn.lock',
|
|
'.yarn/**/*',
|
|
'packages/component-library/src/icons/**/*',
|
|
'release-notes/**/*',
|
|
'upcoming-release-notes/**/*',
|
|
],
|
|
DOCS_FILES_PATTERN: 'packages/docs/**/*',
|
|
};
|
|
|
|
/**
|
|
* Parse category from release notes file content.
|
|
* @param {string} content - The content of the release notes file.
|
|
* @returns {string|null} The category or null if not found.
|
|
*/
|
|
function parseReleaseNotesCategory(content) {
|
|
if (!content) return null;
|
|
|
|
// Extract YAML front matter
|
|
const frontMatterMatch = content.match(/^---\s*\n([\s\S]*?)\n---/);
|
|
if (!frontMatterMatch) return null;
|
|
|
|
// Extract category from front matter
|
|
const categoryMatch = frontMatterMatch[1].match(/^category:\s*(.+)$/m);
|
|
if (!categoryMatch) return null;
|
|
|
|
return categoryMatch[1].trim();
|
|
}
|
|
|
|
/**
|
|
* Get the last commit SHA on or before a given date.
|
|
* @param {Octokit} octokit - The Octokit instance.
|
|
* @param {string} owner - Repository owner.
|
|
* @param {string} repo - Repository name.
|
|
* @param {Date} beforeDate - The date to find the last commit before.
|
|
* @returns {Promise<string|null>} The commit SHA or null if not found.
|
|
*/
|
|
async function getLastCommitBeforeDate(octokit, owner, repo, beforeDate) {
|
|
try {
|
|
// Get the default branch from the repository
|
|
const { data: repoData } = await octokit.repos.get({ owner, repo });
|
|
const defaultBranch = repoData.default_branch;
|
|
|
|
const { data: commits } = await octokit.repos.listCommits({
|
|
owner,
|
|
repo,
|
|
sha: defaultBranch,
|
|
until: beforeDate.toISOString(),
|
|
per_page: 1,
|
|
});
|
|
|
|
if (commits.length > 0) {
|
|
return commits[0].sha;
|
|
}
|
|
} catch {
|
|
// If error occurs, return null to fall back to default branch
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Get the category and points for a PR by reading its release notes file.
|
|
* @param {Octokit} octokit - The Octokit instance.
|
|
* @param {string} owner - Repository owner.
|
|
* @param {string} repo - Repository name.
|
|
* @param {number} prNumber - PR number.
|
|
* @param {Date} monthEnd - The end date of the month to use as base revision.
|
|
* @returns {Promise<Object>} Object with category and points, or null if error.
|
|
*/
|
|
async function getPRCategoryAndPoints(
|
|
octokit,
|
|
owner,
|
|
repo,
|
|
prNumber,
|
|
monthEnd,
|
|
) {
|
|
const releaseNotesPath = `upcoming-release-notes/${prNumber}.md`;
|
|
|
|
try {
|
|
// Get the last commit of the month to use as base revision
|
|
const commitSha = await getLastCommitBeforeDate(
|
|
octokit,
|
|
owner,
|
|
repo,
|
|
monthEnd,
|
|
);
|
|
|
|
// Try to read the release notes file from the last commit of the month
|
|
const { data: fileContent } = await octokit.repos.getContent({
|
|
owner,
|
|
repo,
|
|
path: releaseNotesPath,
|
|
ref: commitSha || undefined, // Use commit SHA if available, otherwise default branch
|
|
});
|
|
|
|
if (fileContent.content) {
|
|
// Decode base64 content
|
|
const content = Buffer.from(fileContent.content, 'base64').toString(
|
|
'utf-8',
|
|
);
|
|
const category = parseReleaseNotesCategory(content);
|
|
|
|
if (category && CONFIG.PR_CONTRIBUTION_POINTS[category]) {
|
|
return {
|
|
category,
|
|
points: CONFIG.PR_CONTRIBUTION_POINTS[category],
|
|
};
|
|
}
|
|
}
|
|
} catch {
|
|
// Do nothing
|
|
}
|
|
|
|
return {
|
|
category: 'Unknown',
|
|
points: CONFIG.PR_CONTRIBUTION_POINTS.Unknown,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Get the start and end dates for the last month.
|
|
* @returns {Object} An object containing the start and end dates.
|
|
*/
|
|
function getLastMonthDates() {
|
|
// Get data relating to the last month
|
|
const now = new Date();
|
|
// Always use UTC for calculations
|
|
const firstDayOfLastMonth = new Date(
|
|
Date.UTC(now.getUTCFullYear(), now.getUTCMonth() - 1, 1, 0, 0, 0, 0),
|
|
);
|
|
const since = process.env.START_DATE
|
|
? new Date(Date.parse(process.env.START_DATE))
|
|
: firstDayOfLastMonth;
|
|
|
|
// Calculate the end of the month for the since date in UTC
|
|
const until = new Date(
|
|
Date.UTC(
|
|
since.getUTCFullYear(),
|
|
since.getUTCMonth() + 1,
|
|
0,
|
|
23,
|
|
59,
|
|
59,
|
|
999,
|
|
),
|
|
);
|
|
|
|
return { since, until };
|
|
}
|
|
|
|
/**
|
|
* Used for calculating the monthly points each core contributor has earned.
|
|
* These are used for payouts depending.
|
|
* @returns {Map} A map of contributor logins to their total points earned
|
|
*/
|
|
async function countContributorPoints() {
|
|
const octokit = new Octokit({
|
|
auth: process.env.GITHUB_TOKEN,
|
|
});
|
|
const owner = 'actualbudget';
|
|
const repo = 'actual';
|
|
|
|
const { since, until } = getLastMonthDates();
|
|
|
|
// Get organization members
|
|
const { data: orgMembers } = await octokit.orgs.listMembers({
|
|
org: owner,
|
|
});
|
|
const orgMemberLogins = new Set(orgMembers.map(member => member.login));
|
|
|
|
// Initialize stats map with all org members
|
|
const stats = new Map(
|
|
Array.from(orgMemberLogins).map(login => [
|
|
login,
|
|
{
|
|
codeReviews: [], // Will store objects with PR number and points for main repo changes
|
|
docsReviews: [], // Will store objects with PR number and points for docs changes
|
|
prContributions: [], // Will store objects with PR number, category, and points for PR author contributions
|
|
labelRemovals: [],
|
|
issueClosings: [],
|
|
points: 0,
|
|
},
|
|
]),
|
|
);
|
|
|
|
// Helper function to print statistics
|
|
const printStats = (title, getValue, formatLine) => {
|
|
console.log(`\n${title}:`);
|
|
console.log('='.repeat(title.length + 1));
|
|
|
|
const entries = Array.from(stats.entries())
|
|
.map(([user, userStats]) => [user, getValue(userStats)])
|
|
.filter(([, count]) => count > 0)
|
|
.sort((a, b) => b[1] - a[1]);
|
|
|
|
if (entries.length === 0) {
|
|
console.log(`No ${title.toLowerCase()} found in the last month.`);
|
|
} else {
|
|
entries.forEach(([user, count]) => {
|
|
console.log(formatLine(user, count));
|
|
});
|
|
}
|
|
};
|
|
|
|
// Get all PRs using search
|
|
const searchQuery = `repo:${owner}/${repo} is:pr is:merged merged:${since.toISOString()}..${until.toISOString()}`;
|
|
const recentPRs = await octokit.paginate(
|
|
'GET /search/issues',
|
|
{
|
|
q: searchQuery,
|
|
per_page: 100,
|
|
advanced_search: true,
|
|
},
|
|
response => response.data.filter(pr => pr.number),
|
|
);
|
|
|
|
// Get reviews and PR details for each PR
|
|
await Promise.all(
|
|
recentPRs.map(pr =>
|
|
limit(async () => {
|
|
const [reviews, modifiedFiles] = await Promise.all([
|
|
octokit.pulls.listReviews({ owner, repo, pull_number: pr.number }),
|
|
octokit.paginate(
|
|
octokit.pulls.listFiles,
|
|
{
|
|
owner,
|
|
repo,
|
|
pull_number: pr.number,
|
|
per_page: 100,
|
|
},
|
|
res => res.data,
|
|
),
|
|
]);
|
|
|
|
const filteredFiles = modifiedFiles.filter(
|
|
file =>
|
|
!CONFIG.EXCLUDED_FILES.some(pattern =>
|
|
minimatch(file.filename, pattern, { dot: true }),
|
|
),
|
|
);
|
|
|
|
const docsFiles = filteredFiles.filter(file =>
|
|
minimatch(file.filename, CONFIG.DOCS_FILES_PATTERN, { dot: true }),
|
|
);
|
|
const codeFiles = filteredFiles.filter(
|
|
file =>
|
|
!minimatch(file.filename, CONFIG.DOCS_FILES_PATTERN, { dot: true }),
|
|
);
|
|
|
|
const docsChanges = docsFiles.reduce(
|
|
(sum, file) => sum + file.additions + file.deletions,
|
|
0,
|
|
);
|
|
const codeChanges = codeFiles.reduce(
|
|
(sum, file) => sum + file.additions + file.deletions,
|
|
0,
|
|
);
|
|
|
|
const docsPoints =
|
|
docsChanges > 0
|
|
? (CONFIG.DOCS_PR_REVIEW_POINT_TIERS.find(
|
|
t => docsChanges >= t.minChanges,
|
|
)?.points ?? 0)
|
|
: 0;
|
|
const codePoints =
|
|
codeChanges > 0 || docsChanges === 0
|
|
? (CONFIG.CODE_PR_REVIEW_POINT_TIERS.find(
|
|
t => codeChanges >= t.minChanges,
|
|
)?.points ?? 0)
|
|
: 0;
|
|
|
|
const isReleasePR = pr.title.match(/🔖.*\d+\.\d+\.\d+/);
|
|
|
|
if (isReleasePR) {
|
|
// release PRs are created by the github-actions bot so we attribute points to the merger
|
|
const { data: prDetails } = await octokit.pulls.get({
|
|
owner,
|
|
repo,
|
|
pull_number: pr.number,
|
|
});
|
|
|
|
if (prDetails.merged_by && stats.has(prDetails.merged_by.login)) {
|
|
const mergerStats = stats.get(prDetails.merged_by.login);
|
|
mergerStats.codeReviews.push({
|
|
pr: pr.number.toString(),
|
|
points: CONFIG.POINTS_PER_RELEASE_PR,
|
|
isReleaseMerger: true,
|
|
});
|
|
mergerStats.points += CONFIG.POINTS_PER_RELEASE_PR;
|
|
}
|
|
} else {
|
|
// Award points to PR author if they are a core maintainer
|
|
const prAuthor = pr.user?.login;
|
|
if (prAuthor && orgMemberLogins.has(prAuthor)) {
|
|
const categoryAndPoints = await getPRCategoryAndPoints(
|
|
octokit,
|
|
owner,
|
|
repo,
|
|
pr.number,
|
|
until,
|
|
);
|
|
|
|
if (categoryAndPoints) {
|
|
const authorStats = stats.get(prAuthor);
|
|
authorStats.prContributions.push({
|
|
pr: pr.number.toString(),
|
|
category: categoryAndPoints.category,
|
|
points: categoryAndPoints.points,
|
|
});
|
|
authorStats.points += categoryAndPoints.points;
|
|
}
|
|
}
|
|
|
|
const uniqueReviewers = new Set();
|
|
reviews.data.forEach(review => {
|
|
if (
|
|
review.state === 'APPROVED' &&
|
|
stats.has(review.user?.login) &&
|
|
!uniqueReviewers.has(review.user?.login)
|
|
) {
|
|
const reviewer = review.user.login;
|
|
uniqueReviewers.add(reviewer);
|
|
const userStats = stats.get(reviewer);
|
|
|
|
if (docsPoints > 0) {
|
|
userStats.docsReviews.push({
|
|
pr: pr.number.toString(),
|
|
points: docsPoints,
|
|
});
|
|
userStats.points += docsPoints;
|
|
}
|
|
|
|
if (codePoints > 0) {
|
|
userStats.codeReviews.push({
|
|
pr: pr.number.toString(),
|
|
points: codePoints,
|
|
});
|
|
userStats.points += codePoints;
|
|
}
|
|
}
|
|
});
|
|
}
|
|
}),
|
|
),
|
|
);
|
|
|
|
// Get all issues with label events in the last month
|
|
const issues = await octokit.paginate(octokit.issues.listForRepo, {
|
|
owner,
|
|
repo,
|
|
state: 'all',
|
|
sort: 'updated',
|
|
direction: 'desc',
|
|
per_page: 100,
|
|
since: since.toISOString(),
|
|
});
|
|
|
|
// Get label events for each issue
|
|
await Promise.all(
|
|
issues.map(issue =>
|
|
limit(async () => {
|
|
const { data: events } = await octokit.issues.listEventsForTimeline({
|
|
owner,
|
|
repo,
|
|
issue_number: issue.number,
|
|
});
|
|
|
|
events
|
|
.filter(event => {
|
|
const createdAt = new Date(event.created_at);
|
|
return (
|
|
createdAt.getTime() > since.getTime() &&
|
|
createdAt.getTime() <= until.getTime() &&
|
|
stats.has(event.actor?.login)
|
|
);
|
|
})
|
|
.forEach(event => {
|
|
if (
|
|
event.event === 'unlabeled' &&
|
|
event.label?.name.toLowerCase() === 'needs triage'
|
|
) {
|
|
const remover = event.actor.login;
|
|
const userStats = stats.get(remover);
|
|
userStats.labelRemovals.push(issue.number.toString());
|
|
userStats.points += CONFIG.POINTS_PER_ISSUE_TRIAGE_ACTION;
|
|
}
|
|
|
|
if (
|
|
event.event === 'closed' &&
|
|
['not_planned', 'duplicate'].includes(event.state_reason)
|
|
) {
|
|
const closer = event.actor.login;
|
|
const userStats = stats.get(closer);
|
|
userStats.issueClosings.push(issue.number.toString());
|
|
userStats.points += CONFIG.POINTS_PER_ISSUE_CLOSING_ACTION;
|
|
}
|
|
});
|
|
}),
|
|
),
|
|
);
|
|
|
|
// Print all statistics
|
|
printStats(
|
|
'Code Review Statistics',
|
|
stats => stats.codeReviews.reduce((sum, r) => sum + r.points, 0),
|
|
(user, count) =>
|
|
`${user}: ${count} (PRs: ${stats
|
|
.get(user)
|
|
.codeReviews.map(r => {
|
|
if (r.isReleaseMerger) {
|
|
return `#${r.pr} (${r.points}pts - Release Merger)`;
|
|
}
|
|
return `#${r.pr} (${r.points}pts)`;
|
|
})
|
|
.join(', ')})`,
|
|
);
|
|
|
|
printStats(
|
|
'Docs Review Statistics',
|
|
stats => stats.docsReviews.reduce((sum, r) => sum + r.points, 0),
|
|
(user, count) =>
|
|
`${user}: ${count} (PRs: ${stats
|
|
.get(user)
|
|
.docsReviews.map(r => `#${r.pr} (${r.points}pts)`)
|
|
.join(', ')})`,
|
|
);
|
|
|
|
printStats(
|
|
'PR Contribution Statistics',
|
|
stats => stats.prContributions.reduce((sum, r) => sum + r.points, 0),
|
|
(user, count) =>
|
|
`${user}: ${count} (PRs: ${stats
|
|
.get(user)
|
|
.prContributions.map(r => `#${r.pr} (${r.points}pts - ${r.category})`)
|
|
.join(', ')})`,
|
|
);
|
|
|
|
printStats(
|
|
'"Needs Triage" Label Removal Statistics',
|
|
stats => stats.labelRemovals.length * CONFIG.POINTS_PER_ISSUE_TRIAGE_ACTION,
|
|
(user, count) =>
|
|
`${user}: ${count} (Issues: ${stats.get(user).labelRemovals.join(', ')})`,
|
|
);
|
|
|
|
printStats(
|
|
'Issue Closing Statistics',
|
|
stats =>
|
|
stats.issueClosings.length * CONFIG.POINTS_PER_ISSUE_CLOSING_ACTION,
|
|
(user, count) =>
|
|
`${user}: ${count} (Issues: ${stats.get(user).issueClosings.join(', ')})`,
|
|
);
|
|
|
|
// Print points summary
|
|
printStats(
|
|
'Points Summary',
|
|
stats => stats.points,
|
|
(user, userPoints) => `${user}: ${userPoints}`,
|
|
);
|
|
|
|
// Calculate and print total points
|
|
const totalPoints = Array.from(stats.values()).reduce(
|
|
(sum, userStats) => sum + userStats.points,
|
|
0,
|
|
);
|
|
console.log(`\nTotal points earned: ${totalPoints}`);
|
|
|
|
// Return the points
|
|
return new Map(
|
|
Array.from(stats.entries()).map(([login, userStats]) => [
|
|
login,
|
|
userStats.points,
|
|
]),
|
|
);
|
|
}
|
|
|
|
// Run the calculations
|
|
countContributorPoints().catch(console.error);
|