mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-21 15:36:50 -05:00
60e2665fcc
* Phase 1: Add payee locations database schema/types * Add migration to create payee_locations table with proper indexes * Add PayeeLocationEntity type definition * Update database schema to include payee_locations table * Export PayeeLocationEntity from models index * Phase 2: Add payee location API/services * Add constants for default location behavior * Implement location service with geolocation adapters * Add new API handlers for payee location operations * Phase 3: Add location-aware UI components/hooks * Update mobile transaction editing with location integration * Enhance PayeeAutocomplete with nearby payee suggestions and forget functionality * Implement location permission and placeholder unit of measurement hooks * Phase 4: Add YNAB5 payee location import support * Extend YNAB5 types to include location data from payees * Implement location import logic in YNAB5 importer * Phase 5: Add unit of measurement support * Add unit of measurement preference setting in Format.tsx * Implement distance formatting utilities for imperial/metric units * Add useUnitOfMeasurementFormat hook for accessing preferences * Required release note about the PR * Update VRT screenshots Auto-generated by VRT workflow PR: #6157 * Actually get syncing working This was not obvious to me, esp. with 13 years of data, but the locations I've been inserting were local only. Everything appeared to work. What I failed to notice is that the locations did not sync across devices. Of course all the location data that was imported worked fine, but nothing new unless it was created on device. This changes the schema and uses the proper insert/delete methods such that syncing works. * Remove unit of measurement preference Display feet and meters automatically, and don't bother to format based on miles/kilometers. * Add payeeLocations feature flag Place the location permissions check and thus user-facing functionality behind the feature flag * Missed adding tombstone to payee location query * Adjust migration name to pass CI Adjust the indexes as well * Unify location.ts If CodeRabbit complains again, reply that we are actively choosing a unified file * Add bounds testing The validation is straightforward range-checking — if it's wrong, it'll be obvious quickly. Unless there's a plan to start adding broader test coverage for that file, I'd leave it untested for now * Prefer camelCase for the method params * Fix the nested interactive containers * Fix the majority of CodeRabbit nits The remainder seem to not be related to my code change (just a lint), outdated (sql migration comment), or infeasible (sql haversine query) * More CodeRabbit nits * Revert unnecessary YNAB5 zip import Turns out the payee_locations were inside the exported budget all along! * Additional guards and other CR fixes * Match the pattern used elsewhere in file * YNAB5.Budget -> Budget Missed in the merge conflict * ci: trigger rerun * Change import from fetch to connection module * Correct invalid border property Ah. I never noticed this property wasn't working. I guess the button looked OK to me! * Only hide the button on success * Update packages/loot-core/src/shared/location-utils.ts Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> * Update packages/loot-core/src/server/payees/app.ts Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> * Fully fix typo Guess I shouldn't commit a suggestion after waking up * Attempting to address feedback Manual select nearby payee and save payee location buttons to make the UX more obvi * Remove stale file that was moved * Additional cleanup of remnant change Removed the references to location from a few existing entities * Additional cleanup of remnant change * Show the Nearby payees button even when the field is disabled If there are nearby payees, there's not a payee already selected, and the save button isn't needed * runQuery is not async * Add mockNearbyPayeesResult to test Trying to utilize the real type in the mock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
104 B
104 B
category, authors
| category | authors | |
|---|---|---|
| Features |
|
MVP for payee locations support, including YNAB5 import