mirror of
https://github.com/actualbudget/actual.git
synced 2026-04-28 18:40:34 -05:00
461132b95e
Updates to the latest version of electron and moves the backend-frontend communication from node-ipc to websockets. This resolves the previous roadblock regarding `nodeIntegration` . Done - Remove node-ipc in favour of websockets. - Move file copying out of `preload.js` to avoid importing module `fs` there - Bump all electron pacakge versions to the latest - Added new package for finding open ports as node-ipc is gone - Tweaked webpack config for above changes Partially fixes #468 Questions/ Pending: - Literally every single test fails for me, presumably some issue with my setup/environment. - The websocket communication is not using TLS. I'm not sure how to enable this, or if we even need to as its all local. - Still need to create the CI for building/deploying but I'm not sure where start in this regard as i have no exp with it. Presumably we will need to point the electron auto-updater to the github releases url's. If people are happy with this PR I will look at adding the CI before its merged. - In dev mode only, I have disabled TLS security becuase my docker container's cert is not signed. I _assume_ this will be true for other people who spin up the server on thier own hardware. Perhaps I just need to change my cert to one from letsencrypt or something... Notes. I have not touched javascript in eons so my apologies if the commit trail is a bit fragmented. I tried to keep them fairly contained and then there is a slightly gnarly final commit fixing all the linter issues... Please let me know if you want me to squash some commits etc. I initially tried to move this to web workers the same way the web app does it but this was unsuccessful. I have found no way to spin up a worker in one place (frontend/backend) and then pass this worker to the other. The electron ipc channels don't allow you to directly pass objects such as workers, everything is cloned/serialised. Passing a port number so the other end can spin up its own socket works fine. --------- Co-authored-by: Shazib Hussain <contact@shazib.com> Co-authored-by: Jed Fox <git@jedfox.com>
108 lines
2.5 KiB
Bash
Executable File
108 lines
2.5 KiB
Bash
Executable File
#!/bin/bash -e
|
|
|
|
|
|
ROOT=`dirname $0`
|
|
VERSION=""
|
|
BETA=""
|
|
RELEASE=""
|
|
RELEASE_NOTES=""
|
|
CI=${CI:-false}
|
|
|
|
cd "$ROOT/.."
|
|
|
|
POSITIONAL=()
|
|
while [[ $# -gt 0 ]]; do
|
|
key="$1"
|
|
|
|
case $key in
|
|
--version)
|
|
VERSION="$2"
|
|
shift
|
|
shift
|
|
;;
|
|
--beta)
|
|
RELEASE="beta"
|
|
shift
|
|
;;
|
|
--release)
|
|
RELEASE="production"
|
|
shift
|
|
;;
|
|
*)
|
|
POSITIONAL+=("$1")
|
|
shift
|
|
;;
|
|
esac
|
|
done
|
|
set -- "${POSITIONAL[@]}"
|
|
|
|
if [ -z "$VERSION" ] && [ -n "$RELEASE" ]; then
|
|
echo "Version is required if making a release"
|
|
exit 1
|
|
fi
|
|
|
|
if [ -n "$RELEASE" ]; then
|
|
if [ -z "$CIRCLE_TAG" ]; then
|
|
read -p "Make release: $RELEASE v$VERSION? [y/N] " -r
|
|
if [ -z "$REPLY" ] || [ "$REPLY" != "y" ]; then
|
|
exit 2
|
|
fi
|
|
fi
|
|
|
|
if [ "$RELEASE" == "production" ]; then
|
|
if [ -z "$CIRCLE_TAG" ]; then
|
|
RELEASE_NOTES=`git tag -l --format="%(contents:subject)" "$VERSION"`
|
|
else
|
|
RELEASE_NOTES=`git tag -l --format="%(contents:subject)" "$CIRCLE_TAG"`
|
|
fi
|
|
fi
|
|
|
|
PACKAGE_VERSION=`node -p -e "require('./packages/desktop-electron/package.json').version"`
|
|
if [ "$VERSION" != "$PACKAGE_VERSION" ]; then
|
|
echo "Version in desktop-electron/package.json does not match given version! ($PACKAGE_VERSION)"
|
|
exit 4
|
|
fi
|
|
fi
|
|
|
|
if [ "$OSTYPE" == "msys" ]; then
|
|
if [ $CI != true ]; then
|
|
read -s -p "Windows certificate password: " -r CSC_KEY_PASSWORD
|
|
export CSC_KEY_PASSWORD
|
|
elif [ -n "$CIRCLE_TAG" ]; then
|
|
# We only want to run this on CircleCI as Github doesn't have the CSC_KEY_PASSWORD secret set.
|
|
certutil -f -p ${CSC_KEY_PASSWORD} -importPfx ~/windows-shift-reset-llc.p12
|
|
fi
|
|
fi
|
|
|
|
yarn patch-package
|
|
|
|
yarn rebuild-electron
|
|
|
|
yarn workspace loot-core build:node
|
|
|
|
yarn workspace @actual-app/web build
|
|
|
|
yarn workspace desktop-electron update-client
|
|
|
|
(
|
|
cd packages/desktop-electron;
|
|
yarn clean;
|
|
|
|
export npm_config_better_sqlite3_binary_host="https://static.actualbudget.com/prebuild/better-sqlite3"
|
|
|
|
if [ "$RELEASE" == "production" ]; then
|
|
if [ -f ../../.secret-tokens ]; then
|
|
source ../../.secret-tokens
|
|
fi
|
|
yarn build --publish always -c.releaseInfo.releaseNotes="$RELEASE_NOTES" --arm64 --x64
|
|
|
|
echo "\nCreated release $VERSION with release notes \"$RELEASE_NOTES\""
|
|
elif [ "$RELEASE" == "beta" ]; then
|
|
yarn build --publish never --arm64 --x64
|
|
|
|
echo "\nCreated beta release $VERSION"
|
|
else
|
|
SKIP_NOTARIZATION=true yarn build --publish never --x64
|
|
fi
|
|
)
|