mirror of
https://github.com/actualbudget/actual.git
synced 2026-05-08 04:49:45 -05:00
461132b95e
Updates to the latest version of electron and moves the backend-frontend communication from node-ipc to websockets. This resolves the previous roadblock regarding `nodeIntegration` . Done - Remove node-ipc in favour of websockets. - Move file copying out of `preload.js` to avoid importing module `fs` there - Bump all electron pacakge versions to the latest - Added new package for finding open ports as node-ipc is gone - Tweaked webpack config for above changes Partially fixes #468 Questions/ Pending: - Literally every single test fails for me, presumably some issue with my setup/environment. - The websocket communication is not using TLS. I'm not sure how to enable this, or if we even need to as its all local. - Still need to create the CI for building/deploying but I'm not sure where start in this regard as i have no exp with it. Presumably we will need to point the electron auto-updater to the github releases url's. If people are happy with this PR I will look at adding the CI before its merged. - In dev mode only, I have disabled TLS security becuase my docker container's cert is not signed. I _assume_ this will be true for other people who spin up the server on thier own hardware. Perhaps I just need to change my cert to one from letsencrypt or something... Notes. I have not touched javascript in eons so my apologies if the commit trail is a bit fragmented. I tried to keep them fairly contained and then there is a slightly gnarly final commit fixing all the linter issues... Please let me know if you want me to squash some commits etc. I initially tried to move this to web workers the same way the web app does it but this was unsuccessful. I have found no way to spin up a worker in one place (frontend/backend) and then pass this worker to the other. The electron ipc channels don't allow you to directly pass objects such as workers, everything is cloned/serialised. Passing a port number so the other end can spin up its own socket works fine. --------- Co-authored-by: Shazib Hussain <contact@shazib.com> Co-authored-by: Jed Fox <git@jedfox.com>
51 lines
885 B
Bash
Executable File
51 lines
885 B
Bash
Executable File
#!/bin/bash -e
|
|
|
|
VERSION=""
|
|
|
|
POSITIONAL=()
|
|
while [[ $# -gt 0 ]]; do
|
|
key="$1"
|
|
|
|
case $key in
|
|
--version)
|
|
VERSION="$2"
|
|
shift
|
|
shift
|
|
;;
|
|
*)
|
|
POSITIONAL+=("$1")
|
|
shift
|
|
;;
|
|
esac
|
|
done
|
|
set -- "${POSITIONAL[@]}"
|
|
|
|
NOTES="$@"
|
|
|
|
if [ -z "$VERSION" ]; then
|
|
echo "--version is required";
|
|
exit 1
|
|
fi
|
|
|
|
echo "Version: $VERSION"
|
|
echo "Notes: $NOTES"
|
|
read -p "Make release? [y/N] " -r
|
|
if [ -z "$REPLY" ] || [ "$REPLY" != "y" ]; then
|
|
exit 2
|
|
fi
|
|
|
|
source ./.secret-tokens
|
|
|
|
# Tag and push to make windows and linux versions
|
|
git push origin master
|
|
git tag -a "$VERSION" -m "$NOTES"
|
|
git push origin "$VERSION"
|
|
|
|
# Make a macOS version
|
|
./bin/package-electron --release --version "$VERSION"
|
|
|
|
# TODO: browser version
|
|
|
|
# Finally, update github issues
|
|
curl -X POST -H "x-release-token: $RELEASE_TOKEN" https://actual-automoto.fly.dev/release/"$VERSION"
|