mirror of
https://github.com/actualbudget/actual.git
synced 2026-04-28 18:40:34 -05:00
* Combine bundle stats comments in PR * Refactor bundle stats comment generation to use a mapping approach for base and head stats, improving argument parsing and validation in the CI action. * Enhance size comparison workflow by adding steps to checkout the base branch and set up the environment, ensuring accurate build status checks for pull requests. * Implement size comparison job in GitHub Actions workflow, replacing the deprecated size-compare.yml. This new job downloads build stats from both the base and head branches, processes the stats files, and generates a combined comment for pull requests, enhancing visibility into bundle size changes. * Add release notes for bundle size stats update, consolidating workflow and PR comment generation. * Refactor GitHub Actions workflows by removing the deprecated size comparison job from build.yml and introducing a new size-compare.yml workflow. This new workflow enhances build status checks and ensures accurate reporting of bundle size changes for pull requests. * chore: update action versions and improve error messages in bundle stats scripts - Updated GitHub Actions to specific commit versions for `upload-artifact` and `checkout`. - Enhanced error messages in `bundle-stats-comment.mjs` and `update-bundle-stats-comment.mjs` for better clarity and consistency, replacing standard quotes with typographic quotes. * fix: standardize error messages in bundle-stats-comment.mjs - Updated error messages in `bundle-stats-comment.mjs` to remove typographic quotes for consistency and clarity.
146 lines
6.3 KiB
YAML
146 lines
6.3 KiB
YAML
name: Compare Sizes
|
|
|
|
##########################################################################################
|
|
# WARNING! This workflow uses the 'pull_request_target' event. That mans that it will #
|
|
# always run in the context of the main actualbudget/actual repo, even if the PR is from #
|
|
# a fork. This is necessary to get access to a GitHub token that can post a comment on #
|
|
# the PR. Be VERY CAREFUL about adding things to this workflow, since forks can inject #
|
|
# arbitrary code into their branch, and can pollute the artifacts we download. Arbitrary #
|
|
# code execution in this workflow could lead to a compromise of the main repo. #
|
|
##########################################################################################
|
|
# See: https://securitylab.github.com/research/github-actions-preventing-pwn-requests #
|
|
##########################################################################################
|
|
|
|
on:
|
|
pull_request_target:
|
|
paths:
|
|
- 'packages/**'
|
|
- '!packages/sync-server/**'
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
compare:
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
pull-requests: write
|
|
contents: read
|
|
steps:
|
|
- name: Checkout base branch
|
|
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
|
|
with:
|
|
ref: ${{ github.base_ref }}
|
|
- name: Set up environment
|
|
uses: ./.github/actions/setup
|
|
with:
|
|
download-translations: 'false'
|
|
|
|
- name: Wait for ${{github.base_ref}} web build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: master-web-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: web
|
|
ref: ${{github.base_ref}}
|
|
- name: Wait for ${{github.base_ref}} API build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: master-api-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: api
|
|
ref: ${{github.base_ref}}
|
|
|
|
- name: Wait for PR build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: wait-for-web-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: web
|
|
ref: ${{github.event.pull_request.head.sha}}
|
|
- name: Wait for API PR build to succeed
|
|
uses: fountainhead/action-wait-for-check@5a908a24814494009c4bb27c242ea38c93c593be # v1.2.0
|
|
id: wait-for-api-build
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
checkName: api
|
|
ref: ${{github.event.pull_request.head.sha}}
|
|
|
|
- name: Report build failure
|
|
if: steps.wait-for-web-build.outputs.conclusion == 'failure' || steps.wait-for-api-build.outputs.conclusion == 'failure'
|
|
run: |
|
|
echo "Build failed on PR branch or ${{github.base_ref}}"
|
|
exit 1
|
|
|
|
- name: Download web build artifact from ${{github.base_ref}}
|
|
uses: dawidd6/action-download-artifact@ac66b43f0e6a346234dd65d4d0c8fbb31cb316e5 # v11
|
|
id: pr-web-build
|
|
with:
|
|
branch: ${{github.base_ref}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: build-stats
|
|
path: base
|
|
- name: Download API build artifact from ${{github.base_ref}}
|
|
uses: dawidd6/action-download-artifact@ac66b43f0e6a346234dd65d4d0c8fbb31cb316e5 # v11
|
|
id: pr-api-build
|
|
with:
|
|
branch: ${{github.base_ref}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: api-build-stats
|
|
path: base
|
|
- name: Download build stats from PR
|
|
uses: dawidd6/action-download-artifact@ac66b43f0e6a346234dd65d4d0c8fbb31cb316e5 # v11
|
|
with:
|
|
pr: ${{github.event.pull_request.number}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: build-stats
|
|
path: head
|
|
allow_forks: true
|
|
- name: Download API stats from PR
|
|
uses: dawidd6/action-download-artifact@ac66b43f0e6a346234dd65d4d0c8fbb31cb316e5 # v11
|
|
with:
|
|
pr: ${{github.event.pull_request.number}}
|
|
workflow: build.yml
|
|
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
|
|
name: api-build-stats
|
|
path: head
|
|
allow_forks: true
|
|
- name: Strip content hashes from stats files
|
|
run: |
|
|
if [ -f ./head/web-stats.json ]; then
|
|
sed -i -E 's/index\.[0-9a-zA-Z_-]{8,}\./index./g' ./head/web-stats.json
|
|
sed -i -E 's/\.[0-9a-zA-Z_-]{8,}\.chunk\././g' ./head/web-stats.json
|
|
fi
|
|
if [ -f ./base/web-stats.json ]; then
|
|
sed -i -E 's/index\.[0-9a-zA-Z_-]{8,}\./index./g' ./base/web-stats.json
|
|
sed -i -E 's/\.[0-9a-zA-Z_-]{8,}\.chunk\././g' ./base/web-stats.json
|
|
fi
|
|
for file in ./head/*.json ./base/*.json; do
|
|
if [ -f "$file" ]; then
|
|
sed -i -E 's/\.[0-9a-f]{8,}\././g' "$file"
|
|
fi
|
|
done
|
|
- name: Generate combined bundle stats comment
|
|
run: |
|
|
node packages/ci-actions/bin/bundle-stats-comment.mjs \
|
|
--base desktop-client=./base/web-stats.json \
|
|
--base loot-core=./base/loot-core-stats.json \
|
|
--base api=./base/api-stats.json \
|
|
--head desktop-client=./head/web-stats.json \
|
|
--head loot-core=./head/loot-core-stats.json \
|
|
--head api=./head/api-stats.json \
|
|
--identifier combined > bundle-stats-comment.md
|
|
- name: Post combined bundle stats comment
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
GITHUB_REPOSITORY: ${{ github.repository }}
|
|
PR_NUMBER: ${{ github.event.pull_request.number }}
|
|
run: |
|
|
node packages/ci-actions/bin/update-bundle-stats-comment.mjs \
|
|
--comment-file bundle-stats-comment.md \
|
|
--identifier '<!--- bundlestats-action-comment key:combined --->'
|