mirror of
https://github.com/actualbudget/actual.git
synced 2026-04-25 11:18:24 -05:00
362d8d60e4
* [AI] Speed up and stabilize Playwright e2e tests - Serve the prebuilt browser bundle via bin/serve-build.mjs in CI to skip per-shard Vite startup; 3-shard matrix with 4 workers each. - Disable CSS animations in non-VRT runs via a fixture-level init script; bump expect timeout to 10s for AutoSizer-bound assertions. - Use page.evaluate() for React Aria button clicks and a native value setter + single input event for controlled-input fills to eliminate React Aria re-render races in createAccount and Payee/Category autocompletes. - Click the matching option directly (instead of Enter on a not-yet- highlighted list) in mobile transaction and schedule autocompletes. - FocusableAmountInput.applyText reads the DOM input value so the typed amount survives a blur that fires before React flushes the onChange state update under CPU contention. - MobileTransactionEntryPage.fillAmount waits for the outer display button (reads parent props.value) so async rules-run completes before the next fillField snapshots the transaction. - MobileNavigation dispatches nav link clicks through evaluate() to bypass Playwright's viewport-stability check against the navbar's react-spring transforms. - MobileBudgetPage summary-button lookups use locator.or().waitFor() instead of an isVisible() cascade. - ConfigurationPage.startFresh/createTestFile wait for the account header / budget table to mount before returning. - Workflow hardening: persist-credentials=false on all actions/checkout and top-level permissions: contents: read (zizmor findings). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * [AI] Apply animation-disable init script to browser.newPage pages The previous implementation extended the test-scoped `page` fixture, but every test creates its own page via `browser.newPage()` and never uses the fixture-provided page — so the init script was a no-op in every test. Move the wrap to the worker-scoped `browser` fixture: intercept `browser.newPage` so each page created that way has `addInitScript` applied before the caller can navigate to it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
215 lines
7.8 KiB
YAML
215 lines
7.8 KiB
YAML
name: E2E Tests
|
|
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- 'packages/**'
|
|
- 'package.json'
|
|
- 'yarn.lock'
|
|
- '.github/workflows/e2e-test.yml'
|
|
- '!packages/sync-server/**' # Sync server changes don't affect E2E tests
|
|
- '!packages/api/**' # API changes don't affect E2E tests
|
|
- '!packages/ci-actions/**' # CI actions changes don't affect E2E tests
|
|
- '!packages/docs/**' # Docs changes don't affect E2E tests
|
|
- '!packages/eslint-plugin-actual/**' # Eslint plugin changes don't affect E2E tests
|
|
merge_group:
|
|
|
|
env:
|
|
GITHUB_PR_NUMBER: ${{github.event.pull_request.number}}
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
build-web:
|
|
name: Build web bundle
|
|
runs-on: ubuntu-latest
|
|
container:
|
|
image: mcr.microsoft.com/playwright:v1.59.1-jammy
|
|
steps:
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
with:
|
|
persist-credentials: false
|
|
- name: Set up environment
|
|
uses: ./.github/actions/setup
|
|
with:
|
|
download-translations: 'false'
|
|
- name: Trust the repository directory
|
|
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
|
|
- name: Build browser bundle
|
|
# REACT_APP_NETLIFY=true flips isNonProductionEnvironment() on in the
|
|
# bundle so the "Create test file" button (used by every e2e beforeEach
|
|
# via ConfigurationPage.createTestFile()) is still rendered in a
|
|
# production build. Without it, e2e tests would time out waiting for
|
|
# a button that was tree-shaken out.
|
|
env:
|
|
REACT_APP_NETLIFY: 'true'
|
|
run: |
|
|
yarn workspace plugins-service build
|
|
yarn workspace @actual-app/crdt build
|
|
yarn workspace @actual-app/core build:browser
|
|
yarn workspace @actual-app/web build:browser
|
|
- name: Upload build artifact
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: desktop-client-build
|
|
path: packages/desktop-client/build/
|
|
retention-days: 1
|
|
overwrite: true
|
|
|
|
functional:
|
|
name: Functional (shard ${{ matrix.shard }}/3)
|
|
runs-on: ubuntu-latest
|
|
needs: build-web
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
shard: [1, 2, 3]
|
|
container:
|
|
image: mcr.microsoft.com/playwright:v1.59.1-jammy
|
|
env:
|
|
E2E_USE_BUILD: '1'
|
|
steps:
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
with:
|
|
persist-credentials: false
|
|
- name: Set up environment
|
|
uses: ./.github/actions/setup
|
|
with:
|
|
download-translations: 'false'
|
|
- name: Trust the repository directory
|
|
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
|
|
- name: Download web build
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
|
|
with:
|
|
name: desktop-client-build
|
|
path: packages/desktop-client/build/
|
|
- name: Run E2E Tests
|
|
run: yarn e2e --shard=${{ matrix.shard }}/3
|
|
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
if: failure()
|
|
with:
|
|
name: desktop-client-test-results-shard-${{ matrix.shard }}
|
|
path: packages/desktop-client/test-results/
|
|
retention-days: 30
|
|
overwrite: true
|
|
|
|
functional-desktop-app:
|
|
name: Functional Desktop App
|
|
runs-on: ubuntu-latest
|
|
container:
|
|
image: mcr.microsoft.com/playwright:v1.59.1-jammy
|
|
steps:
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
with:
|
|
persist-credentials: false
|
|
- name: Set up environment
|
|
uses: ./.github/actions/setup
|
|
with:
|
|
download-translations: 'false'
|
|
- name: Trust the repository directory
|
|
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
|
|
|
|
# Build tools are needed to rebuild native modules like better-sqlite3 used by the Desktop app, which is required to run E2E tests on the Desktop app.
|
|
- name: Install build tools
|
|
run: apt-get update && apt-get install -y build-essential python3
|
|
|
|
- name: Run Desktop app E2E Tests
|
|
run: |
|
|
yarn rebuild-electron
|
|
xvfb-run --auto-servernum --server-args="-screen 0 1920x1080x24" -- yarn e2e:desktop
|
|
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
if: always()
|
|
with:
|
|
name: desktop-app-test-results
|
|
path: packages/desktop-electron/e2e/test-results/
|
|
retention-days: 30
|
|
overwrite: true
|
|
|
|
vrt:
|
|
name: Visual regression (shard ${{ matrix.shard }}/3)
|
|
runs-on: ubuntu-latest
|
|
needs: build-web
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
shard: [1, 2, 3]
|
|
container:
|
|
image: mcr.microsoft.com/playwright:v1.59.1-jammy
|
|
env:
|
|
E2E_USE_BUILD: '1'
|
|
steps:
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
with:
|
|
persist-credentials: false
|
|
- name: Set up environment
|
|
uses: ./.github/actions/setup
|
|
with:
|
|
download-translations: 'false'
|
|
- name: Trust the repository directory
|
|
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
|
|
- name: Download web build
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
|
|
with:
|
|
name: desktop-client-build
|
|
path: packages/desktop-client/build/
|
|
- name: Run VRT Tests
|
|
run: yarn vrt --shard=${{ matrix.shard }}/3
|
|
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
if: always()
|
|
with:
|
|
name: vrt-blob-report-${{ matrix.shard }}
|
|
path: packages/desktop-client/blob-report/
|
|
retention-days: 1
|
|
overwrite: true
|
|
|
|
merge-vrt:
|
|
name: Merge VRT Reports
|
|
needs: vrt
|
|
runs-on: ubuntu-latest
|
|
if: ${{ !cancelled() }}
|
|
container:
|
|
image: mcr.microsoft.com/playwright:v1.59.1-jammy
|
|
steps:
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
with:
|
|
persist-credentials: false
|
|
- name: Set up environment
|
|
uses: ./.github/actions/setup
|
|
- name: Download all blob reports
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
|
|
with:
|
|
path: packages/desktop-client/all-blob-reports
|
|
pattern: vrt-blob-report-*
|
|
merge-multiple: true
|
|
- name: Merge reports
|
|
id: merge-reports
|
|
run: yarn workspace @actual-app/web run playwright merge-reports --reporter html ./all-blob-reports
|
|
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
id: playwright-report-vrt
|
|
with:
|
|
name: html-report--attempt-${{ github.run_attempt }}
|
|
path: packages/desktop-client/playwright-report
|
|
retention-days: 30
|
|
overwrite: true
|
|
- name: Save VRT metadata for comment workflow
|
|
if: github.event_name == 'pull_request'
|
|
run: |
|
|
mkdir -p vrt-metadata
|
|
echo "${{ github.event.pull_request.number }}" > vrt-metadata/pr-number.txt
|
|
echo "${{ needs.vrt.result }}" > vrt-metadata/vrt-result.txt
|
|
echo "${STEPS_PLAYWRIGHT_REPORT_VRT_OUTPUTS_ARTIFACT_URL}" > vrt-metadata/artifact-url.txt
|
|
env:
|
|
STEPS_PLAYWRIGHT_REPORT_VRT_OUTPUTS_ARTIFACT_URL: ${{ steps.playwright-report-vrt.outputs.artifact-url }}
|
|
- name: Upload VRT metadata
|
|
if: github.event_name == 'pull_request'
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: vrt-comment-metadata
|
|
path: vrt-metadata/
|
|
retention-days: 1
|