mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-15 14:43:36 -05:00
541caba5b7
* fix: add scoped ErrorBoundaries to mobile budget, account and transaction pages
Wrap the mobile BudgetPage, AccountPage and TransactionEdit in
<ErrorBoundary FallbackComponent={FeatureErrorFallback}> so a rendering
error in one of these pages is contained instead of crashing the whole app.
Relates to #7391
* [autofix.ci] apply automated fixes
* fix(desktop-client): enclose mobile page hooks within scoped ErrorBoundary
The scoped ErrorBoundary added for the mobile budget, account, and
transaction-edit pages only wrapped the returned JSX, so errors thrown by
the pages' own hooks and initialization logic (data loading, useEffect)
still escaped to the global fatal screen, defeating the boundary.
Move each page's body into a child component rendered inside the boundary
so the boundary encloses the full hook/render path, and add resetKeys so
the feature recovers when the account (accountIdParam) or month
(startMonth) changes.
Addresses CodeRabbit review feedback on the mobile error-boundary PR.
* refactor(desktop-client): remove prose comments from mobile error boundaries
Drop the explanatory comments added with the scoped error boundaries on the
mobile account, budget, and transaction edit pages, per maintainer review
feedback. The code is self-explanatory without them; behavior is unchanged.
* refactor(desktop-client): move mobile error boundaries to the route level
Wrap the mobile budget, account, and transaction edit routes in FinancesApp
with the same ErrorBoundary/FeatureErrorFallback pattern already used for the
/rules routes, instead of splitting each page into a wrapper and inner
component. Each page renders as a child of the boundary, so its hooks and
initialization logic are still enclosed, and the page components are left
unchanged.
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
211 B
211 B
category, authors
| category | authors | |
|---|---|---|
| Maintenance |
|
Add scoped error boundaries around the mobile budget, account, and transaction edit pages so a rendering error in one of them no longer crashes the entire app.