github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 11:59:55 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7904] [MERGED] convert GoCardless sync-server code to Typescript #97381

New Issue
Closed
opened 2026-05-26 14:25:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-26 14:25:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7904
Author: @matt-fidd
Created: 5/19/2026
Status: ✅ Merged
Merged: 5/21/2026
Merged by: @matt-fidd

Base: master ← Head: typescript/gc-banks

📝 Commits (6)

📊 Changes

87 files changed (+691 additions, -551 deletions)

View changed files

📝 .oxlintrc.json (+1 -1)
📝 packages/sync-server/src/app-gocardless/app-gocardless.ts (+52 -20)
➖ packages/sync-server/src/app-gocardless/bank-factory.js (+0 -13)
➕ packages/sync-server/src/app-gocardless/bank-factory.ts (+19 -0)
📝 packages/sync-server/src/app-gocardless/banks/abanca_caglesmm.ts (+2 -2)
📝 packages/sync-server/src/app-gocardless/banks/abnamro_abnanl2a.ts (+11 -9)
📝 packages/sync-server/src/app-gocardless/banks/american_express_aesudef1.ts (+9 -6)
📝 packages/sync-server/src/app-gocardless/banks/bancsabadell_bsabesbbb.ts (+5 -8)
📝 packages/sync-server/src/app-gocardless/banks/bank.interface.ts (+9 -1)
📝 packages/sync-server/src/app-gocardless/banks/bank_of_ireland_b365_bofiie2d.ts (+4 -4)
📝 packages/sync-server/src/app-gocardless/banks/bankinter_bkbkesmm.ts (+7 -6)
📝 packages/sync-server/src/app-gocardless/banks/belfius_gkccbebb.ts (+2 -2)
📝 packages/sync-server/src/app-gocardless/banks/berliner_sparkasse_beladebexxx.ts (+11 -6)
📝 packages/sync-server/src/app-gocardless/banks/bnp_be_gebabebb.ts (+7 -7)
📝 packages/sync-server/src/app-gocardless/banks/boursobank_bousfrppxxx.ts (+14 -13)
📝 packages/sync-server/src/app-gocardless/banks/bper_retail_bpmoit22.ts (+9 -7)
📝 packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.ts (+3 -3)
📝 packages/sync-server/src/app-gocardless/banks/cetelem_cetmptp1xxx.ts (+2 -2)
📝 packages/sync-server/src/app-gocardless/banks/commerzbank_cobadeff.ts (+12 -10)
📝 packages/sync-server/src/app-gocardless/banks/danskebank_privat.ts (+11 -10)

...and 67 more files

📄 Description

Description

Following the new build process, typescript is easier in sync-server. This follows on from my work rolling our own service.

Related issue(s)

Testing

Built, typecheck, all works as before

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7904 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 5/19/2026 **Status:** ✅ Merged **Merged:** 5/21/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `typescript/gc-banks` --- ### 📝 Commits (6) - [`74ea2ea`](https://github.com/actualbudget/actual/commit/74ea2eaecbcdaa28cd6a5ba62199837ec7062a60) ts migration - [`b79e399`](https://github.com/actualbudget/actual/commit/b79e399035e5cee11fee4ecc627e2c2fe91c2831) strict mode in tests - [`0eb6438`](https://github.com/actualbudget/actual/commit/0eb643824e7a86d3d8d4f509618d58c7186f06cc) banks strict - [`a127914`](https://github.com/actualbudget/actual/commit/a12791407b901abf40f7b64a05ee602fa291f2e1) helper/util files strict - [`9e5f20e`](https://github.com/actualbudget/actual/commit/9e5f20ea322b857e9a9151cb5a10d67f49dcd7a1) note - [`af01613`](https://github.com/actualbudget/actual/commit/af01613be3fa46bd8d823b790e71931fcf785bfd) coderabbit ### 📊 Changes **87 files changed** (+691 additions, -551 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+1 -1) 📝 `packages/sync-server/src/app-gocardless/app-gocardless.ts` (+52 -20) ➖ `packages/sync-server/src/app-gocardless/bank-factory.js` (+0 -13) ➕ `packages/sync-server/src/app-gocardless/bank-factory.ts` (+19 -0) 📝 `packages/sync-server/src/app-gocardless/banks/abanca_caglesmm.ts` (+2 -2) 📝 `packages/sync-server/src/app-gocardless/banks/abnamro_abnanl2a.ts` (+11 -9) 📝 `packages/sync-server/src/app-gocardless/banks/american_express_aesudef1.ts` (+9 -6) 📝 `packages/sync-server/src/app-gocardless/banks/bancsabadell_bsabesbbb.ts` (+5 -8) 📝 `packages/sync-server/src/app-gocardless/banks/bank.interface.ts` (+9 -1) 📝 `packages/sync-server/src/app-gocardless/banks/bank_of_ireland_b365_bofiie2d.ts` (+4 -4) 📝 `packages/sync-server/src/app-gocardless/banks/bankinter_bkbkesmm.ts` (+7 -6) 📝 `packages/sync-server/src/app-gocardless/banks/belfius_gkccbebb.ts` (+2 -2) 📝 `packages/sync-server/src/app-gocardless/banks/berliner_sparkasse_beladebexxx.ts` (+11 -6) 📝 `packages/sync-server/src/app-gocardless/banks/bnp_be_gebabebb.ts` (+7 -7) 📝 `packages/sync-server/src/app-gocardless/banks/boursobank_bousfrppxxx.ts` (+14 -13) 📝 `packages/sync-server/src/app-gocardless/banks/bper_retail_bpmoit22.ts` (+9 -7) 📝 `packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.ts` (+3 -3) 📝 `packages/sync-server/src/app-gocardless/banks/cetelem_cetmptp1xxx.ts` (+2 -2) 📝 `packages/sync-server/src/app-gocardless/banks/commerzbank_cobadeff.ts` (+12 -10) 📝 `packages/sync-server/src/app-gocardless/banks/danskebank_privat.ts` (+11 -10) _...and 67 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://actualbudget.org/docs/contributing/#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> Following the new build process, typescript is easier in sync-server. This follows on from my work rolling our own service. ## Related issue(s) <!-- e.g. Fixes #123, Relates to #456 --> ## Testing <!-- What did you test? How can we reproduce the issue you are fixing or how can we test the feature you built? --> Built, typecheck, all works as before ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-26 14:25:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#97381
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?