github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 11:59:55 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7848] Improve Tag Filter UX #97334

New Issue
Open
opened 2026-05-26 14:18:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-26 14:18:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7848
Author: @alecbakholdin
Created: 5/15/2026
Status: 🔄 Open

Base: master ← Head: filter-tags-without-hashes

📝 Commits (10+)

  • a0b483a [AI] Make TypeScript work in test files across packages
  • 909649f [AI] Address review feedback on test type fixes
  • c250762 [AI] Drop tsconfig.build.json for loot-core and api
  • a792bf4 first pass at implementation
  • 20f6134 finished implementing what I feel would be a good user experience
  • dff8874 padding update
  • c2a7838 added ability to use tab to select
  • c1cfc17 release notes
  • 3dab7fc updated release notes
  • 4c5c470 auto highlights first entry

📊 Changes

17 files changed (+378 additions, -31 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+12 -1)
➕ packages/desktop-client/src/components/autocomplete/TagMultiAutocomplete.tsx (+95 -0)
📝 packages/desktop-client/src/components/filters/FilterExpression.tsx (+2 -1)
📝 packages/desktop-client/src/components/filters/FiltersMenu.tsx (+11 -4)
📝 packages/desktop-client/src/components/filters/updateFilterReducer.ts (+1 -0)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+7 -1)
📝 packages/desktop-client/src/components/rules/RuleEditor.tsx (+16 -1)
📝 packages/desktop-client/src/hooks/useTags.ts (+14 -0)
📝 packages/loot-core/src/server/rules/condition.ts (+29 -3)
📝 packages/loot-core/src/server/rules/rule-utils.ts (+1 -0)
📝 packages/loot-core/src/server/transactions/transaction-rules.test.ts (+134 -7)
📝 packages/loot-core/src/server/transactions/transaction-rules.ts (+19 -10)
📝 packages/loot-core/src/shared/rules.test.ts (+2 -0)
📝 packages/loot-core/src/shared/rules.ts (+5 -2)
➕ packages/loot-core/src/shared/tags.ts (+17 -0)
📝 packages/loot-core/src/types/models/rule.ts (+7 -1)
➕ upcoming-release-notes/7848.md (+6 -0)

📄 Description

Description

This PR improves the UX for tag filtering by introducing a multi-select for tags, much like the "one of" field for categories/payees/accounts.

image

Related issue(s)

Resolves #7798
Resolves #7797

Testing

Tested filtering in transactions table, rules, and reports

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 33 14.01 MB → 14.01 MB (+5.48 kB) +0.04%
loot-core 1 5.34 MB → 5.34 MB (+1.18 kB) +0.02%
api 2 3.96 MB → 3.96 MB (+1.16 kB) +0.03%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
33 14.01 MB → 14.01 MB (+5.48 kB) +0.04%
Changeset
File Δ Size
src/components/autocomplete/TagMultiAutocomplete.tsx 🆕 +2.87 kB 0 B → 2.87 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/tags.ts 🆕 +403 B 0 B → 403 B
src/hooks/useTags.ts 📈 +214 B (+34.13%) 627 B → 841 B
home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts 📈 +649 B (+8.15%) 7.78 kB → 8.41 kB
src/components/filters/updateFilterReducer.ts 📈 +29 B (+2.53%) 1.12 kB → 1.15 kB
src/components/autocomplete/Autocomplete.tsx 📈 +376 B (+1.54%) 23.89 kB → 24.25 kB
src/components/filters/FiltersMenu.tsx 📈 +318 B (+1.43%) 21.67 kB → 21.99 kB
src/components/rules/RuleEditor.tsx 📈 +566 B (+1.17%) 47.25 kB → 47.8 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts 📈 +80 B (+1.09%) 7.17 kB → 7.24 kB
src/components/filters/FilterExpression.tsx 📈 +22 B (+0.38%) 5.73 kB → 5.75 kB
src/components/reports/reports/CustomReport.tsx 📈 +15 B (+0.04%) 41.84 kB → 41.85 kB
src/components/budget/envelope/EnvelopeBudgetComponents.tsx 📈 +2 B (+0.01%) 28.41 kB → 28.41 kB
src/components/table.tsx 📈 +2 B (+0.01%) 38.37 kB → 38.37 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/Value.js 5.08 MB → 5.09 MB (+5.1 kB) +0.10%
static/js/chart-theme.js 800.6 kB → 800.96 kB (+369 B) +0.05%
static/js/ReportRouter.js 1.26 MB → 1.26 MB (+15 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 2.02 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ScheduleEditForm.js 146.45 kB 0%
static/js/TransactionEdit.js 89.65 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/bankSyncUtils.js 54.15 kB 0%
static/js/ca.js 186.78 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.17 kB 0%
static/js/de.js 170.58 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 197.86 kB 0%
static/js/es.js 178.71 kB 0%
static/js/extends.js 500.57 kB 0%
static/js/fr.js 178.61 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.02 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.08 kB 0%
static/js/nl.js 106.24 kB 0%
static/js/pt-BR.js 188.46 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.48 kB 0%
static/js/theme.js 31.77 kB 0%
static/js/uk.js 207.38 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.92 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB → 5.34 MB (+1.18 kB) +0.02%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/shared/tags.ts 🆕 +416 B 0 B → 416 B
home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts 📈 +662 B (+7.84%) 8.25 kB → 8.89 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts 📈 +30 B (+1.39%) 2.1 kB → 2.13 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📈 +89 B (+0.41%) 21.09 kB → 21.17 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/rule-utils.ts 📈 +16 B (+0.34%) 4.64 kB → 4.66 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.DPd8DR61.js 0 B → 5.34 MB (+5.34 MB) -

Removed

Asset File Size % Changed
kcab.worker.Cn6Jnyv4.js 5.34 MB → 0 B (-5.34 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
2 3.96 MB → 3.96 MB (+1.16 kB) +0.03%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/shared/tags.ts 🆕 +403 B 0 B → 403 B
home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts 📈 +649 B (+8.16%) 7.77 kB → 8.41 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts 📈 +29 B (+1.42%) 2 kB → 2.03 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📈 +90 B (+0.43%) 20.57 kB → 20.66 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/rule-utils.ts 📈 +15 B (+0.33%) 4.47 kB → 4.49 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.96 MB → 3.96 MB (+1.16 kB) +0.03%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7848 **Author:** [@alecbakholdin](https://github.com/alecbakholdin) **Created:** 5/15/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `filter-tags-without-hashes` --- ### 📝 Commits (10+) - [`a0b483a`](https://github.com/actualbudget/actual/commit/a0b483a1d842f856e2e7acc3d1397b2c7059f18f) [AI] Make TypeScript work in test files across packages - [`909649f`](https://github.com/actualbudget/actual/commit/909649f05f7df48869e3daa0fee34df194543b60) [AI] Address review feedback on test type fixes - [`c250762`](https://github.com/actualbudget/actual/commit/c2507621dc1f9c4ba89865ca318fa1757c192791) [AI] Drop tsconfig.build.json for loot-core and api - [`a792bf4`](https://github.com/actualbudget/actual/commit/a792bf4ebe36699e78d8c1ce8acc54ef31bed22a) first pass at implementation - [`20f6134`](https://github.com/actualbudget/actual/commit/20f6134788dec9cea0eecdfc1ea87b73e0e9463e) finished implementing what I feel would be a good user experience - [`dff8874`](https://github.com/actualbudget/actual/commit/dff8874d99d78a2cfbd0fc1507824be599f7e251) padding update - [`c2a7838`](https://github.com/actualbudget/actual/commit/c2a7838418e9046f96d60a84f5848acb13fc2900) added ability to use tab to select - [`c1cfc17`](https://github.com/actualbudget/actual/commit/c1cfc174c098d2723adbbac76936e69a55ac1dfd) release notes - [`3dab7fc`](https://github.com/actualbudget/actual/commit/3dab7fc9450aa5e25ecf7f3e6d7040fa349a2e0e) updated release notes - [`4c5c470`](https://github.com/actualbudget/actual/commit/4c5c4703667d64ecf6c8ca2d388ae19c8649a0a9) auto highlights first entry ### 📊 Changes **17 files changed** (+378 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+12 -1) ➕ `packages/desktop-client/src/components/autocomplete/TagMultiAutocomplete.tsx` (+95 -0) 📝 `packages/desktop-client/src/components/filters/FilterExpression.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.tsx` (+11 -4) 📝 `packages/desktop-client/src/components/filters/updateFilterReducer.ts` (+1 -0) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+7 -1) 📝 `packages/desktop-client/src/components/rules/RuleEditor.tsx` (+16 -1) 📝 `packages/desktop-client/src/hooks/useTags.ts` (+14 -0) 📝 `packages/loot-core/src/server/rules/condition.ts` (+29 -3) 📝 `packages/loot-core/src/server/rules/rule-utils.ts` (+1 -0) 📝 `packages/loot-core/src/server/transactions/transaction-rules.test.ts` (+134 -7) 📝 `packages/loot-core/src/server/transactions/transaction-rules.ts` (+19 -10) 📝 `packages/loot-core/src/shared/rules.test.ts` (+2 -0) 📝 `packages/loot-core/src/shared/rules.ts` (+5 -2) ➕ `packages/loot-core/src/shared/tags.ts` (+17 -0) 📝 `packages/loot-core/src/types/models/rule.ts` (+7 -1) ➕ `upcoming-release-notes/7848.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://actualbudget.org/docs/contributing/#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description This PR improves the UX for tag filtering by introducing a multi-select for tags, much like the "one of" field for categories/payees/accounts. <img width="309" height="403" alt="image" src="https://github.com/user-attachments/assets/67b5fff4-03da-4517-b695-8fc21ad2a262" /> ## Related issue(s) Resolves #7798 Resolves #7797 ## Testing Tested filtering in transactions table, rules, and reports ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 33 | 14.01 MB → 14.01 MB (+5.48 kB) | +0.04% loot-core | 1 | 5.34 MB → 5.34 MB (+1.18 kB) | +0.02% api | 2 | 3.96 MB → 3.96 MB (+1.16 kB) | +0.03% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 33 | 14.01 MB → 14.01 MB (+5.48 kB) | +0.04% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/autocomplete/TagMultiAutocomplete.tsx` | 🆕 +2.87 kB | 0 B → 2.87 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/tags.ts` | 🆕 +403 B | 0 B → 403 B `src/hooks/useTags.ts` | 📈 +214 B (+34.13%) | 627 B → 841 B `home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts` | 📈 +649 B (+8.15%) | 7.78 kB → 8.41 kB `src/components/filters/updateFilterReducer.ts` | 📈 +29 B (+2.53%) | 1.12 kB → 1.15 kB `src/components/autocomplete/Autocomplete.tsx` | 📈 +376 B (+1.54%) | 23.89 kB → 24.25 kB `src/components/filters/FiltersMenu.tsx` | 📈 +318 B (+1.43%) | 21.67 kB → 21.99 kB `src/components/rules/RuleEditor.tsx` | 📈 +566 B (+1.17%) | 47.25 kB → 47.8 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts` | 📈 +80 B (+1.09%) | 7.17 kB → 7.24 kB `src/components/filters/FilterExpression.tsx` | 📈 +22 B (+0.38%) | 5.73 kB → 5.75 kB `src/components/reports/reports/CustomReport.tsx` | 📈 +15 B (+0.04%) | 41.84 kB → 41.85 kB `src/components/budget/envelope/EnvelopeBudgetComponents.tsx` | 📈 +2 B (+0.01%) | 28.41 kB → 28.41 kB `src/components/table.tsx` | 📈 +2 B (+0.01%) | 38.37 kB → 38.37 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/Value.js | 5.08 MB → 5.09 MB (+5.1 kB) | +0.10% static/js/chart-theme.js | 800.6 kB → 800.96 kB (+369 B) | +0.05% static/js/ReportRouter.js | 1.26 MB → 1.26 MB (+15 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 2.02 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/TransactionEdit.js | 89.65 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/bankSyncUtils.js | 54.15 kB | 0% static/js/ca.js | 186.78 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.17 kB | 0% static/js/de.js | 170.58 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 197.86 kB | 0% static/js/es.js | 178.71 kB | 0% static/js/extends.js | 500.57 kB | 0% static/js/fr.js | 178.61 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.02 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.08 kB | 0% static/js/nl.js | 106.24 kB | 0% static/js/pt-BR.js | 188.46 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/theme.js | 31.77 kB | 0% static/js/uk.js | 207.38 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.92 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB → 5.34 MB (+1.18 kB) | +0.02% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/tags.ts` | 🆕 +416 B | 0 B → 416 B `home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts` | 📈 +662 B (+7.84%) | 8.25 kB → 8.89 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts` | 📈 +30 B (+1.39%) | 2.1 kB → 2.13 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📈 +89 B (+0.41%) | 21.09 kB → 21.17 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/rule-utils.ts` | 📈 +16 B (+0.34%) | 4.64 kB → 4.66 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DPd8DR61.js | 0 B → 5.34 MB (+5.34 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Cn6Jnyv4.js | 5.34 MB → 0 B (-5.34 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.96 MB → 3.96 MB (+1.16 kB) | +0.03% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/tags.ts` | 🆕 +403 B | 0 B → 403 B `home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts` | 📈 +649 B (+8.16%) | 7.77 kB → 8.41 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts` | 📈 +29 B (+1.42%) | 2 kB → 2.03 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📈 +90 B (+0.43%) | 20.57 kB → 20.66 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/rule-utils.ts` | 📈 +15 B (+0.33%) | 4.47 kB → 4.49 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.96 MB → 3.96 MB (+1.16 kB) | +0.03% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-26 14:18:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#97334
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?