github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7707] [MERGED] fix: only count failed attempts against auth rate limit #97235

New Issue
Closed
opened 2026-05-26 14:03:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-26 14:03:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7707
Author: @danielhopkins
Created: 5/4/2026
Status: ✅ Merged
Merged: 5/4/2026
Merged by: @matt-fidd

Base: master ← Head: fix/auth-rate-limit-skip-successful

📝 Commits (3)

  • d499451 fix: only count failed attempts against auth rate limit
  • 9808729 Update upcoming-release-notes/7706.md
  • fd1af9b fix: rename release note to match PR number

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 packages/sync-server/src/app-account.js (+1 -0)
➕ upcoming-release-notes/7707.md (+6 -0)

📄 Description

Description

Adds skipSuccessfulRequests: true to authRateLimiter in app-account.js.

With this change, only failed login attempts consume rate limit quota. Successful logins (correct password) do not count. This preserves full brute-force protection — attackers generating repeated failures still hit the wall — while fixing breakage for legitimate API clients that re-authenticate per operation.

Related issue(s)

Fixes #7706

Testing

Existing unit tests cover the rate-limiting behaviour. The authRateLimiter.resetKey pattern in the test suite is compatible with this change — successful requests simply won't increment the counter.

Checklist

  • Release notes added
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7707 **Author:** [@danielhopkins](https://github.com/danielhopkins) **Created:** 5/4/2026 **Status:** ✅ Merged **Merged:** 5/4/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix/auth-rate-limit-skip-successful` --- ### 📝 Commits (3) - [`d499451`](https://github.com/actualbudget/actual/commit/d49945145b681709e5bd369e6038910da7a2358a) fix: only count failed attempts against auth rate limit - [`9808729`](https://github.com/actualbudget/actual/commit/9808729326048605aa048b833e0b6674b2b5a98a) Update upcoming-release-notes/7706.md - [`fd1af9b`](https://github.com/actualbudget/actual/commit/fd1af9b3336e8312dd36a46856a760a493b5051b) fix: rename release note to match PR number ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/src/app-account.js` (+1 -0) ➕ `upcoming-release-notes/7707.md` (+6 -0) </details> ### 📄 Description ## Description Adds `skipSuccessfulRequests: true` to `authRateLimiter` in `app-account.js`. With this change, only **failed** login attempts consume rate limit quota. Successful logins (correct password) do not count. This preserves full brute-force protection — attackers generating repeated failures still hit the wall — while fixing breakage for legitimate API clients that re-authenticate per operation. ## Related issue(s) Fixes #7706 ## Testing Existing unit tests cover the rate-limiting behaviour. The `authRateLimiter.resetKey` pattern in the test suite is compatible with this change — successful requests simply won't increment the counter. ## Checklist - [x] Release notes added - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-26 14:03:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#97235
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?