github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7038] [MERGED] Adding Concentric Donut Pie Chart type to custom report charts #96793

New Issue
Closed
opened 2026-05-26 13:09:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-26 13:09:03 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7038
Author: @karimkodera
Created: 2/20/2026
Status: ✅ Merged
Merged: 3/17/2026
Merged by: @youngcw

Base: master ← Head: Group-Category-Donut-Graph

📝 Commits (10+)

  • 575cc5a Initial commit for concentric donut chart implementation
  • 4e875de [autofix.ci] apply automated fixes
  • ba9a02f Merge branch 'master' into Group-Category-Donut-Graph
  • 6c1b6a8 Update upcoming-release-notes/7038.md
  • 503ebe8 Fix coderabbit comments (Recalculated total to avoid hidden cats, remove tooltip, add proper types)
  • d66cb3e Update packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx
  • 4c59fa7 Merge branch 'master' into Group-Category-Donut-Graph
  • 46a474e Fix zero total group
  • 757bf3a lint issues fix
  • 7143001 Fix lint issues

📊 Changes

8 files changed (+504 additions, -119 deletions)

View changed files

📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/reports/ReportOptions.ts (+16 -9)
📝 packages/desktop-client/src/components/reports/disabledList.ts (+14 -6)
📝 packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx (+459 -102)
📝 packages/desktop-client/src/components/reports/graphs/showActivity.ts (+9 -2)
➕ upcoming-release-notes/7038.md (+6 -0)

📄 Description

Minimal implemenation to add concentric donut chart to custom report.

Go to custom reports - select donut - select category+group (new entry)

Selection disable for all other reports types
concentric report
CONCETRIC 2

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 26 11.83 MB → 11.84 MB (+9.23 kB) +0.08%
loot-core 1 4.83 MB 0%
api 4 4.05 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
26 11.83 MB → 11.84 MB (+9.23 kB) +0.08%
Changeset
File Δ Size
src/components/reports/graphs/DonutGraph.tsx 📈 +8.82 kB (+66.37%) 13.28 kB → 22.1 kB
src/components/reports/ReportOptions.ts 📈 +293 B (+4.27%) 6.7 kB → 6.99 kB
src/components/reports/disabledList.ts 📈 +102 B (+2.60%) 3.83 kB → 3.93 kB
src/components/reports/graphs/showActivity.ts 📈 +30 B (+1.74%) 1.68 kB → 1.71 kB
src/components/reports/reports/BudgetAnalysis.tsx 📈 +2 B (+0.01%) 19 kB → 19 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1012.02 kB → 1021.25 kB (+9.23 kB) +0.91%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 3.22 MB 0%
static/js/BackgroundImage.js 119.98 kB 0%
static/js/FormulaEditor.js 720.12 kB 0%
static/js/TransactionList.js 81.29 kB 0%
static/js/ca.js 185.62 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 177.63 kB 0%
static/js/en-GB.js 7.16 kB 0%
static/js/en.js 169.27 kB 0%
static/js/es.js 172.13 kB 0%
static/js/fr.js 177.63 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 168.97 kB 0%
static/js/narrow.js 353.47 kB 0%
static/js/nb-NO.js 154.72 kB 0%
static/js/nl.js 111.58 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 180.55 kB 0%
static/js/resize-observer.js 18.03 kB 0%
static/js/th.js 179.94 kB 0%
static/js/theme.js 30.68 kB 0%
static/js/uk.js 213.14 kB 0%
static/js/useTransactionBatchActions.js 4.27 MB 0%
static/js/wide.js 418 B 0%
static/js/workbox-window.prod.es5.js 7.28 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.83 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.5n1gnplM.js 4.83 MB 0%

api

Total

Files count Total bundle size % Changed
4 4.05 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.84 MB 0%
from-Bl-Hslp4.js 167.73 kB 0%
multipart-parser-BnDysoMr.js 8.1 kB 0%
src-iMkUmuwR.js 43.64 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7038 **Author:** [@karimkodera](https://github.com/karimkodera) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 3/17/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `Group-Category-Donut-Graph` --- ### 📝 Commits (10+) - [`575cc5a`](https://github.com/actualbudget/actual/commit/575cc5aebbe2b52872429a114091b83ca25175e6) Initial commit for concentric donut chart implementation - [`4e875de`](https://github.com/actualbudget/actual/commit/4e875def92f1a5b1ea774e10d99cf9cd73d327a8) [autofix.ci] apply automated fixes - [`ba9a02f`](https://github.com/actualbudget/actual/commit/ba9a02f3b8b6b308127f549f32723f0020d6b3a3) Merge branch 'master' into Group-Category-Donut-Graph - [`6c1b6a8`](https://github.com/actualbudget/actual/commit/6c1b6a806b98e77d3a329ff4d8bdfb1c2a019162) Update upcoming-release-notes/7038.md - [`503ebe8`](https://github.com/actualbudget/actual/commit/503ebe8cfa61d0458ea7e5d03d64715d53a7d8d2) Fix coderabbit comments (Recalculated total to avoid hidden cats, remove tooltip, add proper types) - [`d66cb3e`](https://github.com/actualbudget/actual/commit/d66cb3ef65851ff651332b6765d6ec3bafaf1d21) Update packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx - [`4c59fa7`](https://github.com/actualbudget/actual/commit/4c59fa7f685f10b621194982e168051fa83cf075) Merge branch 'master' into Group-Category-Donut-Graph - [`46a474e`](https://github.com/actualbudget/actual/commit/46a474e9796cace68debade0e529beee23b473fd) Fix zero total group - [`757bf3a`](https://github.com/actualbudget/actual/commit/757bf3a8b1365add792f23a84c4f6ac0d4517960) lint issues fix - [`7143001`](https://github.com/actualbudget/actual/commit/7143001c2b41bbbf54b30a4470e564fda458dd97) Fix lint issues ### 📊 Changes **8 files changed** (+504 additions, -119 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/reports/ReportOptions.ts` (+16 -9) 📝 `packages/desktop-client/src/components/reports/disabledList.ts` (+14 -6) 📝 `packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx` (+459 -102) 📝 `packages/desktop-client/src/components/reports/graphs/showActivity.ts` (+9 -2) ➕ `upcoming-release-notes/7038.md` (+6 -0) </details> ### 📄 Description Minimal implemenation to add concentric donut chart to custom report. Go to custom reports - select donut - select category+group (new entry) Selection disable for all other reports types ![concentric report](https://github.com/user-attachments/assets/f7c58922-7fdd-4612-8361-2442f99a173e) ![CONCETRIC 2](https://github.com/user-attachments/assets/1c74f192-09e2-4613-bbd8-754134dca3d5) <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 26 | 11.83 MB → 11.84 MB (+9.23 kB) | +0.08% loot-core | 1 | 4.83 MB | 0% api | 4 | 4.05 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 26 | 11.83 MB → 11.84 MB (+9.23 kB) | +0.08% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/graphs/DonutGraph.tsx` | 📈 +8.82 kB (+66.37%) | 13.28 kB → 22.1 kB `src/components/reports/ReportOptions.ts` | 📈 +293 B (+4.27%) | 6.7 kB → 6.99 kB `src/components/reports/disabledList.ts` | 📈 +102 B (+2.60%) | 3.83 kB → 3.93 kB `src/components/reports/graphs/showActivity.ts` | 📈 +30 B (+1.74%) | 1.68 kB → 1.71 kB `src/components/reports/reports/BudgetAnalysis.tsx` | 📈 +2 B (+0.01%) | 19 kB → 19 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1012.02 kB → 1021.25 kB (+9.23 kB) | +0.91% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.22 MB | 0% static/js/BackgroundImage.js | 119.98 kB | 0% static/js/FormulaEditor.js | 720.12 kB | 0% static/js/TransactionList.js | 81.29 kB | 0% static/js/ca.js | 185.62 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 177.63 kB | 0% static/js/en-GB.js | 7.16 kB | 0% static/js/en.js | 169.27 kB | 0% static/js/es.js | 172.13 kB | 0% static/js/fr.js | 177.63 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 168.97 kB | 0% static/js/narrow.js | 353.47 kB | 0% static/js/nb-NO.js | 154.72 kB | 0% static/js/nl.js | 111.58 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 180.55 kB | 0% static/js/resize-observer.js | 18.03 kB | 0% static/js/th.js | 179.94 kB | 0% static/js/theme.js | 30.68 kB | 0% static/js/uk.js | 213.14 kB | 0% static/js/useTransactionBatchActions.js | 4.27 MB | 0% static/js/wide.js | 418 B | 0% static/js/workbox-window.prod.es5.js | 7.28 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.83 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.5n1gnplM.js | 4.83 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 4 | 4.05 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.84 MB | 0% from-Bl-Hslp4.js | 167.73 kB | 0% multipart-parser-BnDysoMr.js | 8.1 kB | 0% src-iMkUmuwR.js | 43.64 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-26 13:09:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#96793