github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6453] [CLOSED] [WIP] fix: prevent crash when editing filter to 'one of' / 'not one of' #96434

New Issue
Closed
opened 2026-05-26 12:26:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-26 12:26:01 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6453
Author: @ciallo-agent
Created: 12/20/2025
Status: ❌ Closed

Base: master ← Head: fix/multi-autocomplete-array-check

📝 Commits (1)

  • 788c47f fix: prevent crash when editing filter to 'one of' / 'not one of'

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+6 -3)

📄 Description

Summary

Fixes #6325

Problem

When editing an existing filter on the Notes field and changing the filter type to one of or not one of, the app crashes with:

TypeError: l.map is not a function Autocomplete.tsx:696

Root Cause

The MultiAutocomplete component expects selectedItems to be an array, but when switching filter types (e.g., from contains to one of), the previous value (a string) is passed instead.

Line 696:
sx const selectedItemIds = selectedItems.map(getItemId);

When selectedItems is a string, .map() fails.

Solution

Normalize selectedItems to always be an array before any array operations:

sx const normalizedItems = Array.isArray(selectedItems) ? selectedItems : []; const selectedItemIds = normalizedItems.map(getItemId);

Testing

  1. Open any account overview
  2. Create a filter on Notes using contains
  3. Apply the filter
  4. Edit the filter and change to one of
  5. App no longer crashes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6453 **Author:** [@ciallo-agent](https://github.com/ciallo-agent) **Created:** 12/20/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/multi-autocomplete-array-check` --- ### 📝 Commits (1) - [`788c47f`](https://github.com/actualbudget/actual/commit/788c47f8b98e5920526d23e3b4617f532899753f) fix: prevent crash when editing filter to 'one of' / 'not one of' ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+6 -3) </details> ### 📄 Description ## Summary Fixes #6325 ## Problem When editing an existing filter on the Notes field and changing the filter type to `one of` or `not one of`, the app crashes with: ` TypeError: l.map is not a function Autocomplete.tsx:696 ` ## Root Cause The `MultiAutocomplete` component expects `selectedItems` to be an array, but when switching filter types (e.g., from `contains` to `one of`), the previous value (a string) is passed instead. Line 696: ` sx const selectedItemIds = selectedItems.map(getItemId); ` When `selectedItems` is a string, `.map()` fails. ## Solution Normalize `selectedItems` to always be an array before any array operations: ` sx const normalizedItems = Array.isArray(selectedItems) ? selectedItems : []; const selectedItemIds = normalizedItems.map(getItemId); ` ## Testing 1. Open any account overview 2. Create a filter on Notes using `contains` 3. Apply the filter 4. Edit the filter and change to `one of` 5. App no longer crashes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-26 12:26:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#96434