github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6301] [MERGED] Fix lint violations (vol.3) #96335

New Issue
Closed
opened 2026-05-26 12:12:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-26 12:12:35 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6301
Author: @MatissJanis
Created: 12/4/2025
Status: ✅ Merged
Merged: 12/9/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-other-lint-issues-2

📝 Commits (8)

  • f56695b Fix lint violations
  • 21d53e9 Refactor code for clarity and consistency
  • 8a8d68a Enhance accessibility and linting compliance
  • d310eb6 Add new keywords to spelling allowlist
  • d4a94c7 Merge branch 'master' into matiss/fix-other-lint-issues-2
  • 061b89a Disable no-autofocus rule in .oxlintrc.json
  • 770f87e Update Trans component usage in MergeUnusedPayeesModal
  • 211c5c1 [autofix.ci] apply automated fixes

📊 Changes

16 files changed (+45 additions, -29 deletions)

View changed files

📝 .github/actions/docs-spelling/allow/keywords.txt (+2 -0)
📝 .oxlintrc.json (+2 -5)
📝 packages/component-library/src/Toggle.tsx (+1 -0)
📝 packages/desktop-client/src/components/Page.tsx (+1 -0)
📝 packages/desktop-client/src/components/common/Modal.tsx (+1 -0)
📝 packages/desktop-client/src/components/modals/EditAccess.tsx (+2 -2)
📝 packages/desktop-client/src/components/modals/EditUser.tsx (+8 -8)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx (+6 -0)
📝 packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx (+6 -4)
📝 packages/desktop-client/src/components/modals/TransferOwnership.tsx (+6 -6)
📝 packages/desktop-client/src/components/reports/FormulaResult.tsx (+0 -1)
📝 packages/desktop-client/src/components/reports/ReportCardName.tsx (+1 -0)
📝 packages/desktop-client/src/components/reports/SummaryNumber.tsx (+0 -1)
📝 packages/desktop-client/src/components/settings/AuthSettings.tsx (+2 -2)
📝 packages/docs/src/components/Image.jsx (+1 -0)
➕ upcoming-release-notes/6301.md (+6 -0)

📄 Description

  • Updated .oxlintrc.json to add a warning for jsx-a11y/no-autofocus and removed several disabled rules.
  • Added aria-level attributes to improve semantic structure in Page.tsx, Modal.tsx, and ReportCardName.tsx.
  • Replaced <label> elements with <Text> components in various modals to ensure proper accessibility.
  • Added htmlFor attributes to labels in ImportTransactionsModal.tsx for better form accessibility.
  • Disabled specific linting rules inline to address accessibility concerns in Image.jsx and Toggle.tsx.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6301 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 12/9/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-other-lint-issues-2` --- ### 📝 Commits (8) - [`f56695b`](https://github.com/actualbudget/actual/commit/f56695b08d4bbcf578f1aac3c73e0695b077c458) Fix lint violations - [`21d53e9`](https://github.com/actualbudget/actual/commit/21d53e98bc7a184f3db36113418b99e50e225c16) Refactor code for clarity and consistency - [`8a8d68a`](https://github.com/actualbudget/actual/commit/8a8d68ae5b6253e79d231ac16d296b2b4dd101d0) Enhance accessibility and linting compliance - [`d310eb6`](https://github.com/actualbudget/actual/commit/d310eb60752733c441fec1658e9cf0b718b711ac) Add new keywords to spelling allowlist - [`d4a94c7`](https://github.com/actualbudget/actual/commit/d4a94c76c428b9a8c26bd4b19aa86ca8cd82e2e0) Merge branch 'master' into matiss/fix-other-lint-issues-2 - [`061b89a`](https://github.com/actualbudget/actual/commit/061b89a37753da7bd0a8461505ed27e4aefc9fca) Disable no-autofocus rule in .oxlintrc.json - [`770f87e`](https://github.com/actualbudget/actual/commit/770f87e4f29661caf476ced8a6f13bc5ae856d9f) Update Trans component usage in MergeUnusedPayeesModal - [`211c5c1`](https://github.com/actualbudget/actual/commit/211c5c113f1b9fd31acd21e987c1a38bd0a78fd1) [autofix.ci] apply automated fixes ### 📊 Changes **16 files changed** (+45 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/docs-spelling/allow/keywords.txt` (+2 -0) 📝 `.oxlintrc.json` (+2 -5) 📝 `packages/component-library/src/Toggle.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/Page.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/common/Modal.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/modals/EditAccess.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/EditUser.tsx` (+8 -8) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` (+6 -0) 📝 `packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx` (+6 -4) 📝 `packages/desktop-client/src/components/modals/TransferOwnership.tsx` (+6 -6) 📝 `packages/desktop-client/src/components/reports/FormulaResult.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/reports/ReportCardName.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/reports/SummaryNumber.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/settings/AuthSettings.tsx` (+2 -2) 📝 `packages/docs/src/components/Image.jsx` (+1 -0) ➕ `upcoming-release-notes/6301.md` (+6 -0) </details> ### 📄 Description - Updated `.oxlintrc.json` to add a warning for `jsx-a11y/no-autofocus` and removed several disabled rules. - Added `aria-level` attributes to improve semantic structure in `Page.tsx`, `Modal.tsx`, and `ReportCardName.tsx`. - Replaced `<label>` elements with `<Text>` components in various modals to ensure proper accessibility. - Added `htmlFor` attributes to labels in `ImportTransactionsModal.tsx` for better form accessibility. - Disabled specific linting rules inline to address accessibility concerns in `Image.jsx` and `Toggle.tsx`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-26 12:12:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#96335