github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #5302] [CLOSED] Fix bank sync reimporting transactions that were moved to another account #95764

New Issue
Closed
opened 2026-05-26 10:48:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-26 10:48:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5302
Author: @rjackson
Created: 7/6/2025
Status: ❌ Closed

Base: master ← Head: fix-reimport-moved-transactions

📝 Commits (1)

  • 3f51e09 Fix bank sync reimporting transactions that were moved to another account

📊 Changes

3 files changed (+71 additions, -3 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.test.ts (+62 -0)
📝 packages/loot-core/src/server/accounts/sync.ts (+3 -3)
➕ upcoming-release-notes/5302.md (+6 -0)

📄 Description

When using the Monzo bank with pots, Monzo reports transactions from pots under the main current account with the payee suffixed "from [pot name]" rather than under the pot's own account. To fix this in my budget instance, I have created a rule which moves any transactions with suffixes matching my pots to their relevant pot accounts in Actual Budget.

When re-syncing however, the transactions are imported again, and again, and again – because the reconciliation logic here isn't accounting for the fact accounts could change after rules have been processed. We can fix this by making sure we try to match using trans.account instead of acctId.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5302 **Author:** [@rjackson](https://github.com/rjackson) **Created:** 7/6/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-reimport-moved-transactions` --- ### 📝 Commits (1) - [`3f51e09`](https://github.com/actualbudget/actual/commit/3f51e09fe05aa111fae6a66b2f5505e733d69079) Fix bank sync reimporting transactions that were moved to another account ### 📊 Changes **3 files changed** (+71 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+62 -0) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+3 -3) ➕ `upcoming-release-notes/5302.md` (+6 -0) </details> ### 📄 Description When using the Monzo bank with pots, Monzo reports transactions from pots under the main current account with the payee suffixed "from [pot name]" rather than under the pot's own account. To fix this in my budget instance, I have created a rule which moves any transactions with suffixes matching my pots to their relevant pot accounts in Actual Budget. When re-syncing however, the transactions are imported again, and again, and again – because the reconciliation logic here isn't accounting for the fact accounts could change after rules have been processed. We can fix this by making sure we try to match using `trans.account` instead of `acctId`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-26 10:48:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#95764
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?