github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #5235] feat: support _FILE variant for ACTUAL_OPENID_CLIENT_SECRET #95733

New Issue
Closed
opened 2026-05-26 10:44:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-26 10:44:28 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/5235

State: closed
Merged: No

Fixes #5233

Adds support for a _FILE variant of ACTUAL_OPENID_CLIENT_SECRET for better Docker secret management. Reads secret value from file if the _FILE env var is set. This will overwrite other settings of the secret through config.json or the ACTUAL_OPENID_CLIENT_SECRET environment variable.

The function was written somewhat generically to allow further expansion, but as no other secrets are exposed through variables only ACTUAL_OPENID_CLIENT_SECRET was given a _FILE overwrite.

To test, simply append this line after the function is invoked.
console.log('[DEBUG] Loaded OIDC secret:', configSchema.get('openId.client_secret'));
Output should be the contents of the file.

Release Notes

Type: Enhancements
Username(s): tim_connect
PR Number: #5235
Summary:
This PR adds support for reading the OpenID client secret from a file using the ACTUAL_OPENID_CLIENT_SECRET_FILE environment variable. This enables better handling of secrets in Docker and Kubernetes environments.

If both ACTUAL_OPENID_CLIENT_SECRET and ACTUAL_OPENID_CLIENT_SECRET_FILE are set, the _FILE variant takes precedence.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/5235 **State:** closed **Merged:** No --- Fixes #5233 Adds support for a _FILE variant of ACTUAL_OPENID_CLIENT_SECRET for better Docker secret management. Reads secret value from file if the _FILE env var is set. This will overwrite other settings of the secret through config.json or the ACTUAL_OPENID_CLIENT_SECRET environment variable. The function was written somewhat generically to allow further expansion, but as no other secrets are exposed through variables only ACTUAL_OPENID_CLIENT_SECRET was given a _FILE overwrite. To test, simply append this line after the function is invoked. ```console.log('[DEBUG] Loaded OIDC secret:', configSchema.get('openId.client_secret'));``` Output should be the contents of the file. ## Release Notes Type: Enhancements Username(s): tim_connect PR Number: #5235 Summary: This PR adds support for reading the OpenID client secret from a file using the `ACTUAL_OPENID_CLIENT_SECRET_FILE` environment variable. This enables better handling of secrets in Docker and Kubernetes environments. If both `ACTUAL_OPENID_CLIENT_SECRET` and `ACTUAL_OPENID_CLIENT_SECRET_FILE` are set, the `_FILE` variant takes precedence.
GiteaMirror added the pull-request label 2026-05-26 10:44:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#95733
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?