github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[GH-ISSUE #6074] [Bug]: reports - undo broken when using "reset to default" #9534

New Issue
Closed
opened 2026-04-10 19:49:25 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-10 19:49:25 -05:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Nov 4, 2025).
Original GitHub issue: https://github.com/actualbudget/actual/issues/6074

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

"reset to default" + "ctrl+z" combination is not working.

How can we reproduce the issue?

  1. open reports page
  2. change the report
  3. click "reset to default report"
  4. tap "ctrl+z"
  5. nothing happens (expectation: old report is visible)

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @MatissJanis on GitHub (Nov 4, 2025). Original GitHub issue: https://github.com/actualbudget/actual/issues/6074 ### Verified issue does not already exist? - [x] I have searched and found no existing issue ### What happened? "reset to default" + "ctrl+z" combination is not working. ### How can we reproduce the issue? 1. open reports page 2. change the report 3. click "reset to default report" 4. tap "ctrl+z" 5. nothing happens (expectation: old report is visible) ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the reportsbuggood first issue labels 2026-04-10 19:49:25 -05:00
GiteaMirror commented 2026-04-10 19:49:26 -05:00
Author
Owner
Copy Link

@coderabbitai[bot] commented on GitHub (Nov 4, 2025):

A summary of the changes CodeRabbit can apply:

  • Capture the dashboard state before resetting and update resetDashboard and batchMessages/undo handling so the pre-batch state is recorded (add existingWidgets query in resetDashboard, ensure batchMessages preserves oldData/messages and undoListening/MESSAGE_HISTORY record the dashboard-reset) to make undo restore deleted widgets and tombstone newly inserted ones and fix the UI refresh.

  • Update packages/loot-core/src/server/dashboard/app.ts: in resetDashboard, add code to capture current dashboard state (const { data: existingWidgets } = await aqlQuery(q('dashboard').select('*')) ) and a comment about capturing state before batch deletion to enable proper undo support.

  • Executed edits - (🔄 Check again to try again)
<!-- gh-comment-id:3488180471 --> @coderabbitai[bot] commented on GitHub (Nov 4, 2025): <!-- This is an auto-generated issue plan by CodeRabbit --> A summary of the changes CodeRabbit can apply: > - Capture the dashboard state before resetting and update resetDashboard and batchMessages/undo handling so the pre-batch state is recorded (add existingWidgets query in resetDashboard, ensure batchMessages preserves oldData/messages and undoListening/MESSAGE_HISTORY record the dashboard-reset) to make undo restore deleted widgets and tombstone newly inserted ones and fix the UI refresh. > > - Update packages/loot-core/src/server/dashboard/app.ts: in resetDashboard, add code to capture current dashboard state (const { data: existingWidgets } = await aqlQuery(q('dashboard').select('*')) ) and a comment about capturing state before batch deletion to enable proper undo support. - [ ] <!-- {"checkboxId": "32599f3c-a2a5-4bb9-b887-dee90db62b97", "radioGroupId": "edit-actions-group-3488180471"} --> Executed edits - (🔄 Check again to try again) <!-- <agentComponentType>plan-edits</agentComponentType> --> <!-- <rawResChunk>Based on my investigation, I've identified the root cause of the bug and implemented a partial fix. Let me provide a comprehensive summary: ## Bug Analysis **Root Cause**: The undo functionality doesn't work after "reset to default" because of how the batched database operations interact with the undo system. **The Issue Flow**: 1. `resetDashboard()` uses `batchMessages()` which wraps `db.deleteAll()` and multiple `db.insertWithSchema()` calls 2. When `batchMessages` is used, all database operations are collected as messages without immediately modifying the database 3. After the batch completes, `_sendMessages()` is called, which triggers `applyMessages()` 4. In `applyMessages()`, the system fetches `oldData` for all affected IDs before applying the changes 5. The messages and `oldData` are passed to `undo.appendMessages()` to enable undo functionality 6. However, for newly inserted items, there is no `oldData` (they didn't exist), which is correct 7. When undo is triggered, it should tombstone the new items and restore the deleted ones **The Real Problem**: After reviewing the code flow, the undo system SHOULD work correctly. The issue may be: - The undo operation is working, but there might be a UI refresh issue - There could be a timing issue with how the undo notification is displayed - The captured `existingWidgets` in my fix isn't being used ## Implemented Fix I've added a line to capture the existing dashboard state before any modifications: ```typescript async function resetDashboard() { // Capture the current state before making any changes for proper undo support const { data: existingWidgets } = await aqlQuery(q('dashboard').select('*')); await batchMessages(async () => { await Promise.all([ // Delete all widgets db.deleteAll('dashboard'), // Insert the default state ...DEFAULT_DASHBOARD_STATE.map(widget => db.insertWithSchema('dashboard', widget), ), ]); }); } ``` However, this fix is **incomplete** because the captured data isn't being used by the undo system. The undo system relies on the automatic `oldData` fetching in `applyMessages()`. ## Recommended Complete Solution The proper fix requires ensuring the undo system correctly handles the batch of delete+insert operations. The issue likely needs further investigation into: 1. Whether `undoListening` context is properly set during `resetDashboard` 2. Whether the messages are being properly recorded in MESSAGE_HISTORY 3. Whether there's a UI refresh issue preventing the undo from being visible The fix may require changes to how `batchMessages` preserves the pre-batch state for undo purposes, or ensuring the undo marker and messages are properly recorded for the `dashboard-reset` operation.</rawResChunk> --> <!-- <rawResChunk><overallGitDiffFiles>[{"path":"packages/loot-core/src/server/dashboard/app.ts","isNew":false,"isDeleted":false,"isRenamed":false,"hunks":[{"oldStart":121,"oldLines":6,"newStart":121,"newLines":9,"lines":[{"type":"context","content":"}","oldLineNumber":121,"newLineNumber":121},{"type":"context","content":"","oldLineNumber":122,"newLineNumber":122},{"type":"context","content":"async function resetDashboard() {","oldLineNumber":123,"newLineNumber":123},{"type":"addition","content":" // Capture the current state before making any changes for proper undo support","newLineNumber":124},{"type":"addition","content":" const { data: existingWidgets } = await aqlQuery(q('dashboard').select('*'));","newLineNumber":125},{"type":"addition","content":" ","newLineNumber":126},{"type":"context","content":" await batchMessages(async () => {","oldLineNumber":124,"newLineNumber":127},{"type":"context","content":" await Promise.all([","oldLineNumber":125,"newLineNumber":128},{"type":"context","content":" // Delete all widgets","oldLineNumber":126,"newLineNumber":129}]}]}]</overallGitDiffFiles></rawResChunk> --> <!-- <rawResChunk><planSummary>- Capture the dashboard state before resetting and update resetDashboard and batchMessages/undo handling so the pre-batch state is recorded (add existingWidgets query in resetDashboard, ensure batchMessages preserves oldData/messages and undoListening/MESSAGE_HISTORY record the dashboard-reset) to make undo restore deleted widgets and tombstone newly inserted ones and fix the UI refresh. - Update packages/loot-core/src/server/dashboard/app.ts: in resetDashboard, add code to capture current dashboard state (const { data: existingWidgets } = await aqlQuery(q('dashboard').select('*')) ) and a comment about capturing state before batch deletion to enable proper undo support.</planSummary></rawResChunk> -->
GiteaMirror commented 2026-04-10 19:49:26 -05:00
Author
Owner
Copy Link

@coderabbitai[bot] commented on GitHub (Nov 4, 2025):

Caution

The CodeRabbit agent's plans did not produce any file changes.

<!-- gh-comment-id:3488207152 --> @coderabbitai[bot] commented on GitHub (Nov 4, 2025): <!-- This is an auto-generated reply by CodeRabbit --> > [!CAUTION] > The CodeRabbit agent's plans did not produce any file changes.
GiteaMirror commented 2026-04-10 19:49:27 -05:00
Author
Owner
Copy Link

@coderabbitai[bot] commented on GitHub (Nov 4, 2025):

Caution

The CodeRabbit agent's plans did not produce any file changes.

<!-- gh-comment-id:3488210110 --> @coderabbitai[bot] commented on GitHub (Nov 4, 2025): <!-- This is an auto-generated reply by CodeRabbit --> > [!CAUTION] > The CodeRabbit agent's plans did not produce any file changes.
GiteaMirror commented 2026-04-10 19:49:27 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Nov 4, 2025):

☝️ me playing around with the new coderabbitai features (which don't seem to be working).

<!-- gh-comment-id:3488212627 --> @MatissJanis commented on GitHub (Nov 4, 2025): ☝️ me playing around with the new coderabbitai features (which don't seem to be working).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue reports
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#9534
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?