github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 11:59:55 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #394] [MERGED] fix(useSheetValue): default value should be null not undefined #93001

New Issue
Closed
opened 2026-05-26 05:12:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-26 05:12:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/394
Author: @MatissJanis
Created: 11/20/2022
Status: ✅ Merged
Merged: 11/21/2022
Merged by: @jlongster

Base: master ← Head: matiss/fix-reconciliation

📝 Commits (2)

  • d39cb9e fix(useSheetValue): default value should be null not undefined
  • 745e734 fix: add default value to be even more secure against future regressions

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.js (+1 -0)
📝 packages/loot-design/src/components/spreadsheet/useSheetValue.js (+1 -1)

📄 Description

Fixes #393

Problem: clicking on "reconcile" causes a fatal page crash.

Issue:
by default useSheetValue returns undefined value.

In the calculations we use cleared balance minus targetBalance (customer input) to calculate targetDiff. If cleared is undefined, we end up with targetBalance === NaN.

targetBalance later is used in the format() util function. This function expects number values and not a NaN.

4904da5006/packages/desktop-client/src/components/accounts/Account.js (L107-L111)

Fix:
The simple fix is to return null by default in useSheetValue. null is already used as a default value for string-type bindings here, so IMO this change is safe to be applied.

console.log(100 - null) // 100
console.log(100 - undefined) // NaN

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/394 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 11/20/2022 **Status:** ✅ Merged **Merged:** 11/21/2022 **Merged by:** [@jlongster](https://github.com/jlongster) **Base:** `master` ← **Head:** `matiss/fix-reconciliation` --- ### 📝 Commits (2) - [`d39cb9e`](https://github.com/actualbudget/actual/commit/d39cb9eac53a3ca5858a0bd89d4ee3918c4725c4) fix(useSheetValue): default value should be null not undefined - [`745e734`](https://github.com/actualbudget/actual/commit/745e734519aae35f28b07450ff8946193152d269) fix: add default value to be even more secure against future regressions ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.js` (+1 -0) 📝 `packages/loot-design/src/components/spreadsheet/useSheetValue.js` (+1 -1) </details> ### 📄 Description Fixes #393 --- **Problem:** clicking on "reconcile" causes a fatal page crash. **Issue:** by default `useSheetValue` returns `undefined` value. In the calculations we use `cleared` balance minus `targetBalance` (customer input) to calculate `targetDiff`. If `cleared` is `undefined`, we end up with `targetBalance === NaN`. `targetBalance` later is used in the `format()` util function. This function expects number values and not a `NaN`. https://github.com/MatissJanis/actual/blob/4904da500672f11d28bc47ddedfbaaae94b96aeb/packages/desktop-client/src/components/accounts/Account.js#L107-L111 **Fix:** The simple fix is to return `null` by default in `useSheetValue`. `null` is already used as a default value for `string`-type bindings [here](https://github.com/MatissJanis/actual/blob/master/packages/loot-design/src/components/spreadsheet/useSheetValue.js#L25-L26), so IMO this change is safe to be applied. ``` console.log(100 - null) // 100 console.log(100 - undefined) // NaN ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-26 05:12:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#93001
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?