mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-16 07:04:23 -05:00
[GH-ISSUE #3559] [Bug]: Deleting Custom Reports (experimental feature not activated) will result in empty spaces if you create new custom reports #91097
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @argeljoseph on GitHub (Oct 4, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/3559
Verified issue does not already exist?
What happened?
Steps to reproduce:
Before, the new reports (after some reports are deleted),go to the "empty space"

Where are you hosting Actual?
Docker
What browsers are you seeing the problem on?
Firefox, Chrome, Microsoft Edge
Operating System
Linux
@andfreund commented on GitHub (Oct 14, 2024):
This bug still persists in my self-hosted Actual Budget instance, using Docker:
Both client and server versions are v24.10.1, so am I right assuming that this bug should have been fixed?
@youngcw commented on GitHub (Oct 14, 2024):
Try testing on the edge build. edge.actualbudget.org
@andfreund commented on GitHub (Oct 14, 2024):
Tested it with the edge build and got the same behavior.
@MatissJanis commented on GitHub (Oct 15, 2024):
@andfreund the patch applied here is indeed not perfect. It's only a stop-gap solution until we release the dashboard feature.
Let me explain what happens:
The reports page is now using a dashboard grid (both with & without the feature flag). It renders widgets on this grid. If a new custom report is created - it automatically adds it to the grid with "next" positions.
When three custom reports are added - that covers the first row. The fourth widget goes on a new row.
But now you delete 1st widget.. the grid is configured to collapse vertically, so the 4th widget will now "collapse" into the position of 1st. So you see a full row of 3 widgets. Most users won't notice this and it will feel like things are working as expected.
But then you delete the 2nd widget. Now you have a gap between the two widgets on the first row. And since we collapse vertically - the gap still remains there. We don't update the coordinates of the 3rd widget.
The two solutions I considered were:
So I went with (1). And if folks encounter issues - direct them to enable the dashboards experimental feature and then just manually drag-n-drop to patch the dashboard.
Ok, that's a long description of the issue, but I hope you now understand it more. TLDR: no plans to fully patch this issue in the short-term because dashboard will be released soon (aiming for v24.12.0).