mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-16 07:04:23 -05:00
[GH-ISSUE #2149] Cannot enter amount on mobile #90469
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#90469
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gagegogan on GitHub (Dec 31, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/2149
Verified issue does not already exist?
What happened?
On a mobile device, specifically iOS you cannot focus the amount input to enter an amount. The keyboard will not open.
What error did you receive?
None
https://github.com/actualbudget/actual/assets/10763068/b5377c2d-bd9a-4fc1-b62a-27de3f795062
Where are you hosting Actual?
None
What browsers are you seeing the problem on?
Chrome, Safari
Operating System
Mobile Device
@Kidglove57 commented on GitHub (Dec 31, 2023):
This is odd. I am using an iPhone 15 Pro Max with iOS 17 and I am able to add transactions. See clip attached.
@Kidglove57 commented on GitHub (Dec 31, 2023):
https://github.com/actualbudget/actual/assets/93882449/327541e3-bc48-4606-97ee-7e5432fb7673
@gagegogan commented on GitHub (Dec 31, 2023):
I am on a iPhone 13 Pro Max. I tried it in Chrome and Safari. It just toggles between positive and negative.
@gagegogan commented on GitHub (Dec 31, 2023):
I tried it in the demo server. Please do the same
@gagegogan commented on GitHub (Dec 31, 2023):
Just another note. Locally installed Actual onto my laptop, and the same issue occurs. If I click on it with a mouse, it just toggles between positive and negative.
@gagegogan commented on GitHub (Dec 31, 2023):
Just tested version 23.11.0 and the keyboard opens
@gagegogan commented on GitHub (Dec 31, 2023):
OK. I just spun up my own server and it works fine. It's an issue with the demo website.
@rich-howell commented on GitHub (Jan 1, 2024):
@MatissJanis can you re-open this? The issue exists in the edge build releasing would cause an issue entering new transactions.
@Kidglove57 commented on GitHub (Jan 1, 2024):
Good spot @rich-howell!
I can also reproduce this in Edge.
@gagegogan I was using the latest 2023-12 rather than Edge
@gagegogan commented on GitHub (Jan 1, 2024):
Reopened due to your comment @rich-howell
@MatissJanis commented on GitHub (Jan 1, 2024):
Thanks! This is definitely something we need to address before releasing v24.1.0
@MatissJanis commented on GitHub (Jan 1, 2024):
cc @joel-jeremy I suspect #2068 is breaking this. Do you have any quick ideas what might be at fault here? If not I'd be inclined to revert the PR in order to unblock the release.
@joel-jeremy commented on GitHub (Jan 1, 2024):
This might be caused by blur behavior in iOS
@joel-jeremy commented on GitHub (Jan 3, 2024):
@gagegogan Can you test if https://github.com/actualbudget/actual/pull/2166 fixes the issue?
@gagegogan commented on GitHub (Jan 3, 2024):
No change. The same issue still persists.
@Kidglove57 commented on GitHub (Jan 3, 2024):
Agreed - no change for me either
@gagegogan commented on GitHub (Jan 3, 2024):
This issue really baffles me. I was comparing edge to the latest stable release, and I don't see any breaking chains that could've caused it. Then again, I'm not familiar with the code base. Or react for that matter. I'm a vie guy.
@joel-jeremy commented on GitHub (Jan 3, 2024):
That's weird, it works just fine in Android. In your video I can also see that the amount field is entering it's focused state.
@gagegogan commented on GitHub (Jan 3, 2024):
Is there an API that you can just call the keyboard to open on focus? Might be a quick fix. Additionally, do a platform check
@rich-howell commented on GitHub (Jan 3, 2024):
The focus state changes but no keyboard appears.
If I run it in the dev console on the desktop I can replicate it but if I type on my keyboard numbers are inserted so it seems to be a suppression of the keyboard appearing for some reason.
@rich-howell commented on GitHub (Jan 3, 2024):
I went back to some older open pulls and #2108 doesn't have the issue.
@joel-jeremy commented on GitHub (Jan 3, 2024):
What could possibly be suppressing keyboard in iOS? I have pushed an update on the PR, could you please try again?
@gagegogan commented on GitHub (Jan 3, 2024):
I don't see an updated link on the PR
@joel-jeremy commented on GitHub (Jan 3, 2024):
Just click on the same netlify link on the PR
@gagegogan commented on GitHub (Jan 3, 2024):
Same issue occurs
@gagegogan commented on GitHub (Jan 3, 2024):
I wonder if the button is interfering in someway
@joel-jeremy commented on GitHub (Jan 3, 2024):
What do you mean?
I tried using a ref to focus on the input. Maybe that will force the keyboard to show up - can you try the link again? (Sorry I don't have an iOS device so I'm not able to test on my own)
@HansiWursti commented on GitHub (Jan 3, 2024):
Hi,
I surfed a little bit at the Web.
Is this maybe the problem?
https://stackoverflow.com/a/35768655/8741781
That the focus is not directy triggered by an user Input and iOS handle the focus in an interesting way?
Thank you!
@gagegogan commented on GitHub (Jan 3, 2024):
Still does not work. But I was referencing the button that caused the focus onto the input.
@joel-jeremy commented on GitHub (Jan 3, 2024):
This might be worth looking into. Pushed another update on the PR.
@gagegogan commented on GitHub (Jan 3, 2024):
Still not working.
@joel-jeremy commented on GitHub (Jan 3, 2024):
I guessing the
onRequestActiveEditcallback is causing the issue. It runs the edit action in an effect instead of synchronously from the button click event handler. I have updated the hook to run the action synchronously.@rich-howell commented on GitHub (Jan 4, 2024):
It works on iOS now the keyboard shows again and I can enter a transaction.
@Kidglove57 commented on GitHub (Jan 4, 2024):
Yes, confirmed all working now. Thanks for your perseverance!
@gagegogan commented on GitHub (Jan 4, 2024):
Also working for me.
@joel-jeremy commented on GitHub (Jan 4, 2024):
Re-opening this since the PR hasn't been reviewed and merged yet
@MatissJanis commented on GitHub (Jan 5, 2024):
Fix was merged