mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-15 22:54:03 -05:00
[GH-ISSUE #563] [Feature] Category Notes - Reveal on hover #89864
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#89864
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rich-howell on GitHub (Jan 22, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/563
Discussed in https://github.com/actualbudget/actual/discussions/344
Originally posted by Kidglove57 December 1, 2021
When allocating budgeted amounts each month, I rely on my category notes which are helpfully stored in the budget screen. At present I need to click into each note individually to check the amount. It would be SO helpful if my notes could be revealed by just hovering the mouse over the notes icon instead. See YNAB4 purely as an example of where this has been done before.
@TechwizEE commented on GitHub (Jan 25, 2023):
Agreed on making it easier to reveal the notes. Would this "hover view" also be the way to edit the notes? Or would it still required a click? (Seems a click might help prevent accidental editing)
@Kidglove57 commented on GitHub (Jan 25, 2023):
100% agree on click to edit note.
I would use the hover mainly to double check the note for what I need to enter as a new month category budget amount.
@gsumpster commented on GitHub (Jan 27, 2023):
Hey, I was interested in taking a stab at this, here's what I put together.
The preview tooltip will pop up on hover of the notes button and display the tooltip (smaller, limited to 220px in width, not restricted on height). If you move your cursor into the text, you'd be able to copy and interact with the text without the tooltip disappearing (easy to change, but think this would be my preference!). Clicking on the notes button will flip the tooltip into editing mode and act as it already does in Actual.
Here are my changes; happy to create a PR if we're happy with this interaction:
https://github.com/actualbudget/actual/compare/master...gsumpster:gsumpster.reveal-notes-on-hover
I didn't modify the Tooltip component directly (scary file!), felt that introducing another event there would impact the rest of the application a little too much given its usage elsewhere.
@Kidglove57 commented on GitHub (Jan 27, 2023):
I love what you have done here! Thank you very much.
It is exactly what I envisaged when I first raised this a couple of years ago (I think on Slack). A great addition in my view.
Unfortunately, I have no skills to comment on the technicals so this is just a user perspective.
@j-f1 commented on GitHub (Jan 27, 2023):
@gsumpster That looks great! I think the only nitpick I have would be to rewrite lines 31–54 as a ternary but otherwise it looks great :)
@gsumpster commented on GitHub (Jan 27, 2023):
Sweet, thank you both for taking a look! I'll switch those lines over to a ternary and put up a PR!