github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7903] [MERGED] Correct handling of negative budgeting and "positive" spending in Sankey chart #89615

New Issue
Closed
opened 2026-05-22 14:09:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-22 14:09:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7903
Author: @emiltb
Created: 5/19/2026
Status: ✅ Merged
Merged: 5/19/2026
Merged by: @matt-fidd

Base: master ← Head: sankey/negative-transactions

📝 Commits (6)

  • d89d571 Handle negative values in spent graph
  • 1a967bd Fix layer placement
  • cc9ea5b Fix bug in percentage calculation
  • 4897982 Add release note
  • ae0b8cd Add special key to "positive spending"
  • 1c3c16e Fix failing test

📊 Changes

3 files changed (+214 additions, -115 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/spreadsheets/sankey-spreadsheet.test.ts (+55 -1)
📝 packages/desktop-client/src/components/reports/spreadsheets/sankey-spreadsheet.ts (+153 -114)
➕ upcoming-release-notes/7903.md (+6 -0)

📄 Description

Description

Fixes previously unhandled edge-cases of negative budgeting and net positive transactions as spending. Also fixes a bug in percentage calculations, so now each layer always sums to 100%.

I wrote the handling of negative budgeting + positive spending and percentage calculation. Opencode / GPT5.3-Codex helped with fixing the layer placement and wrote the tests.

Related issue(s)

Relates to #1919.

Testing

Verified with a custom test budget (2026-05-19-Test_Budget_negative.zip), which contained all the targeted edge cases.

2026-05-19T19:32:20,547844424+02:00 2026-05-19T19:32:13,586811070+02:00

Existing unit tests pass and a few more have been added.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 33 13.99 MB → 13.99 MB (+1.1 kB) +0.01%
loot-core 1 5.34 MB 0%
api 2 3.96 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
33 13.99 MB → 13.99 MB (+1.1 kB) +0.01%
Changeset
File Δ Size
src/components/reports/spreadsheets/sankey-spreadsheet.ts 📈 +1.1 kB (+3.87%) 28.31 kB → 29.41 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.25 MB → 1.25 MB (+1.1 kB) +0.09%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 2.02 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ScheduleEditForm.js 146.45 kB 0%
static/js/TransactionEdit.js 86.89 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.08 MB 0%
static/js/bankSyncUtils.js 54.15 kB 0%
static/js/ca.js 186.78 kB 0%
static/js/chart-theme.js 800.08 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.17 kB 0%
static/js/de.js 170.27 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 197.83 kB 0%
static/js/es.js 178.71 kB 0%
static/js/extends.js 500.36 kB 0%
static/js/fr.js 178.61 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.02 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.08 kB 0%
static/js/nl.js 106.24 kB 0%
static/js/pt-BR.js 188.46 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.48 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 207.38 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.92 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.BkJq0HmC.js 5.34 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.96 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.96 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7903 **Author:** [@emiltb](https://github.com/emiltb) **Created:** 5/19/2026 **Status:** ✅ Merged **Merged:** 5/19/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `sankey/negative-transactions` --- ### 📝 Commits (6) - [`d89d571`](https://github.com/actualbudget/actual/commit/d89d571633a254393a885ae5431a39233f78735c) Handle negative values in spent graph - [`1a967bd`](https://github.com/actualbudget/actual/commit/1a967bdb7a9db948c34acb3ec2f7aa8a591f803f) Fix layer placement - [`cc9ea5b`](https://github.com/actualbudget/actual/commit/cc9ea5b0977874947b6e8cb5dc912254c4aa40ee) Fix bug in percentage calculation - [`4897982`](https://github.com/actualbudget/actual/commit/48979822353ea216165b70176e78be082083b528) Add release note - [`ae0b8cd`](https://github.com/actualbudget/actual/commit/ae0b8cdb61b5d5fd01093536587460a91ca77fbb) Add special key to "positive spending" - [`1c3c16e`](https://github.com/actualbudget/actual/commit/1c3c16e42af5e9c25da544e39ef55f359580f746) Fix failing test ### 📊 Changes **3 files changed** (+214 additions, -115 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/spreadsheets/sankey-spreadsheet.test.ts` (+55 -1) 📝 `packages/desktop-client/src/components/reports/spreadsheets/sankey-spreadsheet.ts` (+153 -114) ➕ `upcoming-release-notes/7903.md` (+6 -0) </details> ### 📄 Description ## Description Fixes previously unhandled edge-cases of negative budgeting and net positive transactions as spending. Also fixes a bug in percentage calculations, so now each layer always sums to 100%. I wrote the handling of negative budgeting + positive spending and percentage calculation. Opencode / GPT5.3-Codex helped with fixing the layer placement and wrote the tests. ## Related issue(s) Relates to #1919. ## Testing Verified with a custom test budget ([2026-05-19-Test_Budget_negative.zip](https://github.com/user-attachments/files/28025365/2026-05-19-Test_Budget_negative.zip)), which contained all the targeted edge cases. <img width="927" height="420" alt="2026-05-19T19:32:20,547844424+02:00" src="https://github.com/user-attachments/assets/c809bf3e-0f00-483f-9cfa-8ea8189989a0" /> <img width="925" height="416" alt="2026-05-19T19:32:13,586811070+02:00" src="https://github.com/user-attachments/assets/dfd78ebd-dd8b-44e8-ba39-61ac34e9081e" /> Existing unit tests pass and a few more have been added. ## Checklist - [X] Release notes added (see link above) - [X] No obvious regressions in affected areas - [X] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 33 | 13.99 MB → 13.99 MB (+1.1 kB) | +0.01% loot-core | 1 | 5.34 MB | 0% api | 2 | 3.96 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 33 | 13.99 MB → 13.99 MB (+1.1 kB) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/spreadsheets/sankey-spreadsheet.ts` | 📈 +1.1 kB (+3.87%) | 28.31 kB → 29.41 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.25 MB → 1.25 MB (+1.1 kB) | +0.09% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 2.02 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/TransactionEdit.js | 86.89 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.08 MB | 0% static/js/bankSyncUtils.js | 54.15 kB | 0% static/js/ca.js | 186.78 kB | 0% static/js/chart-theme.js | 800.08 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.17 kB | 0% static/js/de.js | 170.27 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 197.83 kB | 0% static/js/es.js | 178.71 kB | 0% static/js/extends.js | 500.36 kB | 0% static/js/fr.js | 178.61 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.02 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.08 kB | 0% static/js/nl.js | 106.24 kB | 0% static/js/pt-BR.js | 188.46 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 207.38 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.92 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BkJq0HmC.js | 5.34 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.96 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.96 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-22 14:09:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#89615
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?