github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6442] [CLOSED] fix autocomplete, categoryAutocomplete: handle ArrowDown from null hi… #88711

New Issue
Closed
opened 2026-05-22 12:23:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-22 12:23:20 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6442
Author: @lucioperez01
Created: 12/18/2025
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (7)

  • 3f1fddc fix autocomplete, categoryAutocomplete: handle ArrowDown from null highlightedIndex and skip 'Split Transaction'
  • 4f37225 Merge branch 'master' into master
  • 7af3a40 Merge branch 'master' into master
  • 5aae9cd Merge branch 'master' into master
  • 77b8043 Update packages/desktop-client/src/components/autocomplete/Autocomplete.tsx
  • 10ad30c [autofix.ci] apply automated fixes
  • 5488122 Merge branch 'master' into master

📊 Changes

2 files changed (+20 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+18 -0)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+2 -4)

📄 Description

fixes #6410
[Bug]: Down arrow key no longer selects category #6410

• Fixes the behavior of the category dropdown when pressing ArrowDown from a null highlightedIndex.
• Added a new prop skipSplit to skip the "Split Transaction" option.
• Includes a demo video showing the functionality in action.

Problem / Motivation:
Before this fix, pressing ArrowDown in the category autocomplete could fail when no item was initially highlighted, and the "Split Transaction" option was selectable even when it shouldn’t be.

Solution:
• Added handling for ArrowDown from a null highlightedIndex to correctly highlight the first selectable item.
• Added a new prop skipSplit to automatically skip the "Split Transaction" option in the dropdown.

Demo:
• See attached video for the updated behavior.

Impact:
• Users can navigate the dropdown with ArrowDown reliably.
• "Split Transaction" is skipped when necessary, avoiding accidental selection.

https://github.com/user-attachments/assets/f46fc6b7-7bbd-498c-b4ba-21869d467887

Summary by CodeRabbit

  • New Features

    • Added a configurable option to control skipping of special "split" suggestions during initial keyboard navigation.

  • Bug Fixes

    • Improved arrow-key behavior in autocomplete so the first highlighted item is more predictable when special items are present.
    • Made category autocomplete consistently avoid auto-highlighting split items and explicitly set initial highlight behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6442 **Author:** [@lucioperez01](https://github.com/lucioperez01) **Created:** 12/18/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`3f1fddc`](https://github.com/actualbudget/actual/commit/3f1fddc290b0f3bf163fe555e28e12aff26b1785) fix autocomplete, categoryAutocomplete: handle ArrowDown from null highlightedIndex and skip 'Split Transaction' - [`4f37225`](https://github.com/actualbudget/actual/commit/4f3722518216bc0cb2a6952081ef6b6c4900668b) Merge branch 'master' into master - [`7af3a40`](https://github.com/actualbudget/actual/commit/7af3a40037b601a9489ffa4430f4b35e8b627f07) Merge branch 'master' into master - [`5aae9cd`](https://github.com/actualbudget/actual/commit/5aae9cd46622142647370d4efad17a8282b889e8) Merge branch 'master' into master - [`77b8043`](https://github.com/actualbudget/actual/commit/77b80431f044bb1490bd56fb6158310a704d78ae) Update packages/desktop-client/src/components/autocomplete/Autocomplete.tsx - [`10ad30c`](https://github.com/actualbudget/actual/commit/10ad30c20457e846d5f95fd9a774d58d1aa6272d) [autofix.ci] apply automated fixes - [`5488122`](https://github.com/actualbudget/actual/commit/54881220492cf33f2048b51afa621f854fd88437) Merge branch 'master' into master ### 📊 Changes **2 files changed** (+20 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+18 -0) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+2 -4) </details> ### 📄 Description fixes #6410 [Bug]: Down arrow key no longer selects category #6410 • Fixes the behavior of the category dropdown when pressing ArrowDown from a null highlightedIndex. • Added a new prop skipSplit to skip the "Split Transaction" option. • Includes a demo video showing the functionality in action. Problem / Motivation: Before this fix, pressing ArrowDown in the category autocomplete could fail when no item was initially highlighted, and the "Split Transaction" option was selectable even when it shouldn’t be. Solution: • Added handling for ArrowDown from a null highlightedIndex to correctly highlight the first selectable item. • Added a new prop skipSplit to automatically skip the "Split Transaction" option in the dropdown. Demo: • See attached video for the updated behavior. Impact: • Users can navigate the dropdown with ArrowDown reliably. • "Split Transaction" is skipped when necessary, avoiding accidental selection. https://github.com/user-attachments/assets/f46fc6b7-7bbd-498c-b4ba-21869d467887 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a configurable option to control skipping of special "split" suggestions during initial keyboard navigation. * **Bug Fixes** * Improved arrow-key behavior in autocomplete so the first highlighted item is more predictable when special items are present. * Made category autocomplete consistently avoid auto-highlighting split items and explicitly set initial highlight behavior. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-22 12:23:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#88711